From: Robert Adesam <robert@adesam.se>
To: emacs-orgmode@gnu.org
Subject: org-store-link calls external link type store functions twice?
Date: Tue, 7 May 2013 21:51:37 +0200 [thread overview]
Message-ID: <CAF_idWDZ55HDyTKrHAW=p-0uOaqDpKcNeRJaKsMcdcvUAhL_GA@mail.gmail.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 1188 bytes --]
Hi fellow orgmoders,
I am not sure this is a bug but in version 8.x storing a link using an
external link type, org-store-link seems to call the external link type's
store function twice... I noticed this as I use an external link type that
asynchronous updates an external filedatabase and started to get random
file lock errors -- the org-store-link second call to the external link
type's store function sometimes came too quickly after the first one. :-)
Also, I do not have this problem in version 7.x of orgmode.
Instead of reverting back to a previous version of orgmode I started to
investigate -- attaching a patch that seems to help me anyway. It's not
that well tested and maybe, as I am not that familiar with everything going
on when storing a link using an external link type, it will break other
things...
yours,
/robert
PS. I will not file a formal bug report as it might not be a bug, just me
getting upset of a probable superfluous funcall...
M-x version:
GNU Emacs 24.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.6.4) of 2013-04-14 on
marid, modified by Debian
M-x org-version:
Org-mode version 8.0.2 (8.0.2-10-g3e1d83-elpa @
/home/robert/.emacs.d/elpa/org-20130506/)
[-- Attachment #1.2: Type: text/html, Size: 1294 bytes --]
[-- Attachment #2: org.el.patch --]
[-- Type: application/octet-stream, Size: 492 bytes --]
--- org.el 2013-05-07 21:04:42.230265766 +0200
+++ org.new.el 2013-05-07 21:04:11.374459978 +0200
@@ -9389,10 +9389,9 @@
(completing-read
"Which function for creating the link? "
sfunsn t (car sfunsn)))))
- (funcall (caar sfuns)))
(setq link (plist-get org-store-link-plist :link)
desc (or (plist-get org-store-link-plist
- :description) link))))
+ :description) link)))))
;; Store a link from a source code buffer
((org-src-edit-buffer-p)
next reply other threads:[~2013-05-07 19:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 19:51 Robert Adesam [this message]
2013-05-14 8:41 ` org-store-link calls external link type store functions twice? Bastien
2013-05-14 13:04 ` Robert Adesam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF_idWDZ55HDyTKrHAW=p-0uOaqDpKcNeRJaKsMcdcvUAhL_GA@mail.gmail.com' \
--to=robert@adesam.se \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).