From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id cPwuLV0l0GNJ9QAAbAwnHQ (envelope-from ) for ; Tue, 24 Jan 2023 19:37:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id sL7/LF0l0GM86wAAauVa8A (envelope-from ) for ; Tue, 24 Jan 2023 19:37:17 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 902AA21EEB for ; Tue, 24 Jan 2023 19:37:17 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKO9b-00032o-Et; Tue, 24 Jan 2023 13:36:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKO9X-00032d-Mi for emacs-orgmode@gnu.org; Tue, 24 Jan 2023 13:36:15 -0500 Received: from mail-qt1-f179.google.com ([209.85.160.179]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pKO9V-0006An-Mb for emacs-orgmode@gnu.org; Tue, 24 Jan 2023 13:36:15 -0500 Received: by mail-qt1-f179.google.com with SMTP id j9so13892921qtv.4 for ; Tue, 24 Jan 2023 10:36:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3+gin5Y1fbEDrP8NrTXvCcx2VtAJMzKiu3n265KuFA0=; b=fwiSpwOR2t/bSRwFl8Et7vBml5cGlni1BUmxUiZzVsGEXoJSj3sfToWHAed6BxmD8j bKmA/tumVZP5FA4zD06nxIfRTXebTBwYKMJQjtZxfPr2MxipbAfrfUWwKQ5Z+EiER5Vz oPC8k1LexHa/G700i9UcCcclzoE5SGSNEfTZmaTaFBHY9KiQEJafnfo5duhHQ0HNO48Z P4d9XfwgHK1n9lDlkaw2BkFzUFGsThNZ3xhF1Nclo0xLj+L6pGxfOlRy7wgpQ9Ypw3ge b25iFD57NIRFi9Dqb1fmaf/qN6uXqwb8vxD1zPxoXV48+g+oHGbkZWIB0ZTDHLid8Qvi 37UA== X-Gm-Message-State: AFqh2kroHmWQcYWbHEDGVu02bP8XbjdUxm/NYpIbVD1IKcF+9uCLs9sL miEgK+ok44NQszSqFwGqxm7Y5qx1hNw= X-Google-Smtp-Source: AMrXdXuyC5AB7ap2z8iJxK7Z0T+NkPzlxwxWhJ6PTpRkEAvSbYYjJy1w9tSWieWRKzEwgs9jRbnaXw== X-Received: by 2002:ac8:4e23:0:b0:3ab:af31:ee3e with SMTP id d3-20020ac84e23000000b003abaf31ee3emr31465243qtw.60.1674585372058; Tue, 24 Jan 2023 10:36:12 -0800 (PST) Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com. [209.85.219.174]) by smtp.gmail.com with ESMTPSA id h11-20020ac8776b000000b003b62e9c82ebsm1687725qtu.48.2023.01.24.10.36.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Jan 2023 10:36:11 -0800 (PST) Received: by mail-yb1-f174.google.com with SMTP id 203so20010444yby.10 for ; Tue, 24 Jan 2023 10:36:11 -0800 (PST) X-Received: by 2002:a25:8182:0:b0:802:8d0:c870 with SMTP id p2-20020a258182000000b0080208d0c870mr1603996ybk.434.1674585371409; Tue, 24 Jan 2023 10:36:11 -0800 (PST) MIME-Version: 1.0 References: <20230124025259.1301063-1-me@bcc32.com> <87358070bu.fsf@localhost> <87k01bokt7.fsf@localhost> In-Reply-To: <87k01bokt7.fsf@localhost> From: Aaron Zeng Date: Tue, 24 Jan 2023 13:35:34 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] lisp/org-agenda.el: Fix void-function string-pad in Emacs <28.1 To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Content-Type: multipart/alternative; boundary="00000000000035847c05f306cac5" Received-SPF: pass client-ip=209.85.160.179; envelope-from=zeng.aaron.l@gmail.com; helo=mail-qt1-f179.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.149, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674585437; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=3+gin5Y1fbEDrP8NrTXvCcx2VtAJMzKiu3n265KuFA0=; b=S2MKHmX2Z+d6o/Ec9DSyYaGCqRYqBaueZrgJrWbz/PJFoAG+FfeuYQLTHbi0Mrew2c2hFG 0xyT9XjjHFNqagYgAegyjPurcnoLRDpssroj19CwQodTKiVocA9IMucs7sZTIfCnfGGg9E HbvKxgvu8VaZcTFvzpQCHYsb0ZdyWOHrwAQPxRLcrNKGovazv8nReUfERyAeCRknw53ocR dCbqSXWQhKR8ovaaI6pVagqvgvIt/Npvucefrz5TBkGSwWaiNXpaGbR1rC5kQ+S88CNi7f hLbb1Y53WyR/NGEDXgFQAnfESiplNK21mhqYN8srAypOzbqXOm0gdqUOhWZEqg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674585437; a=rsa-sha256; cv=none; b=lQg1k0f7onXz/q9AekriRiBem16XvXp0q/YMiMbiTyeAWqIYhPUjJTDUtQUM50Cna3mcSg /pR03ygibUJVxNOa130dS7Jk0N47anaHzPNz5glpPDJj9QYIe5eX8jaFS6dxRRtSybN0Ts T4K+iTK1cQT67l5g1ZTNDW0tb13latNY9nDJoCC5bNedTLTh3wEDOGUxMBkwMvjsl/eaSG D3NFQTWpE5Syl+3uIfUJiZaa3BSX5pZI23Vw2rpUw1wLlQV7dD8dMEpAEJDa/gJBm9p+Ty r+PNE16SKPaYdZheeGrkSZxKKlGu9BvgnABTSwY5yOwWBWJp2LSSjBVxdb3Nrg== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Spam-Score: -1.38 X-Spam-Score: -1.38 X-Migadu-Queue-Id: 902AA21EEB X-TUID: RrPW2v88gL7G --00000000000035847c05f306cac5 Content-Type: text/plain; charset="UTF-8" Much obliged :) On Tue, Jan 24, 2023 at 1:20 PM Ihor Radchenko wrote: > Aaron Zeng writes: > > > Hi Ihor, I just noticed that this patch only fixes one of the lines > calling > > `string-pad'. There is another callsite below which needs to be removed. > > Oops. Now, should be good. > > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=20ee7b85ebc0e3e08805b1e9e3e824f50347340e > > -- > Ihor Radchenko // yantar92, > Org mode contributor, > Learn more about Org mode at . > Support Org development at , > or support my work at > --00000000000035847c05f306cac5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Much obliged :)

On Tue, Jan 24, 2023 at 1:20 PM Ihor Ra= dchenko <yantar92@posteo.net&= gt; wrote:
Aaron= Zeng <me@bcc32.com> writes:

> Hi Ihor, I just noticed that this patch only fixes one of the lines ca= lling
> `string-pad'.=C2=A0 There is another callsite below which needs to= be removed.

Oops. Now, should be good.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3D20= ee7b85ebc0e3e08805b1e9e3e824f50347340e

--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,=
or support my work at <https://liberapay.com/yantar92>
--00000000000035847c05f306cac5--