From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id CCA2KQ3E42NrawAAbAwnHQ (envelope-from ) for ; Wed, 08 Feb 2023 16:47:25 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id uAMvKQ3E42O79wAA9RJhRA (envelope-from ) for ; Wed, 08 Feb 2023 16:47:25 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6CAB6F8AB for ; Wed, 8 Feb 2023 16:47:25 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPmfK-00088m-D4; Wed, 08 Feb 2023 10:47:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPmeq-0007ve-8Q for emacs-orgmode@gnu.org; Wed, 08 Feb 2023 10:46:52 -0500 Received: from mail-qt1-f180.google.com ([209.85.160.180]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPmeo-0003SN-6b for emacs-orgmode@gnu.org; Wed, 08 Feb 2023 10:46:51 -0500 Received: by mail-qt1-f180.google.com with SMTP id h24so21128033qta.12 for ; Wed, 08 Feb 2023 07:46:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JVmxMG9s0RmJlCdQVvgtfWq9Nl8xRNqWtR0qIREffBU=; b=NlvuBnMy2rHJ1/o892lAY9QACYc2lXWgf84PkwkfRionWnyU3CG/c2FTFpQKe04BuC YmXTi8HX5A6jk1XAbGUwv93ZgqQiOZxiaRhQMDwZudgFgGIzG6jm6xCZ/RcPJ5D+eVuR 4K5VLvLz4ePTakse77zcsTjHtJ6lN/yZuCNYrRu3N6zjt0UVW40o5pYBSZFhSq3Vbp7n rmVk2I6+QtEsHrpXt7IWtd7/WQtDsQVvFMlJED57w0hz5hlKizHWI2H2V+rSCvXSQDRR ck6PcuHQTD5u5N/5JleQHgh/hrgMhSmSx2kn0nY6fxUMwisFn1JxUh+UyaUPniFbv69X PrqA== X-Gm-Message-State: AO0yUKU51tdbhQOTwo6EtAiaoLx1KbY7hHefhWR9a1hZgslqrISFhn0B o0d7x0ZPkcxpmaeiJPpqNlknaKZQgDk= X-Google-Smtp-Source: AK7set+UW3FIj1QDAlybv+SkiTNGjKmmyX5BE4JmaEMlc9+oIs1FI+LvO1CkBX1SkAhpjS34IA8/dA== X-Received: by 2002:a05:622a:178c:b0:3b9:b47f:4a94 with SMTP id s12-20020a05622a178c00b003b9b47f4a94mr10152442qtk.42.1675871208377; Wed, 08 Feb 2023 07:46:48 -0800 (PST) Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com. [209.85.128.178]) by smtp.gmail.com with ESMTPSA id i9-20020ac813c9000000b003b86d3ca969sm11531243qtj.51.2023.02.08.07.46.47 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Feb 2023 07:46:48 -0800 (PST) Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-5258f66721bso190421607b3.1 for ; Wed, 08 Feb 2023 07:46:47 -0800 (PST) X-Received: by 2002:a0d:d850:0:b0:527:af60:f524 with SMTP id a77-20020a0dd850000000b00527af60f524mr1030358ywe.251.1675871207741; Wed, 08 Feb 2023 07:46:47 -0800 (PST) MIME-Version: 1.0 References: <874jrxafok.fsf@localhost> <20230207174703.1960277-1-me@bcc32.com> <87cz6keadb.fsf@localhost> In-Reply-To: <87cz6keadb.fsf@localhost> From: Aaron Zeng Date: Wed, 8 Feb 2023 10:46:36 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] org--batch-store-agenda-views: Fix treatment of lambda functions To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Content-Type: multipart/alternative; boundary="00000000000006df2805f4322c41" Received-SPF: pass client-ip=209.85.160.180; envelope-from=zeng.aaron.l@gmail.com; helo=mail-qt1-f180.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675871245; a=rsa-sha256; cv=none; b=d1SXxv8Z1UfSbHLaYfjLFcvbuCEmbCDRGSBb4UvCGPyILu3O9rhTyRjqAdUYg1D1SypPGN MgU69Fo4gxKLrRkcslKkrd97CpuJLXi+PFdObul+sv+EYoEgyHUh6Ft3UingNUKNnaou+W 5DQJ0cCjFE/al5PZK9oVfwXKFSE7TA36necWEyqAskg+cZp9Ey3F4Y01wr5r7nsalpnXDW XE1xRR2HpOYR8WXWy7hpouXVTVdVTbes0F3GeqBJ5S1RjA1CDVHzk1+gUeWaAArVHNLBDh 5JXHA7kjsHHmIx5IBVKATGW5sPTuT30rzP9RKq8q/wRVjIxbWDwyshTsc8ZloA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675871245; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=JVmxMG9s0RmJlCdQVvgtfWq9Nl8xRNqWtR0qIREffBU=; b=tDIM+XAQDFagnGPRz2OY8XYL6NF7PS1ghbGKEp9rqdvOp+OFLeYgIzX31ytR2sq+r0VqUe Xr6n67Ie5hEW7Q4adwEKosotKVBafJ6i11K1LbpRwBPP8e3vYgbka3zPKFUm/fcW4wdva1 EJJlXA02vakrZmr3YXsb2sr+hGLs7wMgAHK57e2o+QA39mgPYBoPAW9VBcJLapH7MsrZVP TDAfeKHFqNXgBcS+aQKSxzuaQcUTRFo2NIwq7OKdmoRTQjHWbtajsBKpt6o2L75tPHcnrt 8P2NYOQ0Vmd2fjoXmWasSe2Gzouye0gd/IYyYVVJmwzM6jbtTLdQDqyI+F1ODg== X-Migadu-Queue-Id: 6CAB6F8AB X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Spam-Score: -3.40 X-Spam-Score: -3.40 X-TUID: vSRsnB6uMH1y --00000000000006df2805f4322c41 Content-Type: text/plain; charset="UTF-8" New patch looks good. Thanks! On Wed, Feb 8, 2023 at 05:09 Ihor Radchenko wrote: > "Aaron L. Zeng" writes: > > > * org-agenda.el (org--batch-store-agenda-views): Fix treatment of > > lambda functions used as custom agenda commands. > > `org-agenda-custom-commands' entries may specify a custom function > > instead of a symbol like `tags-todo'. `org--batch-store-agenda-views' > > behaved differently from `org-agenda' when that custom function was > > defined as a lambda rather than a symbol, incorrectly treating the > > lambda form as a list of agenda commands. Instead, use the same test > > as `org-agenda' does to determine whether the command is a series. > > Thanks for the updated patch! > I am attaching amended version with the comment placed closer to where > the custom command list is being used. > I also added TINYCHANGE cookie because you are not listed as a > contributor with FSF copyright assignment. > > Let me know if you have any objections. > > > > -- > Ihor Radchenko // yantar92, > Org mode contributor, > Learn more about Org mode at . > Support Org development at , > or support my work at > --00000000000006df2805f4322c41 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
New patch looks good.=C2=A0 Thanks!

On Wed, Feb 8, 20= 23 at 05:09 Ihor Radchenko <yanta= r92@posteo.net> wrote:
"= ;Aaron L. Zeng" <= me@bcc32.com> writes:

> * org-agenda.el (org--batch-store-agenda-views): Fix treatment of
> lambda functions used as custom agenda commands.
> `org-agenda-custom-commands' entries may specify a custom function=
> instead of a symbol like `tags-todo'.=C2=A0 `org--batch-store-agen= da-views'
> behaved differently from `org-agenda' when that custom function wa= s
> defined as a lambda rather than a symbol, incorrectly treating the
> lambda form as a list of agenda commands.=C2=A0 Instead, use the same = test
> as `org-agenda' does to determine whether the command is a series.=

Thanks for the updated patch!
I am attaching amended version with the comment placed closer to where
the custom command list is being used.
I also added TINYCHANGE cookie because you are not listed as a
contributor with FSF copyright assignment.

Let me know if you have any objections.



--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,=
or support my work at <https://liberapay.com/yantar92>
--00000000000006df2805f4322c41--