From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id sCpCH+QMj2LYrgAAbAwnHQ (envelope-from ) for ; Thu, 26 May 2022 07:15:16 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id MpgwHuQMj2ISFwEAG6o9tA (envelope-from ) for ; Thu, 26 May 2022 07:15:16 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2829125659 for ; Thu, 26 May 2022 07:15:16 +0200 (CEST) Received: from localhost ([::1]:54152 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nu5q6-0003km-Je for larch@yhetil.org; Thu, 26 May 2022 01:15:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41322) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nu5oH-0003jR-V8 for emacs-orgmode@gnu.org; Thu, 26 May 2022 01:13:21 -0400 Received: from mail-oa1-f47.google.com ([209.85.160.47]:38663) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nu5oG-0000Lz-BV for emacs-orgmode@gnu.org; Thu, 26 May 2022 01:13:21 -0400 Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-e5e433d66dso1018332fac.5 for ; Wed, 25 May 2022 22:13:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UaGSJEUnBDvshv+xXh+UXhAxumJXeaBNcyU2Y0SGYNE=; b=NvDDfUOFajtZz6vIxlDc6d9DxPFWTgrrpjVnsG+56G4bgSYrl6PDqeA8VyrnZgcsik urIKy7gHqHJnvFhh609sYFeHdDE8ttvzP0cERu+sLvITQzpua0OtkLQr11iGBQBzDmXH Fmf6j4ZU29FCSngeHzKKSDbV8ZjJ1eGyzE4m2CbZWwaM925zsl3DhPmEndS/PY41Qp8M D7rIXDMMD/XPXRYuvgMCpjtBqJyaePgpRD6IunKZwKcXw0E3dsnX4Wwp9/QDKFNlaIqN a8JfZBP3aZo1LOXXuXNxRGEdwp0u6B6gJm/3sKNZJMZu68+L1A8f6Ok5iw4dHimuAEUa EW7w== X-Gm-Message-State: AOAM530ItyFjnbBZHySpHGMUn/eoQPQ0HbeZSexcmz6bZkYlnFbnE+PA cDr346bE78QZwyvTKGxydbw5iHgIlCgdQw== X-Google-Smtp-Source: ABdhPJzTWW/+n5WUTNfHoqUwPiEiVT6qACUtyoX/UqNNMuoMOEcNSC3sUc8NiGE7w+pzOcByRo0llQ== X-Received: by 2002:a05:6871:797:b0:f1:d49b:2f3b with SMTP id o23-20020a056871079700b000f1d49b2f3bmr290223oap.40.1653541998290; Wed, 25 May 2022 22:13:18 -0700 (PDT) Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com. [209.85.167.182]) by smtp.gmail.com with ESMTPSA id 26-20020a4ae1ba000000b0035f068e16aasm297492ooy.5.2022.05.25.22.13.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 May 2022 22:13:17 -0700 (PDT) Received: by mail-oi1-f182.google.com with SMTP id e189so970533oia.8 for ; Wed, 25 May 2022 22:13:17 -0700 (PDT) X-Received: by 2002:a05:6808:1599:b0:32b:9af5:944c with SMTP id t25-20020a056808159900b0032b9af5944cmr241910oiw.83.1653541996906; Wed, 25 May 2022 22:13:16 -0700 (PDT) MIME-Version: 1.0 References: <20220522185120.2852682-1-me@bcc32.com> <87tu9c6hd1.fsf@localhost> In-Reply-To: <87tu9c6hd1.fsf@localhost> From: Aaron Zeng Date: Thu, 26 May 2022 01:12:40 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] org-todo-yesterday: Fix interactive arg when in agenda buffer To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Content-Type: multipart/alternative; boundary="00000000000058cee705dfe33f21" Received-SPF: pass client-ip=209.85.160.47; envelope-from=zeng.aaron.l@gmail.com; helo=mail-oa1-f47.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653542116; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=UaGSJEUnBDvshv+xXh+UXhAxumJXeaBNcyU2Y0SGYNE=; b=pxU4Up8wNyT2lvgusk3YvfAxog0ggKkD7z7oBDMnR3Bswi8hBJszRs7t0qJuHLgYKfNOD1 XQX9GKvHneKGUGfzjQRKLZJbvLU6lEbm25XHSTb3OgAvMYglnXHWm4y5jkMoVhVm136Vtw HLgUgFjKWSCqMDYz7O4OTdZ2DScpsn5u8tkGDce5XtVDOZAmLGyh0mv7IOPoGTw+vlInrP DQACJlgW10G9TGNq/3RoJJLK3kgSdwGw2fcRd4/CdCtG35NRvLxxK5MOYcufZ6oqDjEa+r KdAIN/7mP+ccasslQa4eaz9dGN4WKObIWOwKUV/OGSq39awoxFVOT+YD5WHwfg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653542116; a=rsa-sha256; cv=none; b=hM6i1HXLxDr2AdXD2BEr2484nyBvGBlqe0BL53b7t+XipmQAF0QvhxQZoLDRIOCXaFD38T wqCxy+h66SD0pFsg2mrvkqtl3x4It58ZSJ0i+Oq2zIV3Ttu9sePxmkI7X+2kQrn8ml9lnf 3naGoeZoKGuxaxVeh/FRwBs2eRFIgi3Ns67B46tbzkoLqLXv5PaSzZq0zOGJW9S8PIXMog ygLZ/b7b32mdPMrsXxNlA3anFatkE8ykEY8dO/Ih2yHkWGfLEGgZE4GO7VQ1xm6uK5/+vG yoMLFgkK+d1NyKBnb2rAXWeWeilj/5t9Lc6IUZT5xLDg80ZLh1GiOSlhcd5Puw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.34 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2829125659 X-Spam-Score: -3.34 X-Migadu-Scanner: scn0.migadu.com X-TUID: XYKllCi+j2lH --00000000000058cee705dfe33f21 Content-Type: text/plain; charset="UTF-8" Thanks Ihor! And, noted for the future. On Thu, May 26, 2022 at 12:34 AM Ihor Radchenko wrote: > "Aaron L. Zeng" writes: > > > (I'm resubmitting this patch because my previous submission was > in-reply-to > > another email which I suspect was ignored. Would love to get this > relatively > > simple bug fixed. Thanks!) > > > > * lisp/org.el (org-todo-yesterday): Fix an incorrect use of apply when > > org-todo-yesterday intends to call org-agenda-todo-yesterday with the > > same interactive arg. Before this change, the command incorrectly set > > the todo state of the task to blank when called with C-u C-u C-u in an > > agenda buffer (supposed to bypass any blocked checkboxes/subtasks). > > Thanks! Applied onto main via 713c15d85. > > I have made amendments to the commit message. Function/symbol names > should be quoted as `org-todo-yesterday'. > > Best, > Ihor > --00000000000058cee705dfe33f21 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks Ihor!=C2=A0 And, noted for the future.
On Thu, M= ay 26, 2022 at 12:34 AM Ihor Radchenko <yantar92@gmail.com> wrote:
"Aaron L. Zeng" <me@bcc32.com> writes:

> (I'm resubmitting this patch because my previous submission was in= -reply-to
> another email which I suspect was ignored.=C2=A0 Would love to get thi= s relatively
> simple bug fixed.=C2=A0 Thanks!)
>
> * lisp/org.el (org-todo-yesterday): Fix an incorrect use of apply when=
> org-todo-yesterday intends to call org-agenda-todo-yesterday with the<= br> > same interactive arg.=C2=A0 Before this change, the command incorrectl= y set
> the todo state of the task to blank when called with C-u C-u C-u in an=
> agenda buffer (supposed to bypass any blocked checkboxes/subtasks).
Thanks! Applied onto main via 713c15d85.

I have made amendments to the commit message. Function/symbol names
should be quoted as `org-todo-yesterday'.

Best,
Ihor
--00000000000058cee705dfe33f21--