From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4M9BCRgI0GPWLgEAbAwnHQ (envelope-from ) for ; Tue, 24 Jan 2023 17:32:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id sOduCBgI0GNrHwEAG6o9tA (envelope-from ) for ; Tue, 24 Jan 2023 17:32:24 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AF66B1DFBB for ; Tue, 24 Jan 2023 17:32:23 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKMCu-0005xN-Q0; Tue, 24 Jan 2023 11:31:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKMCq-0005ww-2L for emacs-orgmode@gnu.org; Tue, 24 Jan 2023 11:31:32 -0500 Received: from mail-qt1-f174.google.com ([209.85.160.174]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pKMCn-0006lz-S7 for emacs-orgmode@gnu.org; Tue, 24 Jan 2023 11:31:31 -0500 Received: by mail-qt1-f174.google.com with SMTP id h24so9567159qta.12 for ; Tue, 24 Jan 2023 08:31:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qAYQ3l+RmpCIzPXi6mwjT7MAniV+5LSHQ5ti/F1W/iA=; b=L14Ov83yDiBHENABS6kybxXR4uewE3M42/fzOAkDcjzmADgCI+1oOYb+fmuJdSilMJ lliL5uZYtis3LRXVBjKJ2Mufs3q0OkqjlE2W8UbZ4mYd2VxuuAbOUWDXaDyDviwhDRZw Xforrn0zSfIsTHI1DsGCutQ0k1bAwqi4n6CNpJbxJ0mBPuewc1Rw4XMcdY+5q6bXY4fh vQHk9LTU6PCK/2VhiwRtFR/iRZEVzdDWHw5CRIPWaq8WvplMRBw0Cfrvw/RJm6ugpymB bq10DcvFLS21n2mv3tvXGXSbzo1VOY0sXW1Z63umZCLFKr5uhHLQ+vnh6EM8j0Whv8Pz w9Qg== X-Gm-Message-State: AFqh2kri9cG2NIfov1chMzKITDIDc1cMBx1rB95eGQugNP2y7MhThHnK 2NfArx+BUPETmbLI7bGSH5BHjF1mkWs= X-Google-Smtp-Source: AMrXdXvef4HeCYobRgbg5FH8XF7quzGKPEHNlu4J3M7RjQWgr1VGOOOND3DZET4nHo4InAk+EY7+LQ== X-Received: by 2002:a05:622a:1b1e:b0:3ab:a047:58ee with SMTP id bb30-20020a05622a1b1e00b003aba04758eemr38848275qtb.25.1674577888543; Tue, 24 Jan 2023 08:31:28 -0800 (PST) Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com. [209.85.128.172]) by smtp.gmail.com with ESMTPSA id t8-20020ac87608000000b003b642c7c772sm1471424qtq.71.2023.01.24.08.31.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Jan 2023 08:31:28 -0800 (PST) Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-4fda31c3351so196971237b3.11 for ; Tue, 24 Jan 2023 08:31:28 -0800 (PST) X-Received: by 2002:a05:690c:18:b0:506:5603:d53 with SMTP id bc24-20020a05690c001800b0050656030d53mr219803ywb.482.1674577887845; Tue, 24 Jan 2023 08:31:27 -0800 (PST) MIME-Version: 1.0 References: <20230124025259.1301063-1-me@bcc32.com> <87358070bu.fsf@localhost> In-Reply-To: <87358070bu.fsf@localhost> From: Aaron Zeng Date: Tue, 24 Jan 2023 11:30:51 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] lisp/org-agenda.el: Fix void-function string-pad in Emacs <28.1 To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Content-Type: multipart/alternative; boundary="00000000000027663005f3050c1f" Received-SPF: pass client-ip=209.85.160.174; envelope-from=zeng.aaron.l@gmail.com; helo=mail-qt1-f174.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.149, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674577943; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=qAYQ3l+RmpCIzPXi6mwjT7MAniV+5LSHQ5ti/F1W/iA=; b=J5YRt2lBGCHYMTgt+m3pIee/nAoffLFsPDlSauRVhqHcINlKl3Ldh2+2g8H8yhE/dE+AmJ ++MwYq9Bq0HkNXkIw1SHGF2Rp4WZPlfZuqZzq12FKkqR21MsWfcp0D6RXLlEfD9AdimFY5 rpqqiY/P14GWIUhkfRWmMkGHS17hIj1VIPbhBReiWWs2j9HcGor85aKTKk6HLLxtuRMJNC afiVKQNAuy5I8qNqZ15nR8LMrUrRNYpANvTn7/gQXxL7Lfz9w5AAz8yivg55axvc/xRQlc SgvPFClQlBsEZ8u67YSLVyxKqeh3fR6UxV8wJYNJ1f5s0AVpCPJc8oHSmhY/tQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674577943; a=rsa-sha256; cv=none; b=eoSQn4s9Gu1n/oA8UyJI0xer1WE1mbVgsMKTu74NFyDnzHWKKR6O4PDX/7n0bg/ULgNiVF 91S7o+01rjEgtntNyhquYUJCi7/2m8KVXMOngIidMLyZ4xW4BdEmp/whKh88ItHdpMH6SE ksdiTor0VkwJafej1+MFve+KYeUhLm5gauaMJY37/0SswZqa2eQl4ZyHLaIkXhGeMVpTi9 0/zeNWKM1HbYeV7HpRZ8atYyml2J3FCdfseEBerTiwQHL9IN9iif8Kg+v+6ApL8zRZW2Fp 1zGPdAi8XSly2dTK10szhvnn7dqoivihPwhcjYa7W9nev+0dFFmYsVV/ifVtJw== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Spam-Score: -1.38 X-Spam-Score: -1.38 X-Migadu-Queue-Id: AF66B1DFBB X-TUID: zqFcAas89Oys --00000000000027663005f3050c1f Content-Type: text/plain; charset="UTF-8" Thanks for the quick response, Ihor! On Tue, Jan 24, 2023 at 4:23 AM Ihor Radchenko wrote: > "Aaron L. Zeng" writes: > > > * org-compat.el (org-string-pad): Add compatibility function > > `org-string-pad' for `string-pad', introduced in Emacs 28.1. > > > > * org-agenda.el (org-fix-agenda-info): Use `org-string-pad' rather > > than `string-pad'. > > > > Since this is more-or-less just copying string-pad's definition from > > subr-x.el, I think this qualifies for TINYCHANGE. > > Thanks! > This issue has not been caught by byte-compilation. > > I applied an alternative fix not using `string-pad' at all. > Canceled. > > > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=5bbb97f3df9788646b8d48d60e8b8ea06566e05f > > -- > Ihor Radchenko // yantar92, > Org mode contributor, > Learn more about Org mode at . > Support Org development at , > or support my work at > --00000000000027663005f3050c1f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks for the quick response, Ihor!

On Tue, Jan 24, 20= 23 at 4:23 AM Ihor Radchenko <yan= tar92@posteo.net> wrote:
"Aaron L. Zeng" <me@bcc32.com> writes:

> * org-compat.el (org-string-pad): Add compatibility function
> `org-string-pad' for `string-pad', introduced in Emacs 28.1. >
> * org-agenda.el (org-fix-agenda-info): Use `org-string-pad' rather=
> than `string-pad'.
>
> Since this is more-or-less just copying string-pad's definition fr= om
> subr-x.el, I think this qualifies for TINYCHANGE.

Thanks!
This issue has not been caught by byte-compilation.

I applied an alternative fix not using `string-pad' at all.
Canceled.

https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3D5b= bb97f3df9788646b8d48d60e8b8ea06566e05f

--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,=
or support my work at <https://liberapay.com/yantar92>
--00000000000027663005f3050c1f--