emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Patch for fixing a missing autoload for the function org-clock-sum-today
@ 2018-02-01 23:07 Jose Robins
  2018-02-04 22:37 ` Nicolas Goaziou
  0 siblings, 1 reply; 3+ messages in thread
From: Jose Robins @ 2018-02-01 23:07 UTC (permalink / raw)
  To: emacs-orgmode


[-- Attachment #1.1: Type: text/plain, Size: 282 bytes --]

    org-clock.el: Add an autoload entry for the function org-clock-sum-today

    * lisp/org-clock.el: When the org-mode is called for the very first time
    any functionality that requires the org-clock-sum-today used to fail.
    (e.g. a column that calculates CLOCKSUM_T)

Jose

[-- Attachment #1.2: Type: text/html, Size: 394 bytes --]

[-- Attachment #2: 0001-org-clock.el-Add-an-autoload-entry-for-the-function-.patch --]
[-- Type: application/octet-stream, Size: 1033 bytes --]

From 12f4dd3d01b5521f5e35d855ae5f12600104d509 Mon Sep 17 00:00:00 2001
From: Jose Robins <jose.robins@gmail.com>
Date: Thu, 1 Feb 2018 15:02:10 -0800
Subject: [PATCH] org-clock.el: Add an autoload entry for the function
 org-clock-sum-today

* lisp/org-clock.el: When the org-mode is called for the very first time
any functionality that requires the org-clock-sum-today used to fail.
(e.g. a column that calculates CLOCKSUM_T)
---
 lisp/org-clock.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index aa59d821e..8b5e8b1aa 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -1755,6 +1755,7 @@ With prefix arg SELECT, offer recently clocked tasks for selection."
 (defvar-local org-clock-file-total-minutes nil
   "Holds the file total time in minutes, after a call to `org-clock-sum'.")
 
+;;;###autoload
 (defun org-clock-sum-today (&optional headline-filter)
   "Sum the times for each subtree for today."
   (let ((range (org-clock-special-range 'today)))
-- 
2.14.2.windows.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: Patch for fixing a missing autoload for the function org-clock-sum-today
  2018-02-01 23:07 Patch for fixing a missing autoload for the function org-clock-sum-today Jose Robins
@ 2018-02-04 22:37 ` Nicolas Goaziou
  2018-02-05 16:56   ` Jose Robins
  0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Goaziou @ 2018-02-04 22:37 UTC (permalink / raw)
  To: Jose Robins; +Cc: emacs-orgmode

Hello,

Jose Robins <jose.robins@gmail.com> writes:

>     org-clock.el: Add an autoload entry for the function org-clock-sum-today
>
>     * lisp/org-clock.el: When the org-mode is called for the very first time
>     any functionality that requires the org-clock-sum-today used to fail.
>     (e.g. a column that calculates CLOCKSUM_T)

Applied, thank you.

I added a TINYCHANGE cookie at the end of the commit message since
I don't if you have signed FSF papers.

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Patch for fixing a missing autoload for the function org-clock-sum-today
  2018-02-04 22:37 ` Nicolas Goaziou
@ 2018-02-05 16:56   ` Jose Robins
  0 siblings, 0 replies; 3+ messages in thread
From: Jose Robins @ 2018-02-05 16:56 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 729 bytes --]

Thank you, Nicolas. I have not signed FSF. But I will do so for any bigger
patches that I submit.

Regards,
Jose

On Sun, Feb 4, 2018 at 2:37 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:

> Hello,
>
> Jose Robins <jose.robins@gmail.com> writes:
>
> >     org-clock.el: Add an autoload entry for the function
> org-clock-sum-today
> >
> >     * lisp/org-clock.el: When the org-mode is called for the very first
> time
> >     any functionality that requires the org-clock-sum-today used to fail.
> >     (e.g. a column that calculates CLOCKSUM_T)
>
> Applied, thank you.
>
> I added a TINYCHANGE cookie at the end of the commit message since
> I don't if you have signed FSF papers.
>
> Regards,
>
> --
> Nicolas Goaziou
>

[-- Attachment #2: Type: text/html, Size: 1276 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-02-05 16:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-01 23:07 Patch for fixing a missing autoload for the function org-clock-sum-today Jose Robins
2018-02-04 22:37 ` Nicolas Goaziou
2018-02-05 16:56   ` Jose Robins

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).