emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: E Sabof <esabof@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>, emacs-orgmode@gnu.org
Cc: 14346@debbugs.gnu.org
Subject: Re: bug#14346: 24.3; beginning-of-visual-line jumps to previous line in org-mode
Date: Tue, 7 May 2013 02:34:40 +0100	[thread overview]
Message-ID: <CAEp6DyaDWtuw96Hm73BA-WOdiez8O7ud0stCQSycaLS5KXkZ0A@mail.gmail.com> (raw)
In-Reply-To: <CAEp6DyaP8N21FCxSX6tos1Cco9kCoQhK05BJM49V4qz6A406JA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1604 bytes --]

Even if the behavior doesn't change (soon), could the equivalent of the
following be implemented in org-mode? It's the only place where this has
been problematic for me.

(defadvice org-beginning-of-line (after smart-point-adjustment activate)
  (setq disable-point-adjustment
        (or (not (invisible-p (point)))
            (not (invisible-p (max (point-min) (1- (point))))))))

(defadvice org-end-of-line (after smart-point-adjustment activate)
  (setq disable-point-adjustment
        (or (not (invisible-p (point)))
            (not (invisible-p (max (point-min) (1- (point))))))))

Evgeni


On Sat, May 4, 2013 at 2:27 PM, E Sabof <esabof@gmail.com> wrote:

> Wouldn't it be better if forward/backward-char kept the old behavior, and
> the rest of the commands did something similar to this in the end:
>
> (setq disable-point-adjustment
>       (preceding-or-following-character-visible-p))
>
> I'm not entirely sure whether it would be better, but at the moment, I
> can't think of a case where it wouldn't.
>
> Evgeni
>
>
> On Sat, May 4, 2013 at 1:16 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> > Date: Sat, 4 May 2013 12:17:35 +0100
>> > From: E Sabof <esabof@gmail.com>
>> > Cc: 14346@debbugs.gnu.org
>> >
>> > I see what you mean. But it still looks like a bug - whether I follow
>> the
>> > above recipe, or press C-e C-a, the point will (should?) go to the same
>> > position, but the behavior is different.
>>
>> The behavior depends on the direction point was moving before ending
>> up in the invisible text.  It's a heuristic, and as every heuristic,
>> it sometimes fails.
>>
>
>

[-- Attachment #2: Type: text/html, Size: 2667 bytes --]

       reply	other threads:[~2013-05-07  1:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAEp6DyajAEW63CFd8U6qLQM6kkayGOaxtvA0OFRKMuBYSLQw1g@mail.gmail.com>
     [not found] ` <8338u3m2ke.fsf@gnu.org>
     [not found]   ` <831u9nm2dm.fsf@gnu.org>
     [not found]     ` <CAEp6Dybi3z-wAN6gYBSDREsWsdzdhk8iEwRD+H1t4FWqdms_WA@mail.gmail.com>
     [not found]       ` <83y5bvkki7.fsf@gnu.org>
     [not found]         ` <CAEp6DyaP8N21FCxSX6tos1Cco9kCoQhK05BJM49V4qz6A406JA@mail.gmail.com>
2013-05-07  1:34           ` E Sabof [this message]
2013-05-10  7:00             ` bug#14346: [O] bug#14346: 24.3; beginning-of-visual-line jumps to previous line in org-mode Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEp6DyaDWtuw96Hm73BA-WOdiez8O7ud0stCQSycaLS5KXkZ0A@mail.gmail.com \
    --to=esabof@gmail.com \
    --cc=14346@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).