[patch] Don't show trailing colon in agenda custom command desc

[patch] Don't show trailing colon in agenda custom command desc

[Carlos Pita]

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

Hi all,

here is a simple patch to avoid showing ugly trailing colons in custom
agenda commands when no matcher was specified (for example, in the
case of alltodo).

Best regards
--
Carlos

[-- Attachment #2: 0001-org-agenda-don-t-show-trailing-color-if-no-matcher.patch --]
[-- Type: text/x-patch, Size: 966 bytes --]

From 4125d3ff9e4f26c3346b847288cad3e69a38da23 Mon Sep 17 00:00:00 2001
From: memeplex <carlosjosepita@gmail.com>
Date: Fri, 22 Feb 2019 00:32:58 -0300
Subject: [PATCH] org-agenda: don't show trailing color if no matcher

* lisp/org-agenda.el (org-agenda-get-restriction-and-command):
  when no matcher was specified there is no point in showing
  a trailing colon (and space).
---
 lisp/org-agenda.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index ff98cd65d..ab50d4274 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -3027,7 +3027,8 @@ s   Search for keywords                 M   Like m, but only TODO entries
 					    (symbol-name type)
 					  "Lambda expression"))
 		      (t "???"))))
-	      (if org-agenda-menu-show-matcher
+	      (if (and org-agenda-menu-show-matcher
+		       match (not (string-empty-p match)))
 		  (setq line
 			(concat line ": "
 				(cond
-- 
2.20.1

Re: [patch] Don't show trailing colon in agenda custom command desc

[Nicolas Goaziou]

Hello,

Carlos Pita <carlosjosepita@gmail.com> writes:

> here is a simple patch to avoid showing ugly trailing colons in custom
> agenda commands when no matcher was specified (for example, in the
> case of alltodo).
>
> Best regards
> --
> Carlos
>
> From 4125d3ff9e4f26c3346b847288cad3e69a38da23 Mon Sep 17 00:00:00 2001
> From: memeplex <carlosjosepita@gmail.com>
> Date: Fri, 22 Feb 2019 00:32:58 -0300
> Subject: [PATCH] org-agenda: don't show trailing color if no matcher
>
> * lisp/org-agenda.el (org-agenda-get-restriction-and-command):
>   when no matcher was specified there is no point in showing
>   a trailing colon (and space).

Applied, with some refactoring. Please double check I didn't fumble it.

Thank you.

Regards,

-- 
Nicolas Goaziou

Re: [patch] Don't show trailing colon in agenda custom command desc

[Carlos Pita]

> Applied, with some refactoring. Please double check I didn't fumble it.

I looked at the code and tested it a bit and seems to be ok. Thanks!