[PATCH] Avoid extra space when removing state

[PATCH] Avoid extra space when removing state

[Carlos Pita]

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

Hi all,

here is a patch removing an extra space that is left when one selects
an empty state from the completing read interface. I simply replaced a
check for non-null with a check for org-string-nw-p in org-todo.

Best regards
--
Carlos

[-- Attachment #2: 0001-Avoid-extra-space-when-removing-state.patch --]
[-- Type: text/x-patch, Size: 953 bytes --]

From 9f137a50e1f18e067b4b9ca8836993b212d93093 Mon Sep 17 00:00:00 2001
From: memeplex <carlosjosepita@gmail.com>
Date: Fri, 8 Mar 2019 23:12:16 -0300
Subject: [PATCH] Avoid extra space when removing state

* lisp/org.el (org-todo): check if org-string-nw-p instead of non nil.
---
 lisp/org.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org.el b/lisp/org.el
index 668482932..655c5733b 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -12082,7 +12082,7 @@ When called through ELisp, arg is also interpreted in the following way:
 			     (run-hook-with-args-until-success
 			      'org-todo-get-default-hook org-state org-last-state)
 			     org-state))
-		 (next (if org-state (concat " " org-state " ") " "))
+		 (next (if (org-string-nw-p org-state) (concat " " org-state " ") " "))
 		 (change-plist (list :type 'todo-state-change :from this :to org-state
 				     :position startpos))
 		 dolog now-done-p)
-- 
2.21.0

Re: [PATCH] Avoid extra space when removing state

[Nicolas Goaziou]

Hello,

Carlos Pita <carlosjosepita@gmail.com> writes:

> here is a patch removing an extra space that is left when one selects
> an empty state from the completing read interface. I simply replaced a
> check for non-null with a check for org-string-nw-p in org-todo.

Applied. Thank you.

Regards,

-- 
Nicolas Goaziou