emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Org is using obsolete function `lisp-complete-symbol`
@ 2025-01-20 17:44 Stefan Kangas
  0 siblings, 0 replies; only message in thread
From: Stefan Kangas @ 2025-01-20 17:44 UTC (permalink / raw)
  To: Org-mode

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

Org mode is still using the obsolete function `lisp-complete-symbol`,
but that function has been obsoleted in favor of `completion-at-point`
in version 24.4.  The attached diff is not meant to be installed, but to
show where the problem is.

The usual schedule for removing obsolete functions in Emacs would
suggest that `lisp-complete-symbol` will be removed in Emacs 31.1, but
we can't do that if Org mode is still using it.

Could you please look into this?

[-- Attachment #2: lisp-complete-symbol.diff --]
[-- Type: text/x-patch, Size: 1551 bytes --]

diff --git a/lisp/org-table.el b/lisp/org-table.el
index 21fadd787..080429883 100644
--- a/lisp/org-table.el
+++ b/lisp/org-table.el
@@ -3326,8 +3326,8 @@ Parameters get priority."
     (org-defkey map [(shift right)] 'org-table-fedit-ref-right)
     (org-defkey map [(meta up)]     'org-table-fedit-scroll-down)
     (org-defkey map [(meta down)]   'org-table-fedit-scroll)
-    (org-defkey map [(meta tab)]    'lisp-complete-symbol)
-    (org-defkey map "\M-\C-i"       'lisp-complete-symbol)
+    (org-defkey map [(meta tab)]    'completion-at-point)
+    (org-defkey map "\M-\C-i"       'completion-at-point)
     (org-defkey map [(tab)]	    'org-table-fedit-lisp-indent)
     (org-defkey map "\C-i"	    'org-table-fedit-lisp-indent)
     (org-defkey map "\C-c\C-r" 'org-table-fedit-toggle-ref-type)
@@ -3341,7 +3341,7 @@ Parameters get priority."
     ["Abort" org-table-fedit-abort t]
     "--"
     ["Pretty-Print Lisp Formula" org-table-fedit-lisp-indent t]
-    ["Complete Lisp Symbol" lisp-complete-symbol t]
+    ["Complete Lisp Symbol" completion-at-point t]
     "--"
     "Shift Reference at Point"
     ["Up" org-table-fedit-ref-up t]
@@ -3430,7 +3430,7 @@ Edit formulas, finish with `\\[org-ctrl-c-ctrl-c]' or `\\[org-edit-special]'.  \
 See menu for more commands.")))))
 
 (defun org-table-fedit-post-command ()
-  (when (not (memq this-command '(lisp-complete-symbol)))
+  (when (not (memq this-command '(completion-at-point)))
     (let ((win (selected-window)))
       (save-excursion
 	(ignore-errors (org-table-show-reference))

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2025-01-20 17:46 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-20 17:44 Org is using obsolete function `lisp-complete-symbol` Stefan Kangas

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).