From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Bug: org-sort-entries does not preserve folded drawers [9.1.13 (9.1.13-dist @ /home/yantar92/.emacs.d/straight/build/org/)] Date: Sat, 10 Aug 2019 08:00:48 +0200 Message-ID: References: <87tvaydb4y.fsf@yantar92-laptop.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000224655058fbd0480" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:44058) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hwKRA-0000z9-MQ for emacs-orgmode@gnu.org; Sat, 10 Aug 2019 02:01:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hwKR8-00071f-By for emacs-orgmode@gnu.org; Sat, 10 Aug 2019 02:01:08 -0400 Received: from mail-ed1-f53.google.com ([209.85.208.53]:39698) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hwKR7-00071F-PD for emacs-orgmode@gnu.org; Sat, 10 Aug 2019 02:01:06 -0400 Received: by mail-ed1-f53.google.com with SMTP id e16so4309023edv.6 for ; Fri, 09 Aug 2019 23:01:05 -0700 (PDT) In-Reply-To: <87tvaydb4y.fsf@yantar92-laptop.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Ihor Radchenko Cc: org-mode list --000000000000224655058fbd0480 Content-Type: text/plain; charset="UTF-8" Hi Ihor, thank you for the report. It would be too much work to *preserve* the visibility state of everything in the sorting area, but you are right, the drawers at lease should be closed. I fixed this, the fix is in master. Carsten On Sat, Aug 3, 2019 at 8:22 AM Ihor Radchenko wrote: > > org-sort-entries seems to unfold everything in the subtree even if no > modification was done to the buffer during sorting. > > Steps to reproduce: > > Consider the following org file: > #+begin_src org > ,* a > :PROPERTIES: > :ID: 279e797c-f4a7-47bb-80f6-e72ac6f3ec55 > :END: > :DRAWER: > Blah > :END: > > ,** test > #+end_src > > 1. emacs -Q > 2. Fold all the drawers and entries in the buffer > 3a. Call M-x org-sort-entries p > 3b. Call M-: (org-sort-entries nil ?p) RET > > > Expected behaviour for 3a: Subtree is unfolded, all the property drawers > are folded, buffer is unchanged > Observed behaviour for 3a: Subtree is unfolded, all the property drawers > are also unfolded, buffer is marked modified > > Expected behaviour for 3b: Subtree is folded, all the property drawers > are folded, buffer is unchanged > Observed behaviour for 3b: Subtree is unfolded, all the property drawers > are also unfolded, buffer is marked modified > > Regards, > Ihor > > > > > Emacs : GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit) > of 2019-04-29 > Package: Org mode version 9.1.13 (9.1.13-dist @ > /home/yantar92/.emacs.d/straight/build/org/) > -- > Ihor Radchenko, > PhD, > Center for Advancing Materials Performance from the Nanoscale (CAMP-nano) > State Key Laboratory for Mechanical Behavior of Materials, Xi'an Jiaotong > University, Xi'an, China > Email: yantar92@gmail.com, ihor_radchenko@alumni.sutd.edu.sg > > > --000000000000224655058fbd0480 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Ihor,

thank you for the report.
It would be too much work to *preserve* the visibility state of every= thing in the sorting area, but you are right, the drawers at lease should b= e closed.=C2=A0 I fixed this, the fix is in master.

Carsten

On Sat, Aug 3, 2019 at 8:22 AM Ihor Radchenko <yantar92@gmail.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">
org-sort-entries seems to unfold everything in the subtree even if no
modification was done to the buffer during sorting.

Steps to reproduce:

Consider the following org file:
#+begin_src org
,* a
:PROPERTIES:
:ID:=C2=A0 =C2=A0 =C2=A0 =C2=A0279e797c-f4a7-47bb-80f6-e72ac6f3ec55
:END:
:DRAWER:
Blah
:END:

,** test
#+end_src

1. emacs -Q
2. Fold all the drawers and entries in the buffer
3a. Call M-x org-sort-entries p
3b. Call M-: (org-sort-entries nil ?p) RET


Expected behaviour for 3a: Subtree is unfolded, all the property drawers are folded, buffer is unchanged
Observed behaviour for 3a: Subtree is unfolded, all the property drawers are also unfolded, buffer is marked modified

Expected behaviour for 3b: Subtree is folded, all the property drawers
are folded, buffer is unchanged
Observed behaviour for 3b: Subtree is unfolded, all the property drawers are also unfolded, buffer is marked modified

Regards,
Ihor




Emacs=C2=A0 : GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit) =C2=A0of 2019-04-29
Package: Org mode version 9.1.13 (9.1.13-dist @ /home/yantar92/.emacs.d/str= aight/build/org/)
--
Ihor Radchenko,
PhD,
Center for Advancing Materials Performance from the Nanoscale (CAMP-nano) State Key Laboratory for Mechanical Behavior of Materials, Xi'an Jiaoto= ng University, Xi'an, China
Email: yantar92@gma= il.com, ihor_radchenko@alumni.sutd.edu.sg


--000000000000224655058fbd0480--