From: Carsten Dominik <dominik@uva.nl>
To: "Héctor Enríquez Ramón" <hector.e.r@gmail.com>
Cc: org-mode list <emacs-orgmode@gnu.org>
Subject: Re: Bug: Org agenda category max length raise error [9.2.5 (9.2.5-1-gff6508-elpaplus @ /home/edo/.emacs.d/elpa/org-plus-contrib-20190805/)]
Date: Mon, 12 Aug 2019 12:36:47 +0200 [thread overview]
Message-ID: <CADn3Z2LZHWyge8EQY2S_ObM8m+JWLpjM0wzXjx4GBBs7SZiRaQ@mail.gmail.com> (raw)
In-Reply-To: <CAFeiWLaniUXFBMGORg0CgHCA6y4AYqCW=P3qaL9we9fGXkD8Yw@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 2040 bytes --]
Hi Hector,
you fix does not work, because it changes the match data, which is still
needed further down. Could you please try the attached patch and report
back?
Thank you
Carsten
On Sun, Aug 11, 2019 at 4:50 PM Héctor Enríquez Ramón <hector.e.r@gmail.com>
wrote:
> --text follows this line--
>
> Hi.
>
>
> * Issue:
>
> 1. Use max length format %<number>.<max>, example
>
> (setq org-agenda-prefix-format
> '((agenda . " %i %-4.4 c%?-12t% s") ;; (agenda . " %i %-12:c%?-12t%
> s")
> (timeline . " % s")
> (todo . " %i %-4.4 c%?-12t% s") ;; (todo . " %i %-12:c")
> (tags . " %i %-4.4 c") ;; (tags . " %i %-12:c")
> (search . " %i %-4.4 c")) ;; (search . " %i %-12:c"))
>
> 2. Open an org file.
>
> 3. Typing C-c a a (for example) raise:
>
> org-compile-prefix-format: Args out of range: "-4.4", 4, 11
>
>
> * How to fix it:
>
> org-agenda.el: (see comments ;; + line added, ;; - line removed)
>
> (when (eq var 'category)
> (setq org-prefix-category-length
> (floor (abs (string-to-number (match-string 2 s)))))
> (setq org-prefix-category-max-length
> (let ((x (match-string 2 s)))
> (save-match-data
> ;; +
> (when (string-match "\\.[0-9]+" x)
> (string-to-number (substring (match-string 0 x)
> 1))))))) ;; +
> ;; (when (string-match-p "\\.[0-9]+" x)
> ;; -
> ;; (string-to-number (substring (match-string 0 x)
> 1)))))) ;; -
> (if (eq var 'eval)
> (setq varform `(format ,f (org-eval ,(read (match-string 4
> s)))))
>
>
>
> Best regards. Hector
>
> Emacs : GNU Emacs 26.2 (build 1, x86_64-pc-linux-gnu, X toolkit, Xaw
> scroll bars)
> of 2019-04-13
> Package: Org mode version 9.2.5 (9.2.5-1-gff6508-elpaplus @
> /home/edo/.emacs.d/elpa/org-plus-contrib-20190805/)
>
[-- Attachment #1.2: Type: text/html, Size: 2865 bytes --]
[-- Attachment #2: patch --]
[-- Type: application/octet-stream, Size: 688 bytes --]
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index f1a99bc0d..dbe5042b6 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -6739,8 +6739,9 @@ and stored in the variable `org-prefix-format-compiled'."
(floor (abs (string-to-number (match-string 2 s)))))
(setq org-prefix-category-max-length
(let ((x (match-string 2 s)))
- (when (string-match-p "\\.[0-9]+" x)
- (string-to-number (substring (match-string 0 x) 1))))))
+ (save-match-data
+ (and (string-match "\\.[0-9]+" x)
+ (string-to-number (substring (match-string 0 x) 1)))))))
(if (eq var 'eval)
(setq varform `(format ,f (org-eval ,(read (match-string 4 s)))))
(if opt
next prev parent reply other threads:[~2019-08-12 10:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-11 14:49 Bug: Org agenda category max length raise error [9.2.5 (9.2.5-1-gff6508-elpaplus @ /home/edo/.emacs.d/elpa/org-plus-contrib-20190805/)] Héctor Enríquez Ramón
2019-08-12 10:36 ` Carsten Dominik [this message]
2019-08-12 11:55 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADn3Z2LZHWyge8EQY2S_ObM8m+JWLpjM0wzXjx4GBBs7SZiRaQ@mail.gmail.com \
--to=dominik@uva.nl \
--cc=emacs-orgmode@gnu.org \
--cc=hector.e.r@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).