From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frederick Giasson Subject: Re: org-detangle seems broken Date: Tue, 5 Jun 2018 08:18:34 -0400 Message-ID: References: <87wovhmr0v.fsf@nicolasgoaziou.fr> <87o9gp7dwb.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000009e9535056de40c08" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQAv7-00072h-4V for emacs-orgmode@gnu.org; Tue, 05 Jun 2018 08:18:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQAv6-0007g3-2L for emacs-orgmode@gnu.org; Tue, 05 Jun 2018 08:18:37 -0400 Received: from mail-qt0-x229.google.com ([2607:f8b0:400d:c0d::229]:37437) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fQAv5-0007fl-QS for emacs-orgmode@gnu.org; Tue, 05 Jun 2018 08:18:35 -0400 Received: by mail-qt0-x229.google.com with SMTP id q13-v6so2093154qtp.4 for ; Tue, 05 Jun 2018 05:18:35 -0700 (PDT) In-Reply-To: <87o9gp7dwb.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: emacs-orgmode@gnu.org --0000000000009e9535056de40c08 Content-Type: text/plain; charset="UTF-8" Hi Nicolas, > Here it is. If you =detangle= the =broken-detangle--working.el= file, it > > will work as expected. > > > > However, if you try to detangle the =broken-detangle--NOT-working.el= > file, > > you should get a "Not in a source block" error in *message*. > > This is fixed in "master". > That is great! Working perfectly no, thanks! > > Another thing I noted while creating the ECM is if there is only *one* > code > > block in the =.org= file, then it throws a =End of Buffer= error. > > I couldn't reproduce this. If the fix below doesn't solve it, could you > provide a dedicated ECM? > Yes, that fixed it as well. There is one last thing related to =org-babel-detangle= that seems "broken" is that as far as I can see, the top =save-excursion= should save the position of the cursor of the source file and keep the buffer at that position when we perform a detangling on it, no? Right now, the behavior is that when we do a detangle from a source file, the org file get opened in the buffer of the source file. However, I think that the right behavior is that when we detangle that the remain at the same position in the source file otherwise this gets confusing in my opinion. Is that a bug or the expected behavior? Thanks! Take care Fred --0000000000009e9535056de40c08 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Nicolas,

> Here it is. If you =3Ddetangle=3D the =3Dbroken-detangle--working.el= =3D file, it
> will work as expected.
>
> However, if you try to detangle the =3Dbroken-detangle--NOT-working.el=3D file,
> you should get a "Not in a source block" error in *message*.=

This is fixed in "master".

Th= at is great! Working perfectly no, thanks!

=C2=A0<= /div>
> Another thing I noted while creating the ECM is if there is only *one*= code
> block in the =3D.org=3D file, then it throws a =3DEnd of Buffer=3D err= or.

I couldn't reproduce this. If the fix below doesn't solve it, could= you
provide a dedicated ECM?

Yes, that fixe= d it as well.



There is one las= t thing related to =3Dorg-babel-detangle=3D that seems "broken" i= s that as far as I can see, the top =3Dsave-excursion=3D should save the po= sition of the cursor of the source file and keep the buffer at that positio= n when we perform a detangling on it, no?
<= br>
Right now, the behavior is that when we= do a detangle from a source file, the org file get opened in the buffer of= the source file.

However, I think that the right behavior is that when we detang= le that the remain at the same position in the source file otherwise this g= ets confusing in my opinion.

Is that a bug or the expected behavior?

Thanks!

Take care
<= div class=3D"gmail_extra">
Fred
--0000000000009e9535056de40c08--