From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylvain Chouleur Subject: Re: [PATCH] Fix org-outline-overlay-data marker insertion-type Date: Sat, 18 Jan 2014 19:35:38 +0100 Message-ID: References: <87ha91uqw5.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11c137e4072dad04f042eee3 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43744) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W4akT-0001qo-DA for emacs-orgmode@gnu.org; Sat, 18 Jan 2014 13:36:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W4akR-0000ho-CE for emacs-orgmode@gnu.org; Sat, 18 Jan 2014 13:36:01 -0500 Received: from mail-qc0-x230.google.com ([2607:f8b0:400d:c01::230]:55329) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W4akR-0000h2-7J for emacs-orgmode@gnu.org; Sat, 18 Jan 2014 13:35:59 -0500 Received: by mail-qc0-f176.google.com with SMTP id e16so4794043qcx.35 for ; Sat, 18 Jan 2014 10:35:58 -0800 (PST) In-Reply-To: <87ha91uqw5.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: emacs-orgmode@gnu.org --001a11c137e4072dad04f042eee3 Content-Type: text/plain; charset=ISO-8859-1 But beg and end are positions, not markers, I am wrong? 2014/1/18 Nicolas Goaziou > Hello, > > Sylvain Chouleur writes: > > > A little fix on my last patch: > > Thanks for your patch. A small style comment. > > > + (let ((bound > > + (cons (move-marker (make-marker) > beg) > > + (move-marker (make-marker) > end)))) > > + (set-marker-insertion-type (car > bound) t) > > + (set-marker-insertion-type (cdr > bound) t) > > + bound) > > All of this is really a one-liner: > > (cons (copy-marker beg t) (copy-marker end t)) > > > Regards, > > -- > Nicolas Goaziou > --001a11c137e4072dad04f042eee3 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
But beg and end are positions, not markers, I am wrong?


2014/1/18 = Nicolas Goaziou <n.goaziou@gmail.com>
Hello,

Sylvain Chouleur <sylvain.= chouleur@gmail.com> writes:

> A little fix on my last patch:

Thanks for your patch. A small style comment.

> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(let = ((bound
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 (cons (move-marker (make-marker) beg)
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 (move-marker (make-marker) end))))
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(= set-marker-insertion-type (car bound) t)
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(= set-marker-insertion-type (cdr bound) t)
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0b= ound)

All of this is really a one-liner:

=A0 (cons (copy-marker beg t) (copy-marker end t))


Regards,

--
Nicolas Goaziou

--001a11c137e4072dad04f042eee3--