From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:1008:1e59::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id CM0/OyWinmUYLwAAkFu2QA (envelope-from ) for ; Wed, 10 Jan 2024 14:56:54 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id yKqcNiWinmU8dwEA62LTzQ (envelope-from ) for ; Wed, 10 Jan 2024 14:56:53 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=positron.solutions header.s=google header.b=kMv2tbP4; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1704895013; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=uAAVEtKBcLJjweRiPBwjHQaUls199/m1nl9W5DCpBHU=; b=V79uY7LwVZzRbvUC1W4xAQ+uA3jN0nRh7tsVNZSGruHcHUMSRn+GV0R+Yi52rYLey4UmKt eG07ixkUQ+5VV/POQUQ9lktGvt8yfbLjkXoZD5lIdTRKz4RYXBBk9AKw6IkW8H2pd39Rn9 Ge3VwMDzTJLTV0D8kidl1CN+YdYuaCZmu7CMCTehNTYuNlsux8dGLEoToc+uNl9pLXtALV g5R1Vv8mZwT3uavJGQBWIaaWkEVASDl5m6sfXS8xqz4dBxcb38wNI/b+fQJttfhmdm5HP4 lsf1ZZ9dKhfefhjzxJcKsLbTSukUfjzq8T7+K8RNK452RBXHLak155SWqFqFQA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1704895013; a=rsa-sha256; cv=none; b=oNu1s44Jpdzz2WyNOfL2Tx4G+YHfgg2dwvPtnBeEcQin+b0YkjEjGBNbV0iYyBeBMmW50q i1d/C5jYs1iX+khs6MdX+zKiTCNRww+W7GIlE7zhjQR99e/IPwsbilphM54jVgxjyjloJc UVUmsOQQDHB1rQIc0I/5eidvq866FGFIcPigegzciZJRcXPou42fEBnS7qiDpZkjAymYge d/8KxY+d5YhS1pd5jUB9IW/SWMCyVcAH3aUwRqqj2/4PqDDrIoGth7dZyM2bn/4BcihLg1 ifisHj+XrL/QsIAd2bA2dwV+w8EmBfU+fxVmnj5+cU9IcU21x2LiKjav8eUINw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=positron.solutions header.s=google header.b=kMv2tbP4; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2B294AE43 for ; Wed, 10 Jan 2024 14:56:53 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNZ40-0002vH-9t; Wed, 10 Jan 2024 08:56:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNZ3w-0002rM-OK for emacs-orgmode@gnu.org; Wed, 10 Jan 2024 08:56:08 -0500 Received: from mail-yw1-x1135.google.com ([2607:f8b0:4864:20::1135]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNZ3t-00085Z-NK for emacs-orgmode@gnu.org; Wed, 10 Jan 2024 08:56:08 -0500 Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-5e82f502a4cso32612477b3.0 for ; Wed, 10 Jan 2024 05:56:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=positron.solutions; s=google; t=1704894964; x=1705499764; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=uAAVEtKBcLJjweRiPBwjHQaUls199/m1nl9W5DCpBHU=; b=kMv2tbP4XUMh32Id05ZaCvYQFD1WJwmDZ6WE9WBlYRm3VR3lNU80CeErX85q9pU3LD NiSSsE9djuc7PRL0kLj+bPygD8ttZBaP2NbOVBgQ0DknbQEA6E1ZJU3oE+YnVWHJmPpq s2QzuBO8YQW0E4ZJb4QZ/iGwOULVHhpGYNpLvCev0iKSw8miwmc79WdSQ1JlqGCpIkwa KQSxoxmaKsCilxE+XWqsfe/44Kg50d6cjcJFheR7u9kvCz3wi+SbX4ZES0boNJEpeGdk wy+rJr7ELkr8/qSAaas1uj9UaHO62HyZZHnmU1wxlk5+u0/JR/gq37OKF6we7tkxOirJ nyHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704894964; x=1705499764; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uAAVEtKBcLJjweRiPBwjHQaUls199/m1nl9W5DCpBHU=; b=H3BVH9O3frlhCX16rF06LIMVZP9hRRMNyWec87xtAgRFKI6yj3d7+8AjrUg5FrpA96 SzcT+f68OY//1ylzkMmZjTQRgtVcgf3fjx0v2PU9CvMiGalNsvtowp6pp6eZraB+A44i zj8GY4GIyl9H7LZT03O96+ZsMCa67BNwCEXzrAw9sePHzC6MGmrAyjpbXGF41DpDt9Gj q8Dkz1Gotq2AEkvJ9D76bKs9rhAIuoB5BVvom0B94rWWqBQ5qWyc26/TvGnK+tHjBd7/ t51CDLv8PRBGPiOuiM6Q88VAs87PlaTwvqOODhOwRbLLYsTz8p64kFY9dSWiT23AorMg Z67g== X-Gm-Message-State: AOJu0Yz1OaTE838jMww8bj5zMbUIP1i3DozxD8wl93i48S+uXBUeLkUF c1i787xTTLWeoRFPvJm7EE0i9Abe1TcKjEusjWxsbwWUvkMpMVr13lVTuXjFoI8= X-Google-Smtp-Source: AGHT+IH+KDEd95GFcSmyWiJRnfOSzGH31op8d4xReypAOMA5jqv8H05tIuzO7FKC7UUAOg0/8VTddPhHQHjjDvyc9l8= X-Received: by 2002:a81:8ac3:0:b0:5ee:65b3:f289 with SMTP id a186-20020a818ac3000000b005ee65b3f289mr893440ywg.3.1704894964026; Wed, 10 Jan 2024 05:56:04 -0800 (PST) MIME-Version: 1.0 References: <877ckhqso8.fsf@localhost> In-Reply-To: <877ckhqso8.fsf@localhost> From: Psionic K Date: Wed, 10 Jan 2024 22:55:52 +0900 Message-ID: Subject: Re: [PATCH] Unindentation fixup for code blocks To: Ihor Radchenko Cc: Psionic K , emacs-orgmode@gnu.org Content-Type: multipart/mixed; boundary="000000000000b61e56060e97ca8c" Received-SPF: pass client-ip=2607:f8b0:4864:20::1135; envelope-from=exec@positron.solutions; helo=mail-yw1-x1135.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 2B294AE43 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -5.91 X-Spam-Score: -5.91 X-TUID: N808Sxl0P4dR --000000000000b61e56060e97ca8c Content-Type: text/plain; charset="UTF-8" > Would you also be able to create a reproducer, so that we can replicate the problem and write a test? Yeah, I just have to make some indentation text invisible. Where should such a test live? Where is your documentation on running a test? > It looks like you did not send the patch with git send-emai. Nope. Magit patch create. Attaching another patch. > This math is not accurate when tabs are present. You want to short circuit this kind of conversation. I was not actually aware of any tabs versus spaces aware functions to build on top of since I always use spaces. Had I not already found another way to correct the behavior, this would have been a dead-end I would have had to round trip. I'm presuming tests don't get their own changelog entries. Is that correct? --000000000000b61e56060e97ca8c Content-Type: text/x-patch; charset="US-ASCII"; name="0001-org-macs.el-org-do-remove-indentation-correction.patch" Content-Disposition: attachment; filename="0001-org-macs.el-org-do-remove-indentation-correction.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lr7ubrr40 RnJvbSA5NjViNjBmNTg1MTJiMDA5Nzc4YjdiNTI3OTM5NGJmMDFkNDA3YzNmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQc2lvbmlrIEsgPDczNzEwOTMzK3BzaW9uaWMta0B1c2Vycy5u b3JlcGx5LmdpdGh1Yi5jb20+CkRhdGU6IFdlZCwgMTAgSmFuIDIwMjQgMjI6Mzc6MjggKzA5MDAK U3ViamVjdDogW1BBVENIXSBvcmctbWFjcy5lbDogb3JnLWRvLXJlbW92ZS1pbmRlbnRhdGlvbiBj b3JyZWN0aW9uCgoqIGxpc3Avb3JnLW1hY3MuZWwgKG9yZy1kby1yZW1vdmUtaW5kZW50YXRpb24p OiBzZXQKYGJ1ZmZlci1pbnZpc2liaWxpdHktc3BlYycgdG8gbmlsIGJlZm9yZSBkZXRlY3Rpbmcg dGhlIGNvbHVtbiBvcgptb3ZpbmcgdG8gYSBjb2x1bW4uCgpUaGlzIGZpeGVzIHNyY19ibG9jayBp bmRlbnRhdGlvbiByZW1vdmFsIGZvciBvcmctbW9kZXJuLW1vZGUgYnV0IHdpbGwKYWxzbyBjb3Jy ZWN0IG90aGVyIGNhc2VzIG9mIGhpZGRlbiBpbmRlbnRhdGlvbi4KLS0tCiBsaXNwL29yZy1tYWNz LmVsIHwgMyArKy0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24o LSkKCmRpZmYgLS1naXQgYS9saXNwL29yZy1tYWNzLmVsIGIvbGlzcC9vcmctbWFjcy5lbAppbmRl eCA4ZGVmNWNiYi4uN2Y1ZDJhZDggMTAwNjQ0Ci0tLSBhL2xpc3Avb3JnLW1hY3MuZWwKKysrIGIv bGlzcC9vcmctbWFjcy5lbApAQCAtNDA4LDcgKzQwOCw4IEBAIGxpbmUuICBSZXR1cm4gbmlsIGlm IGl0IGZhaWxzLiIKIAk7OyBSZW1vdmUgZXhhY3RseSBOIGluZGVudGF0aW9uLCBidXQgZ2l2ZSB1 cCBpZiBub3QgcG9zc2libGUuCiAgICAgICAgICh3aGVuIHNraXAtZmwgKGZvcndhcmQtbGluZSkp CiAJKHdoaWxlIChub3QgKGVvYnApKQotCSAgKGxldCAoKGluZCAocHJvZ24gKHNraXAtY2hhcnMt Zm9yd2FyZCAiIFx0IikgKGN1cnJlbnQtY29sdW1uKSkpKQorCSAgKGxldCogKChidWZmZXItaW52 aXNpYmlsaXR5LXNwZWMgbmlsKQorICAgICAgICAgICAgICAgICAoaW5kIChwcm9nbiAoc2tpcC1j aGFycy1mb3J3YXJkICIgXHQiKSAoY3VycmVudC1jb2x1bW4pKSkpCiAJICAgIChjb25kICgoPCBp bmQgbikKICAgICAgICAgICAgICAgICAgICAoaWYgKGVvbHApIChkZWxldGUtcmVnaW9uIChsaW5l LWJlZ2lubmluZy1wb3NpdGlvbikgKHBvaW50KSkKICAgICAgICAgICAgICAgICAgICAgICh0aHJv dyA6ZXhpdCBuaWwpKSkKLS0gCjIuNDIuMAoK --000000000000b61e56060e97ca8c--