From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Lebedeff Subject: Re: [PATCH] Tag visibility fixup after setting them Date: Thu, 29 Dec 2016 16:11:29 +0300 Message-ID: References: <87shp9r7ds.fsf@gmail.com> <87wpejo9fh.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=f403045e6240d6aebd0544cbd2c1 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53084) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cMaUX-0004GW-6U for emacs-orgmode@gnu.org; Thu, 29 Dec 2016 08:11:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cMaUW-0001IK-4R for emacs-orgmode@gnu.org; Thu, 29 Dec 2016 08:11:33 -0500 Received: from mail-ua0-x236.google.com ([2607:f8b0:400c:c08::236]:35547) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cMaUV-0001I1-VP for emacs-orgmode@gnu.org; Thu, 29 Dec 2016 08:11:32 -0500 Received: by mail-ua0-x236.google.com with SMTP id v2so54957707uac.2 for ; Thu, 29 Dec 2016 05:11:30 -0800 (PST) In-Reply-To: <87wpejo9fh.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: Orgmode Mailing List --f403045e6240d6aebd0544cbd2c1 Content-Type: multipart/alternative; boundary=f403045e6240d6aeb90544cbd2bf --f403045e6240d6aeb90544cbd2bf Content-Type: text/plain; charset=UTF-8 Hi Nicolas, I'm attaching updated patch. But I'm not sure it's a good idea to add another 6 lines of code to the function which is already big enough. Best, Alexey On Thu, Dec 29, 2016 at 3:39 AM, Nicolas Goaziou wrote: > Hello, > > Alexey Lebedeff writes: > > > This fixes bug where you sometimes can't immediately see tags that were > > just set. And to reveal them you need to go through global visibility > > cycle. > > Thank you for the patch, and the test. > > > +(defun org-insert-visible-text (&rest args) > > + "Inserts arguments at point and makes them visible in outline. > > + > > +When text is being inserted on the invisible region boundary, it > > +can be inadvertently sucked into invisibility." > > + (let* ((before-point (point))) > > + (apply #'insert args) > > + (outline-flag-region before-point (point) nil))) > > I don't think, for the time being, it deserves a dedicated function. > I suggest to integrate it in `org-set-tags' instead. > > Could you send an updated patch ? > > > Regards, > > -- > Nicolas Goaziou > --f403045e6240d6aeb90544cbd2bf Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Nicolas,

I'm attaching updat= ed patch. But I'm not sure it's a good idea to add another 6 lines = of code to the function which is already big enough.

Best,
Alexey


On Thu, Dec 29, 2016 at 3:39 AM, Nicol= as Goaziou <mail@nicolasgoaziou.fr> wrote:
Hello,

Alexey Lebedeff <binarin@gmail.com<= /a>> writes:

> This fixes bug where you sometimes can't immediately see tags that= were
> just set. And to reveal them you need to go through global visibility<= br> > cycle.

Thank you for the patch, and the test.

> +(defun org-insert-visible-text (&rest args)
> +=C2=A0 "Inserts arguments at point and makes them visible in out= line.
> +
> +When text is being inserted on the invisible region boundary, it
> +can be inadvertently sucked into invisibility."
> +=C2=A0 (let* ((before-point (point)))
> +=C2=A0 =C2=A0 (apply #'insert args)
> +=C2=A0 =C2=A0 (outline-flag-region before-point (point) nil)))

I don't think, for the time being, it deserves a dedicated function. I suggest to integrate it in `org-set-tags' instead.

Could you send an updated patch ?


Regards,

--
Nicolas Goaziou

--f403045e6240d6aeb90544cbd2bf-- --f403045e6240d6aebd0544cbd2c1 Content-Type: application/octet-stream; name="0001-Reveal-tags-after-setting-them.patch" Content-Disposition: attachment; filename="0001-Reveal-tags-after-setting-them.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ixae2lrp0 RnJvbSA3MjUwY2E4YzNjYmRjMGUxYjg4NGNlYmNlNGJjMTZlMjYwYTNhYTMxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4ZXkgTGViZWRlZmYgPGJpbmFyaW5AZ21haWwuY29tPgpE YXRlOiBTdW4sIDI1IERlYyAyMDE2IDEzOjI0OjA0ICswMzAwClN1YmplY3Q6IFtQQVRDSF0gUmV2 ZWFsIHRhZ3MgYWZ0ZXIgc2V0dGluZyB0aGVtCgpTb21ldGltZXMgZnJlc2hseSBhZGRlZCB0YWdz IGNhbiBiZSBzdWNrZWQgaW50byBpbnZpc2libGUgb3V0bGluZQpyZWdpb24gKGRlbm90ZWQgYnkg ZWxsaXBzaXMpIC0gYW5kIHRvIHNlZSB0aGVtIHlvdSBuZWVkIHRvIGRvIHRoZSBmdWxsCmdsb2Jh bCB2aXNpYmlsdHkgY3ljbGUuCi0tLQogbGlzcC9vcmcuZWwgICAgICAgICAgICAgIHwgIDcgKysr KysrLQogdGVzdGluZy9saXNwL3Rlc3Qtb3JnLmVsIHwgMTggKysrKysrKysrKysrKysrKysrCiAy IGZpbGVzIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1n aXQgYS9saXNwL29yZy5lbCBiL2xpc3Avb3JnLmVsCmluZGV4IDNkZGQ4MGIuLjM3NWMxOGQgMTAw NjQ0Ci0tLSBhL2xpc3Avb3JnLmVsCisrKyBiL2xpc3Avb3JnLmVsCkBAIC0xNTA5Niw3ICsxNTA5 NiwxMiBAQCBXaGVuIEpVU1QtQUxJR04gaXMgbm9uLW5pbCwgb25seSBhbGlnbiB0YWdzLiIKIAkg ICAgICA7OyB3aGl0ZSBzcGFjZXMuCiAJICAgICAgKGVuZC1vZi1saW5lKQogCSAgICAgIChpZiAo bm90IChlcXVhbCB0YWdzICIiKSkKLQkJICAoaW5zZXJ0ICIgIiB0YWdzKQorCQkgIChsZXQqICgo YmVmb3JlLXBvaW50IChwb2ludCkpKQorCQkgICAgKGluc2VydCAiICIgdGFncykKKwkJICAgIDs7 IFdoZW4gdGV4dCBpcyBiZWluZyBpbnNlcnRlZCBvbiBhbiBpbnZpc2libGUKKwkJICAgIDs7IHJl Z2lvbiBib3VuZGFyeSwgaXQgY2FuIGJlIGluYWR2ZXJ0ZW50bHkgc3Vja2VkCisJCSAgICA7OyBp bnRvIGludmlzaWJpbGl0eS4KKwkJICAgIChvdXRsaW5lLWZsYWctcmVnaW9uIGJlZm9yZS1wb2lu dCAocG9pbnQpIG5pbCkpCiAJCShza2lwLWNoYXJzLWJhY2t3YXJkICIgXHQiKQogCQkoZGVsZXRl LXJlZ2lvbiAocG9pbnQpIChsaW5lLWVuZC1wb3NpdGlvbikpKSkpCiAJICA7OyBBbGlnbiB0YWdz LCBpZiBhbnkuICBGaXggdGFncyBjb2x1bW4gaWYgYG9yZy1pbmRlbnQtbW9kZScKZGlmZiAtLWdp dCBhL3Rlc3RpbmcvbGlzcC90ZXN0LW9yZy5lbCBiL3Rlc3RpbmcvbGlzcC90ZXN0LW9yZy5lbApp bmRleCBiYmQwYzBiLi5kNjAzNjRhIDEwMDY0NAotLS0gYS90ZXN0aW5nL2xpc3AvdGVzdC1vcmcu ZWwKKysrIGIvdGVzdGluZy9saXNwL3Rlc3Qtb3JnLmVsCkBAIC01MTMwLDYgKzUxMzAsMjQgQEAg UGFyYWdyYXBoPHBvaW50PiIKICAgKHNob3VsZC1ub3QKICAgIChvcmctdGVzdC13aXRoLXRlbXAt dGV4dCAiUGFyYWdyYXBoIiAob3JnLWhpZGUtYmxvY2stdG9nZ2xlLW1heWJlKSkpKQogCisoZXJ0 LWRlZnRlc3QgdGVzdC1vcmcvZmFzdC10YWctc2VsZWN0aW9uICgpCisgICJUZXN0IGBvcmctZmFz dC10YWctc2VsZWN0aW9uJy4iCisgIDs7IFRhZ3Mgc2V0IHZpYSBmYXN0LXRhZy1zZWxlY3Rpb24g c2hvdWxkIGJlIHZpc2libGUgYWZ0ZXJ3YXJkcworICAoc2hvdWxkCisgICAobGV0ICgob3JnLXRh Zy1hbGlzdCAnKCgiTkVYVCIgLiA/bikpKQorCSAob3JnLWZhc3QtdGFnLXNlbGVjdGlvbi1zaW5n bGUta2V5IHQpKQorICAgICAoY2wtbGV0ZiAoKChzeW1ib2wtZnVuY3Rpb24gJ3JlYWQtY2hhci1l eGNsdXNpdmUpIChsYW1iZGEgKCkgP24pKQorCSAgICAgICAoKHN5bWJvbC1mdW5jdGlvbiAnd2lu ZG93LXdpZHRoKSAobGFtYmRhICgmcmVzdCBhcmdzKSAxMDApKSkKKyAgICAgICAob3JnLXRlc3Qt d2l0aC10ZW1wLXRleHQgIjxwb2ludD4qIEhlYWRsaW5lXG5BbmQgaXRzIGNvbnRlbnRcbiogQW5k IGFub3RoZXIgaGVhZGxpbmVcblxuV2l0aCBzb21lIGNvbnRlbnQiCisJIDs7IFNob3cgb25seSBo ZWFkbGluZXMKKwkgKG9yZy1jb250ZW50KQorCSA7OyBTZXQgTkVYVCB0YWcgb24gY3VycmVudCBl bnRyeQorCSAob3JnLXNldC10YWdzIG5pbCBuaWwpCisJIDs7IE1vdmUgcG9pbnQgdG8gdGhhdCBO RVhUIHRhZworCSAoc2VhcmNoLWZvcndhcmQgIk5FWFQiKSAoYmFja3dhcmQtd29yZCkKKwkgOzsg QW5kIGl0IHNob3VsZCBiZSB2aXNpYmxlIChpLmUuIG5vIG92ZXJsYXlzKQorCSAobm90IChvdmVy bGF5cy1hdCAocG9pbnQpKSkpKSkpKQorCiAoZXJ0LWRlZnRlc3QgdGVzdC1vcmcvc2hvdy1zZXQt dmlzaWJpbGl0eSAoKQogICAiVGVzdCBgb3JnLXNob3ctc2V0LXZpc2liaWxpdHknIHNwZWNpZmlj YXRpb25zLiIKICAgOzsgRG8gbm90IHRocm93IGFuIGVycm9yIGJlZm9yZSBmaXJzdCBoZWFkaW5n LgotLSAKMi4xMC4wCgo= --f403045e6240d6aebd0544cbd2c1--