From: Alexey Lebedeff <binarin@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Orgmode Mailing List <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Tag visibility fixup after setting them
Date: Thu, 29 Dec 2016 16:11:29 +0300 [thread overview]
Message-ID: <CADOt_n-aHF1XFYETt1OY2q7WuA3XzQ2yLdFKKEKYny=bAygxMQ@mail.gmail.com> (raw)
In-Reply-To: <87wpejo9fh.fsf@nicolasgoaziou.fr>
[-- Attachment #1.1: Type: text/plain, Size: 1098 bytes --]
Hi Nicolas,
I'm attaching updated patch. But I'm not sure it's a good idea to add
another 6 lines of code to the function which is already big enough.
Best,
Alexey
On Thu, Dec 29, 2016 at 3:39 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:
> Hello,
>
> Alexey Lebedeff <binarin@gmail.com> writes:
>
> > This fixes bug where you sometimes can't immediately see tags that were
> > just set. And to reveal them you need to go through global visibility
> > cycle.
>
> Thank you for the patch, and the test.
>
> > +(defun org-insert-visible-text (&rest args)
> > + "Inserts arguments at point and makes them visible in outline.
> > +
> > +When text is being inserted on the invisible region boundary, it
> > +can be inadvertently sucked into invisibility."
> > + (let* ((before-point (point)))
> > + (apply #'insert args)
> > + (outline-flag-region before-point (point) nil)))
>
> I don't think, for the time being, it deserves a dedicated function.
> I suggest to integrate it in `org-set-tags' instead.
>
> Could you send an updated patch ?
>
>
> Regards,
>
> --
> Nicolas Goaziou
>
[-- Attachment #1.2: Type: text/html, Size: 1772 bytes --]
[-- Attachment #2: 0001-Reveal-tags-after-setting-them.patch --]
[-- Type: application/octet-stream, Size: 2408 bytes --]
From 7250ca8c3cbdc0e1b884cebce4bc16e260a3aa31 Mon Sep 17 00:00:00 2001
From: Alexey Lebedeff <binarin@gmail.com>
Date: Sun, 25 Dec 2016 13:24:04 +0300
Subject: [PATCH] Reveal tags after setting them
Sometimes freshly added tags can be sucked into invisible outline
region (denoted by ellipsis) - and to see them you need to do the full
global visibilty cycle.
---
lisp/org.el | 7 ++++++-
testing/lisp/test-org.el | 18 ++++++++++++++++++
2 files changed, 24 insertions(+), 1 deletion(-)
diff --git a/lisp/org.el b/lisp/org.el
index 3ddd80b..375c18d 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -15096,7 +15096,12 @@ When JUST-ALIGN is non-nil, only align tags."
;; white spaces.
(end-of-line)
(if (not (equal tags ""))
- (insert " " tags)
+ (let* ((before-point (point)))
+ (insert " " tags)
+ ;; When text is being inserted on an invisible
+ ;; region boundary, it can be inadvertently sucked
+ ;; into invisibility.
+ (outline-flag-region before-point (point) nil))
(skip-chars-backward " \t")
(delete-region (point) (line-end-position)))))
;; Align tags, if any. Fix tags column if `org-indent-mode'
diff --git a/testing/lisp/test-org.el b/testing/lisp/test-org.el
index bbd0c0b..d60364a 100644
--- a/testing/lisp/test-org.el
+++ b/testing/lisp/test-org.el
@@ -5130,6 +5130,24 @@ Paragraph<point>"
(should-not
(org-test-with-temp-text "Paragraph" (org-hide-block-toggle-maybe))))
+(ert-deftest test-org/fast-tag-selection ()
+ "Test `org-fast-tag-selection'."
+ ;; Tags set via fast-tag-selection should be visible afterwards
+ (should
+ (let ((org-tag-alist '(("NEXT" . ?n)))
+ (org-fast-tag-selection-single-key t))
+ (cl-letf (((symbol-function 'read-char-exclusive) (lambda () ?n))
+ ((symbol-function 'window-width) (lambda (&rest args) 100)))
+ (org-test-with-temp-text "<point>* Headline\nAnd its content\n* And another headline\n\nWith some content"
+ ;; Show only headlines
+ (org-content)
+ ;; Set NEXT tag on current entry
+ (org-set-tags nil nil)
+ ;; Move point to that NEXT tag
+ (search-forward "NEXT") (backward-word)
+ ;; And it should be visible (i.e. no overlays)
+ (not (overlays-at (point))))))))
+
(ert-deftest test-org/show-set-visibility ()
"Test `org-show-set-visibility' specifications."
;; Do not throw an error before first heading.
--
2.10.0
next prev parent reply other threads:[~2016-12-29 13:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 10:30 [PATCH] Tag visibility fixup after setting them Alexey Lebedeff
2016-12-29 0:39 ` Nicolas Goaziou
2016-12-29 13:11 ` Alexey Lebedeff [this message]
2016-12-29 15:41 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADOt_n-aHF1XFYETt1OY2q7WuA3XzQ2yLdFKKEKYny=bAygxMQ@mail.gmail.com' \
--to=binarin@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).