From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel F Subject: Re: RFQ - new contribution - org-screenshot.el Date: Fri, 17 May 2013 16:33:14 +0400 Message-ID: References: <87mwru8f57.wl%max@openchat.com> <874ne23zir.fsf@bzg.ath.cx> <87ppwqawei.fsf@krugs.de> <87li7d99db.wl%max@openchat.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11c36dc2d8097004dce92fd4 Return-path: Received: from eggs.gnu.org ([208.118.235.92]:57173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UdJqe-0004jb-2e for emacs-orgmode@gnu.org; Fri, 17 May 2013 08:33:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UdJqX-0003ap-B1 for emacs-orgmode@gnu.org; Fri, 17 May 2013 08:33:24 -0400 In-Reply-To: <87li7d99db.wl%max@openchat.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: "Rainer M. Krug" , Bastien , "emacs-orgmode@gnu.org Mode" --001a11c36dc2d8097004dce92fd4 Content-Type: text/plain; charset=ISO-8859-1 It looks great! I think I'd only convert defvars to defcustom. Personally, I don't worry about prefixes that much, because if I am not using a command very often I just tend do run it using M-x command-name - Dan On Fri, May 17, 2013 at 2:41 PM, Max Mikhanosha wrote: > At Fri, 17 May 2013 09:38:29 +0200, > Rainer M. Krug wrote: > > > > Nice and very useful. Can this be included in /contrib? > > That is my intention, I have the FSF paper signed for Emacs and Org. > > So what I'm looking for some minimum amount of eyes on the code, and > advice as to minimum set of things I need to adjust before committing it? > > My list is. > > 1. Convert defvar to defcustom > > 2. Is (require 'dired) fine? It uses macro `dired-mark-if' defined in > dired.el > > 3. The prefix C-c M-s seems awkward but Org is so big everything else > is taken, and C-c C-x s is too close to C-c C-x C-s, which is > archive subtree (I initially had it there and moved after archiving > subtree by mistake) > > Its its fine to go in as is, then its fine too, I'm pretty lazy :-) > > Regards, > Max > > -- Sincerely yours, -- Daniil --001a11c36dc2d8097004dce92fd4 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
It looks great!
I think I'd on= ly convert defvars to defcustom.

Personally, I don't worry= about prefixes that much, because if I am not using a command very often I= just tend do run it using M-x command-name

- Dan


On Fri, May 17, 2013 at 2:41 PM, Max Mikhanosha <max@openchat.c= om> wrote:
At Fri, 17 May 2013 09:38:29 +0200,
Rainer M. Krug wrote:
>
> Nice and very useful. Can this be included in /contrib?

That is my intention, I have the FSF paper signed for Emacs and Org.<= br>
So what I'm looking for some minimum amount of eyes on the code, and advice as to minimum set of things I need to adjust before committing it?
My list is.

1. Convert defvar to defcustom

2. Is (require 'dired) fine? It uses macro `dired-mark-if' defined = in
=A0 =A0dired.el

3. The prefix C-c M-s seems awkward but Org is so big everything else
=A0 =A0is taken, and C-c C-x s is too close to C-c C-x C-s, which is
=A0 =A0archive subtree (I initially had it there and moved after archiving<= br> =A0 =A0subtree by mistake)

Its its fine to go in as is, then its fine too, I'm pretty lazy :-)

Regards,
=A0 Max




--
Sincerely yours,
-- = Daniil
--001a11c36dc2d8097004dce92fd4--