From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id TINrME240GKuqQAAbAwnHQ (envelope-from ) for ; Fri, 15 Jul 2022 02:43:57 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id oLtqL0240GKYbAAA9RJhRA (envelope-from ) for ; Fri, 15 Jul 2022 02:43:57 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5FABF3E7AC for ; Fri, 15 Jul 2022 02:43:57 +0200 (CEST) Received: from localhost ([::1]:40940 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oC9Qv-0006kE-P1 for larch@yhetil.org; Thu, 14 Jul 2022 20:43:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51684) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oC9QH-0006jx-Lb for emacs-orgmode@gnu.org; Thu, 14 Jul 2022 20:43:13 -0400 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]:47095) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oC9QF-0003Kw-O9 for emacs-orgmode@gnu.org; Thu, 14 Jul 2022 20:43:13 -0400 Received: by mail-lf1-x131.google.com with SMTP id bf9so5414675lfb.13 for ; Thu, 14 Jul 2022 17:43:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=C19Ujm5LamDkfgYd2cnL0vBFdCkomC7RVOKz6ItmBYo=; b=pUodllX2Hcc5L0K593Lr1pu8JKTzGXxHI/W+3AHHVYx7m0AFgM+Ok66SxRf7Fqr7Ny p10/KUQmo/h2cx5biK6RYB/cdBdXDRpETd2pd1m3+5AdCUK4a8WMEyT2Sh7a8Xy90UlQ kY/gpRqrNLUK2lfbedj9EDwPRVrss4tbzfu0WC2rIofWHcSKrttsBxzUiKgm0Cl17bKH wxT2m1XivFkoetG8Jpm51tU94xM/MfUS3mNLXyssGU1co+V4vQ0apThzG0Lgms0N0D1V QAKingMdzILHzJqpwF1BoDw/tO1/BkTI7YE27KyDhIUirXvzLboP5Wn+4bIu6tW9djm4 iKWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=C19Ujm5LamDkfgYd2cnL0vBFdCkomC7RVOKz6ItmBYo=; b=N/8Jhu7VBY3Py45IfQsvceRcv0YYatBAgXVDs7EuMaUJOH3HSXMVeG9UH/4Dav6ZN4 i1rswIhofZJrHXHryayZ5xrj7BbkyHK1aTDMUnpkXfP0zYBOEluQNOxB7LVwc3sbyhUH 6gk1ZomR2srv+XaWiZisNauLvp3R1GPSRU/JSr7r+ZvjIiQFQS+vkOn8LrBYUimi1B1W 7CP/7GBln0JfQxPMDL2qnvAv9hsiyrspQB8t1uakCRp5ZNHTOkiAE2FHabU02hbe5QIS 9RWkSS2ZpxBvHTAQsg3c07pCKRwu3sdFrMhIjX0oYswpU1EHqo+NhsHMCd8DI8uttUAw mCug== X-Gm-Message-State: AJIora8IdVq0J+26lNhJ2BP13D4zw04HAod1yIZe6/iUNbeQpcJ9KvTl /Gku6cVMrQ+ej3VqufH5samaL2IHFLN3L0YaVs7+qJPGEFL2sc+t X-Google-Smtp-Source: AGRyM1tr4waPFejk3iSDyrXMo2HiqeFKT7QKLwW06JQw22HzekUU+8qZkbQTMoTVFvr4873FlvNkqSaL47xCVi5YqR4= X-Received: by 2002:a05:6512:3e0a:b0:489:e50b:1dc9 with SMTP id i10-20020a0565123e0a00b00489e50b1dc9mr6924800lfv.321.1657845789105; Thu, 14 Jul 2022 17:43:09 -0700 (PDT) MIME-Version: 1.0 From: Ihor Radchenko Date: Fri, 15 Jul 2022 08:44:08 +0800 Message-ID: Subject: [BUG] org-colview tests fail in Emacs 29 because of wrong org-colview's assumptions about current-column [9.5.4 (release_9.5.4-626-g45f9d8.dirty @ /home/yantar92/.emacs.d/straight/build/org/)] To: emacs-orgmode Content-Type: multipart/alternative; boundary="0000000000005a230305e3cd4df7" Received-SPF: pass client-ip=2a00:1450:4864:20::131; envelope-from=yantar92@gmail.com; helo=mail-lf1-x131.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1657845837; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=C19Ujm5LamDkfgYd2cnL0vBFdCkomC7RVOKz6ItmBYo=; b=qFe4k1K3NxtNhifjQQR7SyEvewFPChRa9Gc8EoctKNBSuKGqr9czk+Y9G8iqHt5u5vg+tJ YI0oNuoJHJ4OwmdfrBJYaRQP5Du7TvcYCJsPf4QH5GPaK6fEGvapd4wUahGNOSdT/hJwz9 wQiDWCVNfySCQS86S3WUYlfa1I/qU47Pckw3iFnEIv1jQ0nhs6XZe0piOOPmAVGgvbLRo2 WAN/0KpJB4L9qIFRaDV1T/hVbm0WLKeYYucV8AJuMebR0MRtcyc2LI011bmEPcIIl7uhUR rXY0KpKWCa4tNTAt0isCMUfisU32Ixrwxhj++Y1MCy3y+/v3GGKJxTnGS3VU9g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1657845837; a=rsa-sha256; cv=none; b=ZDuovyTmaeM9LT5WWYelc+rTUQB1KUy2+NEMPFRXyXXmGVHpJRwwLjMZv/CZ+OJkPsENEa uD4B5ksCqcYg6Zq3hJUFIjkF3xxXB+9NV6QojvhWWjHrJjW4DAgc7bsGo+ileq4dtt+eO/ CoML6qvqXi3wBRnD4z49bWh+HxqIow6SQC5m3WYh1tszZOby5YvVc50vW1ZhytJmMnbysm qTeiiUcEWD07kDzg175wDk0ztY2AO5qIa2itoETjbcZDYyLAfcTmwEjyWsxkV20po7hilr MlEF2DqCrdsB0kD13Ji8CyQRedDzrVlm2J9HHLLAxtYe5WTbj5vqt/CNw5s28w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=pUodllX2; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.55 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=pUodllX2; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 5FABF3E7AC X-Spam-Score: -5.55 X-Migadu-Scanner: scn0.migadu.com X-TUID: vwJWs8/8jhsX --0000000000005a230305e3cd4df7 Content-Type: text/plain; charset="UTF-8" Hi, On Emacs 29, make test will fail on both bugfix and main: 5 unexpected results: FAILED test-org-colview/columns-move-left FAILED test-org-colview/columns-move-right FAILED test-org-colview/columns-new FAILED test-org-colview/columns-next-allowed-value FAILED test-org-colview/columns-update This happens since Emacs commit 4243747b1b8c3b7e3463822804b32e83febe2878: ;; Fix 'current-column' in the presence of display strings ;; * src/indent.c (check_display_width): Support calculation of width ;; of 'display' properties whose values are strings. This fixes the ;; value returned by 'current-column' when display strings are ;; present between BOL and point. (Bug#53795) There is nothing wrong in this Emacs commit. However, org-colview.el, and particularly (nth (current-column) org-columns-current-fmt-compiled) statements, e.g. in org-columns-update (also in other places) rely on current-column ignoring overlays and display properties. To see the issue interactively, one can use the following example recipe: 1. Run Emacs 29 master loading the latest bugfix/main Org branch 2. Open the following file: * H :PROPERTIES: :A: 1 :END: ** S :PROPERTIES: :A: 2 :END: 3. Put point at the beginning of the first heading 4. Run M-: (let ((org-columns-default-format "%A %A{min}")) (org-columns)) 5. Run M-: (org-columns-update "A") 6. Observe (error "Invalid column specification format: nil") caused by org-columns-update trying to retrieve the column format using the sexp relying of (current-column). Note that fixing this bug will probably require checking the logic of org-colview - one may need to dive deeply into that code. Best, Ihor --0000000000005a230305e3cd4df7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

On Emacs 29, make test will fail on both bugfix= and main:

5 unexpected results:
=C2=A0 =C2=A0FAILED =C2=A0test-o= rg-colview/columns-move-left
=C2=A0 =C2=A0FAILED =C2=A0test-org-colview/= columns-move-right
=C2=A0 =C2=A0FAILED =C2=A0test-org-colview/columns-ne= w
=C2=A0 =C2=A0FAILED =C2=A0test-org-colview/columns-next-allowed-value<= br>=C2=A0 =C2=A0FAILED =C2=A0test-org-colview/columns-update

This ha= ppens since Emacs commit
4243747b1b8c3b7e3463822804b32e83febe2878:
;; Fix 'current-column' in the presence of display strings
;; * src/indent.c (check_display_width): Support calculation of width
;= ; of 'display' properties whose values are strings.=C2=A0 This fixe= s the
;; value returned by 'current-column' when display strings= are
;; present between BOL and point. =C2=A0(Bug#53795)

There is= nothing wrong in this Emacs commit.
However, org-colview.el, and partic= ularly

(nth (current-column) org-columns-current-fmt-compiled)
st= atements, e.g. in org-columns-update (also in other places)

rely on = current-column ignoring overlays and display properties.

To see the = issue interactively, one can use the following example
recipe:

1.= Run Emacs 29 master loading the latest bugfix/main Org branch
2. Open t= he following file:

* H
:PROPERTIES:
:A: 1
:END:
** S
= :PROPERTIES:
:A: 2
:END:

3. Put point at the beginning of the = first heading
4. Run M-: (let ((org-columns-default-format "%A %A{m= in}")) (org-columns))
5. Run M-: (org-columns-update "A")=
6. Observe (error "Invalid column specification format: nil")= caused by
=C2=A0 =C2=A0org-columns-update trying to retrieve the column= format using the
=C2=A0 =C2=A0sexp relying of (current-column).

= Note that fixing this bug will probably require checking the logic of
or= g-colview - one may need to dive deeply into that code.

Best,
Iho= r

--0000000000005a230305e3cd4df7--