From: Ihor Radchenko <yantar92@gmail.com>
To: Max Nikulin <manikulin@gmail.com>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: Potential bug: Invalid function: org-encode-time
Date: Tue, 16 Aug 2022 20:51:43 +0800 [thread overview]
Message-ID: <CACnOyiiwq7Tp1TPutgGT6=1cWFT4Lqim5UZfDtGuJqWz45Xomg@mail.gmail.com> (raw)
In-Reply-To: <tdg3fg$rbs$1@ciao.gmane.io>
[-- Attachment #1: Type: text/plain, Size: 1162 bytes --]
> Testing of `encode-time' version by running it on
each macro expansion can hardly be called optimal.
It will mostly impact the compile time. If you wish, you may wrap the
version check and the `encode-time' test into `eval-when-compile'
On Tue, Aug 16, 2022 at 8:44 PM Max Nikulin <manikulin@gmail.com> wrote:
> On 16/08/2022 18:55, Ihor Radchenko wrote:
> > Max Nikulin writes:
> >
> >>> This is Emacs bug. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56746
> >>>
> >>> I just pushed a workaround that should hopefully fix the issue.
> >>
> >> Is there a chance that `eval-when-compile' around the original
> >> definition will help? Sorry, I am still avoiding setting up of
> >> development environment for emacs.
> >
> > It could, but I took a different approach.
> > See
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=d3a9c424ba32382fff1da4f4ecb447dc99205261
>
> Thank you for the fix. I asked about `eval-when-compile' because lack of
> it may be my mistake and with hope to find a workaround with no
> performance impact. Testing of `encode-time' version by running it on
> each macro expansion can hardly be called optimal.
>
>
>
[-- Attachment #2: Type: text/html, Size: 1876 bytes --]
prev parent reply other threads:[~2022-08-16 12:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-14 20:23 Potential bug: Invalid function: org-encode-time Duy Nguyen
2022-08-16 9:20 ` Ihor Radchenko
2022-08-16 10:08 ` Duy Nguyen
2022-08-16 11:47 ` Max Nikulin
2022-08-16 11:55 ` Ihor Radchenko
2022-08-16 12:44 ` Max Nikulin
2022-08-16 12:51 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACnOyiiwq7Tp1TPutgGT6=1cWFT4Lqim5UZfDtGuJqWz45Xomg@mail.gmail.com' \
--to=yantar92@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=manikulin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).