From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jay Kamat <jaygkamat@gmail.com>
Subject: Re: [PATCH] Fix ox-md remote image links export
Date: Sun, 6 Aug 2017 09:10:49 -0700
Message-ID: <CACe_Yv_xKRQeS70nssODxZwDa-KM9FBig7c+iP82W1wTeRbdHw@mail.gmail.com>
References: <CACe_Yv-rfFmeON1Qo+PsmheJojymW0=czmTscKJOFW=yGBrr1w@mail.gmail.com>
	<87a83df9q9.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48584)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jaygkamat@gmail.com>) id 1deO92-0005uX-Fz
	for emacs-orgmode@gnu.org; Sun, 06 Aug 2017 12:11:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jaygkamat@gmail.com>) id 1deO91-00008n-6n
	for emacs-orgmode@gnu.org; Sun, 06 Aug 2017 12:11:12 -0400
Received: from mail-io0-x22a.google.com ([2607:f8b0:4001:c06::22a]:37901)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <jaygkamat@gmail.com>) id 1deO91-00008d-27
	for emacs-orgmode@gnu.org; Sun, 06 Aug 2017 12:11:11 -0400
Received: by mail-io0-x22a.google.com with SMTP id g71so18870598ioe.5
	for <emacs-orgmode@gnu.org>; Sun, 06 Aug 2017 09:11:10 -0700 (PDT)
In-Reply-To: <87a83df9q9.fsf@nicolasgoaziou.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org

Hi,

> Thank you for the report and the patch. I have committed a slightly
> different change. Does it solve your issue?

Yup, this commit solves my issues, thanks! It's also a lot cleaner
than my patch :).

Thanks again,
-Jay

On Sun, Aug 6, 2017 at 12:15 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Hello,
>
> Jay Kamat <jaygkamat@gmail.com> writes:
>
>> I discovered a bug in the ox-md exporter and have created a patch to fix it:
>>
>> Previously, this image link:
>> [[https://git-scm.com/images/logo@2x.png]]
>>
>> would export to:
>> ![img](//git-scm.com/images/logo@2x.png)
>>
>> which is an invalid markdown image, and won't display properly in
>> browsers and other places.
>>
>> A workaround (which I have been using extremely heavily), is:
>> [[file:https://git-scm.com/images/logo@2x.png]]
>>
>> which exports to
>> ![img](https://git-scm.com/images/logo@2x.png)
>>
>> Which is the proper (unbroken) image link.
>>
>> I have attached a patch which fixes the first example, so it exports
>> the same link as the workaround (and is no longer broken).
>
> Thank you for the report and the patch. I have committed a slightly
> different change. Does it solve your issue?
>
>> My papers are currently being processed, but I thought I would post
>> this patch early to get feedback, since ideally I would like this bug
>> to be fixed as soon as possible :). Hopefully they'll be done before
>> the review is completed.
>
> Great! Let me know when the process is done.
>
> Regards,
>
> --
> Nicolas Goaziou