From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jay Kamat Subject: Fixing mailto and irc links in ox-md.el Date: Sun, 9 Jul 2017 18:20:34 -0700 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="001a1144010803ef0d0553ec65c8" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39901) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUNP4-0004GE-Mc for emacs-orgmode@gnu.org; Sun, 09 Jul 2017 21:22:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUNP1-0006u6-HM for emacs-orgmode@gnu.org; Sun, 09 Jul 2017 21:22:22 -0400 Received: from mail-yb0-f173.google.com ([209.85.213.173]:34428) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dUNP1-0006mD-Ae for emacs-orgmode@gnu.org; Sun, 09 Jul 2017 21:22:19 -0400 Received: by mail-yb0-f173.google.com with SMTP id e201so23624520ybb.1 for ; Sun, 09 Jul 2017 18:21:56 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org --001a1144010803ef0d0553ec65c8 Content-Type: text/plain; charset="UTF-8" Hi! I would like to submit a patch to org mode, which fixes the behavior of mailto and irc links in markdown export. Previously, these org mode snippets: [[mailto:some.email@server.net][Jane Doe]] [[irc:/irc.com/#emacs/bob][bob]] would export to: [Jane Doe](some.email@server.net) [bob](/irc.com/#emacs/bob) which causes broken links in browsers when they try to view exported markdown. The new behavior exports them to: [Jane Doe](mailto:some.email@server.net) [bob](irc:/irc.com/#emacs/bob) so that browsers can open the proper respective application when opening said links. The patch that I have made is very small (only one line), and is attached. There is an external report of this bug here: https://github.com/larstvei/ox-gfm/issues/17 This is my first time submitting a patch to anything big like org mode, so please let me know if I've done anything wrong or if anything seems amiss. Thanks for looking at this, and thanks for making/developing on org mode (it's changed my life completely)! -Jay Kamat --001a1144010803ef0d0553ec65c8 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-ox-md.el-Fix-export-of-irc-and-mailto-links.patch" Content-Disposition: attachment; filename="0001-ox-md.el-Fix-export-of-irc-and-mailto-links.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j4xg8ew20 RnJvbSAwZWYyMWZjZDYzOTRiMzU1MWE5NGE1ODc4ZDQxNGYyZTdkMTdlMzcyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYXkgS2FtYXQgPGpheWdrYW1hdEBnbWFpbC5jb20+CkRhdGU6 IFN1biwgOSBKdWwgMjAxNyAxNzo1MDowOSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIG94LW1kLmVs OiBGaXggZXhwb3J0IG9mIGlyYyBhbmQgbWFpbHRvIGxpbmtzCgoqIGxpc3Avb3gtbWQuZWwgKG9y Zy1tZC1saW5rKTogQWRkIG1haWx0byBhbmQgaXJjIHRvIGxpbmtzIHRoYXQgcGFzcwp0aGVpciB0 eXBlcyB0aHJvdWdoIHRvIG1hcmtkb3duIGV4cG9ydAoKU2VlOiBodHRwczovL2dpdGh1Yi5jb20v bGFyc3R2ZWkvb3gtZ2ZtL2lzc3Vlcy8xNyAgZm9yIGFuIGV4dGVybmFsCmJ1ZyByZXBvcnQKClRJ TllDSEFOR0UKLS0tCiBsaXNwL294LW1kLmVsIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5z ZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9veC1tZC5lbCBiL2xp c3Avb3gtbWQuZWwKaW5kZXggZTJiM2QyOWUxLi4wOGUzODUyODIgMTAwNjQ0Ci0tLSBhL2xpc3Av b3gtbWQuZWwKKysrIGIvbGlzcC9veC1tZC5lbApAQCAtNDQ4LDcgKzQ0OCw3IEBAIGEgY29tbXVu aWNhdGlvbiBjaGFubmVsLiIKICAgICAgKHQgKGxldCogKChyYXctcGF0aCAob3JnLWVsZW1lbnQt cHJvcGVydHkgOnBhdGggbGluaykpCiAJICAgICAgIChwYXRoCiAJCShjb25kCi0JCSAoKG1lbWJl ciB0eXBlICcoImh0dHAiICJodHRwcyIgImZ0cCIpKQorCQkgKChtZW1iZXIgdHlwZSAnKCJodHRw IiAiaHR0cHMiICJmdHAiICJtYWlsdG8iICJpcmMiKSkKIAkJICAoY29uY2F0IHR5cGUgIjoiIHJh dy1wYXRoKSkKIAkJICgoc3RyaW5nPSB0eXBlICJmaWxlIikKIAkJICAob3JnLWV4cG9ydC1maWxl LXVyaSAoZnVuY2FsbCBsaW5rLW9yZy1maWxlcy1hcy1tZCByYXctcGF0aCkpKQotLSAKMi4xMS4w Cgo= --001a1144010803ef0d0553ec65c8--