From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pascal Fleury Subject: Re: Export arrays for 'sh' code blocks when using bash Date: Tue, 15 Apr 2014 13:15:36 +0200 Message-ID: References: <871txn1qni.fsf@bagel.gateway.pace.com> <871txkff89.fsf@gmail.com> <871tx4zj3i.fsf@gmail.com> <8761mg3sry.fsf@bzg.ath.cx> <87fvlfs1oh.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7b5d2c302558a804f712edb9 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40474) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wa1LY-00055t-JV for emacs-orgmode@gnu.org; Tue, 15 Apr 2014 07:16:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wa1LU-0000Nu-6X for emacs-orgmode@gnu.org; Tue, 15 Apr 2014 07:16:12 -0400 Received: from mail-vc0-x22a.google.com ([2607:f8b0:400c:c03::22a]:56894) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wa1LU-0000Nj-0K for emacs-orgmode@gnu.org; Tue, 15 Apr 2014 07:16:08 -0400 Received: by mail-vc0-f170.google.com with SMTP id hu19so9217254vcb.29 for ; Tue, 15 Apr 2014 04:16:07 -0700 (PDT) In-Reply-To: <87fvlfs1oh.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Eric Schulte Cc: Bastien , Pascal Fleury , emacs-orgmode@gnu.org --047d7b5d2c302558a804f712edb9 Content-Type: text/plain; charset=UTF-8 Thanks Eric! --pascal On Tue, Apr 15, 2014 at 5:35 AM, Eric Schulte wrote: > Pascal Fleury writes: > > > Hello, > > > > Great, thanks for the guidance. I hope I managed it all correctly. > > > > I've applied this patch. > > I made a couple of minor changes in a subsequent commit (a7189aa). > These were indentation and whitespace changes to enforce two coding > conventions, > > 1. limit line lengths to <80 characters > 2. remove dangling parens on lines w/o any other text > > and to rename one function to be specific to ob-shell.el. > > Thanks for contributing! > > > > > On Fri, Apr 11, 2014 at 11:33 AM, Bastien wrote: > > > >> Hi Eric and Pascal, > >> > >> Eric Schulte writes: > >> > >> > Also, I think the google-wide copyright stuff is sorted out. > >> > >> Yes it is: we can accept patch from employees of Google, Inc. > >> > >> > > Good :-) > > > > > >> Pascal, I guess it's safe to assume anyone with a @google.com > >> email address is a Google employee -- let me know if it's not > >> the case. > >> > >> > > Yes, I checked internally, and this is a safe assumption. > > > > > >> Also, if you can sign your patches (git format-patch -s) that'd > >> be even better, but not mandatory. > >> > >> > > I did, also wrote the description of the patch according to the rules I > > found on orgmode.org > > > > > >> Thanks! > >> > >> -- > >> Bastien > >> > > > > > > Best regards, > > --paf > > > > -- > Eric Schulte > https://cs.unm.edu/~eschulte > PGP: 0x614CA05D > -- --paf --047d7b5d2c302558a804f712edb9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks Eric!

--pascal


On Tue, Apr 15, 2014 at= 5:35 AM, Eric Schulte <schulte.eric@gmail.com> wrote:<= br>
Pascal Fleury <fleury@google.com> writes:

> Hello,
>
> Great, thanks for the guidance. I hope I managed it all correctly.
>

I've applied this patch.

I made a couple of minor changes in a subsequent commit (a7189aa).
These were indentation and whitespace changes to enforce two coding
conventions,

1. limit line lengths to <80 characters
2. remove dangling parens on lines w/o any other text

and to rename one function to be specific to ob-shell.el.

Thanks for contributing!

>
> On Fri, Apr 11, 2014 at 11:33 AM, Bastien <bzg@gnu.org> wrote:
>
>> Hi Eric and Pascal,
>>
>> Eric Schulte <schulte= .eric@gmail.com> writes:
>>
>> > Also, I think the google-wide copyright stuff is sorted out.<= br> >>
>> Yes it is: we can accept patch from employees of Google, Inc.
>>
>>
> Good :-)
>
>
>> Pascal, I guess it's safe to assume anyone with a @google.com
>> email address is a Google employee -- let me know if it's not<= br> >> the case.
>>
>>
> Yes, I checked internally, and this is a safe assumption.
>
>
>> Also, if you can sign your patches (git format-patch -s) that'= d
>> be even better, but not mandatory.
>>
>>
> I did, also wrote the description of the patch according to the rules = I
> found on orgmode.org<= /a>
>
>
>> Thanks!
>>
>> --
>> =C2=A0Bastien
>>
>
>
> Best regards,
> --paf
>

--
Eric Schulte
https://cs.unm.e= du/~eschulte
PGP: 0x614CA05D



--
= --paf
--047d7b5d2c302558a804f712edb9--