From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id EO3eFFNEEmf0sAAA62LTzQ:P1 (envelope-from ) for ; Fri, 18 Oct 2024 11:19:47 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id EO3eFFNEEmf0sAAA62LTzQ (envelope-from ) for ; Fri, 18 Oct 2024 13:19:47 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20230601 header.b=QFlHnuco; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1729250387; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=eWZrylLxzQ1NHtKqWgYttgMr/NWYF7t5giq+xDN0E84=; b=Sj42dIsyxbTEZL3iTYMXjbFtFGWSqHHPax4v9YVrkcjoUBCilBzrRvCnL0MuOXTgH9c8ZH AhVSJaEUqIdCZ+e3EMhO+OIcPyTOeX6+TI2bU9I5O70aY9pJEJ04qdaI1qfPgi/0BLlyl4 ITzIQJl3a5uMX6bncnbOY3koBWzLKjwoGozShzeiUtnrfQ17MiGk2NN8O+x3p9k57doJcH fNx0bf4z3z/ja24VXLL7NtR7dakbEpJ9uNMVNy67vF9wEXWsdCk1XKHy/HEsclGcLdhLzZ fjTmjxuN1BCRdUOxf4Fd/J7zpFboDFniC7K8MQnlDyHqLfPz3qXlUwOljrycXg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1729250387; a=rsa-sha256; cv=none; b=VMV9mKZxkJgM3DXl5jESWfATDnh4ZuCQmPGlqsGpvv3IN8kbJuLjtOLH/vy9uX+ExLor8i ij4kEj8rATtbGHS8D8eXID0rXBHDRoRBLkQIv3SLHC9KSMk8hgdngd0IzYA/3N3mrMnkvl yqHJYsBWvMVlDRlfJD2Q2G4eoiePbQ4tF+OZ44j/++ONpboSuEijZ0aThdtTId6Cbb8I8a wklRa4ZSkwmNN2cbE+CqHVhLbAlABHuOt0ak51JPEkleoXjeG4zF2GWqpRLE4bp2TjLxku 28uZKZW8HwIZkml1vj4phOHO7IyldwEDh18Id/bk+oVsx+vmMfIlmkXVR0CF4Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20230601 header.b=QFlHnuco; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CD9227856C for ; Fri, 18 Oct 2024 13:19:46 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t1k4i-0003lh-El; Fri, 18 Oct 2024 06:19:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1k4g-0003eK-3V for emacs-orgmode@gnu.org; Fri, 18 Oct 2024 06:19:14 -0400 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t1k4e-0005WV-2Z; Fri, 18 Oct 2024 06:19:13 -0400 Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2fb5f647538so19770841fa.0; Fri, 18 Oct 2024 03:19:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729246750; x=1729851550; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=43t64/BatNeIf/7eUldRvriZZ8SlqoLiA2IVvP6nDeI=; b=QFlHnucoOtbOk/Ov5u4xExZnOngWsBwL9VQePmEtKdV9NT+ElqhJlJF6Z32dbqaPy8 3DoEBXoAZxTev7U1AWUHfA/EmBkb1pD8JR3C8RNQMNluenm/hVriUY5TatBH0jbAtaPO NCwkpYnJdN1WLPeNatQAysM23KeeVguV3sHpkLCRMwFTbnKecSU847q723fnDGl4d3cL Yc3AcdQBqoCm9xklzEAsCLsUlgPI5KBROLj/bmT7o05ISqLLHm11xnaM2bqxoibbRQx2 sTJ4+wfxKQFJS4TgpmJ5vsEShG9FmWCsPGBiu8vPEIPFYL/py9f1jstvJRzPXQBYiOEN vplw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729246750; x=1729851550; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=43t64/BatNeIf/7eUldRvriZZ8SlqoLiA2IVvP6nDeI=; b=pkbbe/0edO1sa4hI3krYx0jGHBQ5kzLhJ5lXa/oZIaM4JEcWGN0VywgCPYKH8uhfsO MruIdDXs7jy8t3YJNOOF9AeBBsOYqeD/B5sUfZp3WkjWxHU7T7sJ0lBalEOCWQHHF0c0 LAl4U/Bz2ZvHSpC2gQ5Dzi4A8omwRbuJ9IqBc/sJlohD+dv2Fob4ps+pebSL0BopxQF0 gzBiE4bTedSk5mDSbTviqk+7yWS0paKE1WR67TdYtzAW8xPGxNxoOkFDEiFjkfJ2lQuG lTAxzXjanS1K/8wyOm7Iv+RSHq/V6GpuG2MCEuOyx6SC0x3qtPuGArr+rDCLDJr8wqKq 4hCw== X-Forwarded-Encrypted: i=1; AJvYcCXGuM5KTe162Hs5peSuc/NyVH5KlMuYtpA9+hh4nbNUcuT5U3tJqK+vKqQn/+RtpKDdKnU=@gnu.org X-Gm-Message-State: AOJu0Yx7fqCtFiYWWllVtY9dSKom9k9egJF401xO7R9pofo6NNmv40Mk SDGiMPqsaAK7VcuLxgRsjWad3R0kvDia9kILElElf5xHndbdg+uImy3pEva562Sw/3yRO4/8n9c C1qKVbcZIsPMetR7I/29ik0WZtbs= X-Google-Smtp-Source: AGHT+IF3IPCiXEfMjb4cT2SYfrq5HtcFNsiFSQHOLD+1j39v8mi8KEgiQ9B6azvQy6YGiyUOzPYsDzjLO42csXFiURU= X-Received: by 2002:a05:651c:2207:b0:2f7:6062:a0a9 with SMTP id 38308e7fff4ca-2fb82b96f98mr6288731fa.7.1729246749135; Fri, 18 Oct 2024 03:19:09 -0700 (PDT) MIME-Version: 1.0 References: <87y12n6d5l.fsf@localhost> <874j5azk2p.fsf@localhost> In-Reply-To: <874j5azk2p.fsf@localhost> From: Anoop GR Date: Fri, 18 Oct 2024 15:48:56 +0530 Message-ID: Subject: Re: ob-clojure breaks tangling of comments using org-babel-tangle for clojure source code blocks To: Ihor Radchenko Cc: emacs-orgmode@gnu.org, Bastien Guerry Content-Type: multipart/mixed; boundary="000000000000362e8b0624bda2d7" Received-SPF: pass client-ip=2a00:1450:4864:20::229; envelope-from=anoopemacs@gmail.com; helo=mail-lj1-x229.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 7.32 X-Spam-Score: 7.32 X-Migadu-Queue-Id: CD9227856C X-Migadu-Scanner: mx13.migadu.com X-TUID: Rv1RStjPKFSn --000000000000362e8b0624bda2d7 Content-Type: multipart/alternative; boundary="000000000000362e880624bda2d5" --000000000000362e880624bda2d5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I have attached the patch file, created against the latest main branch. On Thu, Oct 17, 2024 at 11:28=E2=80=AFPM Ihor Radchenko wrote: > Anoop GR writes: > > >> > >> I guess that we may leave the comments intact if the code block does n= ot > >> have :var. > >> > > > > I moved the comment stripping code in org-babel-expand-body:clojure to > > follow the above idea:- > > ... > > The code look reasonable. > Would you be interested to convert it into a patch? > See https://orgmode.org/worg/org-contribute.html > > -- > Ihor Radchenko // yantar92, > Org mode contributor, > Learn more about Org mode at . > Support Org development at , > or support my work at > --000000000000362e880624bda2d5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I have attached the patch file, created against the latest= main branch.

On Thu, Oct 17, 2024 at 11:28=E2=80=AFPM Ihor Radchenko <yantar92@posteo.net> wrote:
=
Anoop GR <anoopemacs@gmail.com> writes:

>>
>> I guess that we may leave the comments intact if the code block do= es not
>> have :var.
>>
>
> I moved the comment stripping code in org-babel-expand-body:clojure to=
> follow the above idea:-
> ...

The code look reasonable.
Would you be interested to convert it into a patch?
See https://orgmode.org/worg/org-contribute.html

--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,=
or support my work at <https://liberapay.com/yantar92>
--000000000000362e880624bda2d5-- --000000000000362e8b0624bda2d7 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-ob-clojure.el-Fix-comments-getting-deleted-on-tangli.patch" Content-Disposition: attachment; filename="0001-ob-clojure.el-Fix-comments-getting-deleted-on-tangli.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_m2ekuh4h0 RnJvbSBjNWQ2NTZjMTBjNzhhMTczOGQzZGFmNTBhMGRjMGE0NmViZjNmZDNlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbm9vcCBHIFIgPGFub29wZW1hY3NAZ21haWwuY29tPgpEYXRl OiBGcmksIDE4IE9jdCAyMDI0IDE1OjMwOjU0ICswNTMwClN1YmplY3Q6IFtQQVRDSF0gb2ItY2xv anVyZS5lbDogRml4IGNvbW1lbnRzIGdldHRpbmcgZGVsZXRlZCBvbiB0YW5nbGluZyBvZgogY2xv anVyZSBzb3VyY2UgYmxvY2tzCgoqIGxpc3Avb2ItY2xvanVyZS5lbCAob3JnLWJhYmVsLWV4cGFu ZC1ib2R5OmNsb2p1cmUpOiBMZWF2ZSB0aGUKY29tbWVudHMgaW50YWN0IGlmIHRoZSBjb2RlIGJs b2NrIGRvZXMgbm90IGhhdmUgOnZhci4KClJlcG9ydGVkLWJ5OiAiQW5vb3AgRyBSIiA8YW5vb3Bl bWFjc0BnbWFpbC5jb20+Ckxpbms6IGh0dHBzOi8vbGlzdC5vcmdtb2RlLm9yZy84NzRqNWF6azJw LmZzZkBsb2NhbGhvc3QvVC8jdAoKVElOWUNIQU5HRQotLS0KIGxpc3Avb2ItY2xvanVyZS5lbCB8 IDggKysrKy0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9vYi1jbG9qdXJlLmVsIGIvbGlzcC9vYi1jbG9qdXJlLmVs CmluZGV4IDk4YTY2ZDEuLmZkYjBhNzUgMTAwNjQ0Ci0tLSBhL2xpc3Avb2ItY2xvanVyZS5lbAor KysgYi9saXNwL29iLWNsb2p1cmUuZWwKQEAgLTE1NSwyMSArMTU1LDIxIEBAIG9yIHNldCB0aGUg YDpiYWNrZW5kJyBoZWFkZXIgYXJndW1lbnQiKSkpKQogCSAocmVzdWx0LXBhcmFtcyAoY2RyIChh c3NxIDpyZXN1bHQtcGFyYW1zIHBhcmFtcykpKQogCSAocHJpbnQtbGV2ZWwgbmlsKQogCSAocHJp bnQtbGVuZ3RoIG5pbCkKLQkgOzsgUmVtb3ZlIGNvbW1lbnRzLCB0aGV5IGJyZWFrIChsZXQgWy4u Ll0gLi4uKSBiaW5kaW5ncwotCSAoYm9keSAocmVwbGFjZS1yZWdleHAtaW4tc3RyaW5nICJeWyAJ XSo7Ky4qJCIgIiIgYm9keSkpCiAJIChib2R5IChvcmctdHJpbQogCQkoY29uY2F0CiAJCSA7OyBT b3VyY2UgYmxvY2sgc3BlY2lmaWVkIG5hbWVzcGFjZSA6bnMuCiAJCSAoYW5kIChjZHIgKGFzc3Eg Om5zIHBhcmFtcykpIChmb3JtYXQgIihucyAlcylcbiIgbnMpKQogCQkgOzsgVmFyaWFibGVzIGJp bmRpbmcuCiAJCSAoaWYgKG51bGwgdmFycykgKG9yZy10cmltIGJvZHkpCi0JCSAgIChmb3JtYXQg IihsZXQgWyVzXVxuJXMpIgorICAgICAgICAgICAgICAgICAgIDs7IFJlbW92ZSBjb21tZW50cywg dGhleSBicmVhayAobGV0IFsuLi5dIC4uLikgYmluZGluZ3MKKyAgICAgICAgICAgICAgICAgICAo bGV0ICgoYm9keSAocmVwbGFjZS1yZWdleHAtaW4tc3RyaW5nICJeWyAgICBdKjsrLiokIiAiIiBi b2R5KSkpCisgICAgICAgICAgICAgICAgICAgICAoZm9ybWF0ICIobGV0IFslc11cbiVzKSIKIAkJ CSAgIChtYXBjb25jYXQKIAkJCSAgICAobGFtYmRhICh2YXIpCiAJCQkgICAgICAoZm9ybWF0ICIl UyAnJVMiIChjYXIgdmFyKSAoY2RyIHZhcikpKQogCQkJICAgIHZhcnMKIAkJCSAgICAiXG4gICAg ICAiKQotCQkJICAgYm9keSkpKSkpKQorCQkJICAgYm9keSkpKSkpKSkKICAgICA7OyBJZiB0aGUg cmVzdWx0IHBhcmFtIGlzIHNldCB0byAib3V0cHV0IiB3ZSBkb24ndCBoYXZlIHRvIGRvCiAgICAg OzsgYW55dGhpbmcgc3BlY2lhbCBhbmQganVzdCBsZXQgdGhlIGJhY2tlbmQgaGFuZGxlIGV2ZXJ5 dGhpbmcKICAgICAoaWYgKG1lbWJlciAib3V0cHV0IiByZXN1bHQtcGFyYW1zKQotLSAKMi4zNC4x Cgo= --000000000000362e8b0624bda2d7--