From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wNiDBhHR+V8oFgAA0tVLHw (envelope-from ) for ; Sat, 09 Jan 2021 15:51:45 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id MLk8AhHR+V8WcwAAbx9fmQ (envelope-from ) for ; Sat, 09 Jan 2021 15:51:45 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A3C139403A4 for ; Sat, 9 Jan 2021 15:51:44 +0000 (UTC) Received: from localhost ([::1]:53920 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kyGWl-0003j6-Kq for larch@yhetil.org; Sat, 09 Jan 2021 10:51:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54832) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kyGWP-0003io-V2 for emacs-orgmode@gnu.org; Sat, 09 Jan 2021 10:51:21 -0500 Received: from mail-ed1-f52.google.com ([209.85.208.52]:33943) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kyGWO-0000Cp-JH for emacs-orgmode@gnu.org; Sat, 09 Jan 2021 10:51:21 -0500 Received: by mail-ed1-f52.google.com with SMTP id dk8so14371002edb.1 for ; Sat, 09 Jan 2021 07:51:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M1F6KKKKbEYJ5uSu+rgTPAubb2BC+Q7fiiGbWL5M77Q=; b=iKXn2/zpsYZ9ShqHD28elTaLfwmE8LVC5HWqK2RDkdl0VKcyff5qOaoonOnCzqKDb0 wOv2ktzMa5Q60BIqN+3nFbuyrZLzxQGhnSlH47Ew3PLASeBGTojiGzy4HdYosv6eKasT 2goA6nAhzis4Qjcd3J9SyF/nq+pQNWVLa581ZzwDRt2VgRT7RDGAEm4SJbAg6X98dUfL s0JprSgwvil7JmhvgNaHjGLmXpkQtxeB9cowe5x5wM84XxzdhnLpg0keDsvwI5TdHSV3 hCCn9T4Lyg8wEdC6gWpvmolF8gopIwZ7PQz/gbgTbTtm8PEkaXatcFCh3u29BJ9geF09 klCA== X-Gm-Message-State: AOAM532kM5/cy95kwgEHQo78nW2+PzNHge/pwU7rnbQZaETkjUtDggKW C6u3x08KSz4X0eLaOSJxkg0YFfTwxPPKh2d+3hk= X-Google-Smtp-Source: ABdhPJw6Ru+X5GJGkjEH8JYU/sGxzdtlI95blJLPe8NqOxCmGF8gQnlM+9hN0MovEl5VdNnOU0dKlJAHJQ6mlcmg8Vg= X-Received: by 2002:aa7:c151:: with SMTP id r17mr8705102edp.106.1610207478653; Sat, 09 Jan 2021 07:51:18 -0800 (PST) MIME-Version: 1.0 References: <87o8hzv1e8.fsf@gmail.com> In-Reply-To: <87o8hzv1e8.fsf@gmail.com> From: ian martins Date: Sat, 9 Jan 2021 10:51:07 -0500 Message-ID: Subject: Re: [PATCH] ob-java, a proposal on import improvement To: John Herrlin Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=209.85.208.52; envelope-from=ianxm1@gmail.com; helo=mail-ed1-f52.google.com X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: org-mode-email Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.25 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=jhu.edu (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: A3C139403A4 X-Spam-Score: -2.25 X-Migadu-Scanner: scn0.migadu.com X-TUID: jewP5Ip5CYUU On Fri, Jan 8, 2021 at 11:28 AM John Herrlin wrote: > I would like to combine imports from header-args with imports from a > source block. > ... > I didnt get the to work so I made a patch. John, Sorry that wasn't working. Thanks for investigating and submitting a fix. I think the problem was that I was missing static imports, which you fixed in the first chunk of your patch. I don't think the rest of the change is necessary. Could you revert the other chunks and re-test? This works for me using master, and your patch produces nearly the same code (only import order differs): #+begin_src java :results output :imports java.util.HashMap import java.util.Map; Map hash = new HashMap<>(); hash.put("one", 1); hash.put("two", 2); System.out.println(hash); #+end_src