From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2CaqLqBRA2BjVQAA0tVLHw (envelope-from ) for ; Sat, 16 Jan 2021 20:50:40 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id nn9hKqBRA2BAPgAAbx9fmQ (envelope-from ) for ; Sat, 16 Jan 2021 20:50:40 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 28A969403D6 for ; Sat, 16 Jan 2021 20:50:40 +0000 (UTC) Received: from localhost ([::1]:36138 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0sWt-0001qz-0R for larch@yhetil.org; Sat, 16 Jan 2021 15:50:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42706) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0sW9-0001qp-Ie for emacs-orgmode@gnu.org; Sat, 16 Jan 2021 15:49:53 -0500 Received: from mail-ej1-f45.google.com ([209.85.218.45]:36573) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l0sW5-0004Kj-Nd for emacs-orgmode@gnu.org; Sat, 16 Jan 2021 15:49:53 -0500 Received: by mail-ej1-f45.google.com with SMTP id l9so12558751ejx.3 for ; Sat, 16 Jan 2021 12:49:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/u0Drb3Xn4MOZDuDqys1X1BM1KmC4hkp8m415JdDwXw=; b=NZN33ipeFoo4kmh4EdsyNDA1Q8FyQwdkpl/9YpXClM8N7jmUfzv4zj5Ew2BcdBRIjL ouIJNVkMn1IMCa0LkSZwfGAYuyzOvY0Tp3R+JxUK+oFi+j03ik4HX3WjEzHsMX31d2AJ 6BBnqmDjBmSJJkEtGBAIB4U0EAENUBR3C7VdHwIgwBNaGzrt7STu/Xuzn/9OVNJBHbYZ M3KdfB+nETp/uL/bMMK1llGq7jSRND6yzEWGtJBgy3GMmx0JKkYe8LclqfVwc4tpiTq1 vXq7gbGw8dIZkR6xgaNK/9hVkWQlpMAZoAQ49kIBGxJ0CFA9gze5r5dmMVknTS25UMDg 7NvA== X-Gm-Message-State: AOAM532rlwZOmO4W5h55uslZ3A07QJVmZ5LBc9J+5HSqV0SKBCwZDAJK aVc21RzyQvyld1S7k+g/KkQqR83l+DHYTDZr/O4= X-Google-Smtp-Source: ABdhPJx+6Tw4/zzP7V7ZeLqUCMxbCO6tDzB4Fh9CT4x6Y6mTEg6LtftFgpbreqeV4hjhKvNyOnwyXWWJopRLRYnVUcs= X-Received: by 2002:a17:906:b1c8:: with SMTP id bv8mr13192710ejb.208.1610830188252; Sat, 16 Jan 2021 12:49:48 -0800 (PST) MIME-Version: 1.0 References: <87o8hzv1e8.fsf@gmail.com> <87lfd0v7e6.fsf@gmail.com> <87wnwcq4n0.fsf@gmail.com> In-Reply-To: <87wnwcq4n0.fsf@gmail.com> From: ian martins Date: Sat, 16 Jan 2021 15:49:37 -0500 Message-ID: Subject: Re: [PATCH] ob-java, a proposal on import improvement To: John Herrlin Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=209.85.218.45; envelope-from=ianxm1@gmail.com; helo=mail-ej1-f45.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: org-mode-email Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.26 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=jhu.edu (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 28A969403D6 X-Spam-Score: -2.26 X-Migadu-Scanner: scn1.migadu.com X-TUID: CasvZJkkRUz4 It's no problem. Didn't mean to rush you. Thanks again for the patch. Applied. On Sat, Jan 16, 2021 at 10:32 AM John Herrlin wrote: > > > Sorry for latency, 9to5 been killing it. Thx for the feedback, make > sense! Here is a new patch with the improvements. > > > > ian martins writes: > > > John, would you mind if I go ahead and make the change I mentioned and > > push it with you as the author? > > > > On Tue, Jan 12, 2021 at 7:00 AM ian martins wrote: > >> > >> On Sun, Jan 10, 2021 at 3:55 PM John Herrlin wrote: > >> > ian martins writes: > >> > > I think the problem was that I was missing static > >> > > imports, which you fixed in the first chunk of your patch. I don't > >> > > think the rest of the change is necessary. Could you revert the other > >> > > chunks and re-test? > >> > > >> > Thats looks correct! Thanks! > >> > > >> > Here is a patch with the regexp fix. > >> > >> That's great. One small change, though. This only allows for a single > >> space between "import" and "static" so if someone were to put in two > >> it wouldn't work. I actually did the same thing in an earlier version > >> and it caused a problem. Since then I went to =(1+ space)= > >> everywhere. Could you also move the part that you're adding down to > >> the next line. It's not that the line is too long, but it keeps it to > >> one thing per line. > >> > >> The commit message is fine, but the first line shouldn't end in a period. > >> > >> ref: https://orgmode.org/worg/org-contribute.html#commit-messages