From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id kAOrAtLvUF+8TQAA0tVLHw (envelope-from ) for ; Thu, 03 Sep 2020 13:29:54 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id WOQ4OtHvUF+heQAAbx9fmQ (envelope-from ) for ; Thu, 03 Sep 2020 13:29:53 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AA8609403C8 for ; Thu, 3 Sep 2020 13:29:52 +0000 (UTC) Received: from localhost ([::1]:33016 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDpJH-00064H-L6 for larch@yhetil.org; Thu, 03 Sep 2020 09:29:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDpIt-00060W-61 for emacs-orgmode@gnu.org; Thu, 03 Sep 2020 09:29:27 -0400 Received: from mail-ej1-f43.google.com ([209.85.218.43]:47086) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kDpIp-0007Vx-Vv for emacs-orgmode@gnu.org; Thu, 03 Sep 2020 09:29:26 -0400 Received: by mail-ej1-f43.google.com with SMTP id z23so3813379ejr.13 for ; Thu, 03 Sep 2020 06:29:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1aEkIdGKQzwkkHANSYkhdwz+B3CyDT68fCV0jh0bRl4=; b=RsBHHaMVGSW/v1KWdvka5EurGPIVdz2OPphk7Q6cGhCzSO4qQnVEsxz/KyBm81pIcI 6u6MujxQNxtDO7C1H04hQNl8AJFRiDmjYHZqrPHsFFVskKiGoq0ur35kZf3O0E0BfWCf BnuiUYGkLlYESIr3dHCU9nSBEKCZhW8qEoLYeLyd1PiM14Zx0XqVQY9U/Kr91kX7ctrp PwS9VsZpKaoSuZpm9fsIiA58vZ5mT7dsh8Kk1nM8gvzUUSLT9bF0LMIn2Y0zNPONXcGy 8Y3k2h6N6zuZD5gIDAIb0VVtryheRLA8l59BCGgSjSDSVefvmMQSflS2/shMQ6IAyd1z UR0A== X-Gm-Message-State: AOAM530sM8mtc2XzqSfllYjKKInQEzp41nNPiBga9sBcgPFoCz7A8KvR jh/N9Yk1HJeII6Te8R6IqzAhk06NXx2EZRt4PtyY1hUlejE= X-Google-Smtp-Source: ABdhPJzeU5+qYxAPSTD3A9vHdI5u0ywEQs4w7DNEEue2XoNqKEG4yZiTBbL2Cha2wEjoMqfAl/iH02FZzycaFcDSeak= X-Received: by 2002:a17:906:2858:: with SMTP id s24mr2005264ejc.399.1599139761085; Thu, 03 Sep 2020 06:29:21 -0700 (PDT) MIME-Version: 1.0 References: <87wo1bfoh0.fsf@kyleam.com> In-Reply-To: <87wo1bfoh0.fsf@kyleam.com> From: ian martins Date: Thu, 3 Sep 2020 09:29:09 -0400 Message-ID: Subject: Re: ob-java and ob-haxe To: Kyle Meyer Content-Type: multipart/alternative; boundary="00000000000067e00e05ae68bd3c" Received-SPF: pass client-ip=209.85.218.43; envelope-from=ianxm1@gmail.com; helo=mail-ej1-f43.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/03 09:29:21 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Org-Mode mailing list Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=jhu.edu (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.91 X-TUID: 8OFLNx/IWelp --00000000000067e00e05ae68bd3c Content-Type: text/plain; charset="UTF-8" That is understandable; they're big patches. I recommend going over ob-java first. Java is probably more familiar to you and ob-java and ob-haxe are very similar. These were mostly based on ob-python and ob-C. The tests are based on ob-Cs tests. Look carefully at org-babel-temp-dir and org-babel-remove-temporary-directory. The patches override core but ideally these would be changes in core. I was hesitant to put these in ELPA because then the tests won't run when org-mode is modified. On Thu, Sep 3, 2020 at 12:56 AM Kyle Meyer wrote: > ian martins writes: > > > I posted patches for ob-java and ob-haxe a couple months ago but there > was > > no interest. I have been given access to push to contrib. If there's no > > objection I'll put them there. > > > > I'll rename my version ob-java-alt so it doesn't conflict with the > official > > one. The contrib directory doesn't have a "testing" directory so I'll add > > one. I'll document them in worg. > > My understanding is that there's been a move away from adding new > libraries to contrib/, instead preferring an ELPA for cases where core > isn't deemed appropriate. > > Fixes and enhancements to ob-java are obviously appropriate for core. > And while it'd be fine to host ob-haxe separately, my impression is that > it too would be suitable for core. > > I'm sorry your patches haven't gotten any reviews or other feedback. > I've sat down a couple of times to review the ob-haxe patch but haven't > ended up blocking off enough time to get anywhere. I'll revisit it this > weekend. Of course, any feedback from those that actually use haxe > would be appreciated. > > --00000000000067e00e05ae68bd3c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
That is understandable; they're big patches. I re= commend going over ob-java first. Java is probably more familiar to you and= ob-java and ob-haxe are very similar. These were mostly based on ob-python= and ob-C. The tests are based on ob-Cs tests.

Look carefully at org-babel-temp-dir and org-babel-remove-temporary-direct= ory. The patches override core but ideally these would be changes in core.<= br>

I was hesitant to put these in ELPA because th= en the tests won't run when org-mode is modified.

<= /div>
O= n Thu, Sep 3, 2020 at 12:56 AM Kyle Meyer <kyle@kyleam.com> wrote:
ian martins writes:

> I posted patches for ob-java and ob-haxe a couple months ago but there= was
> no interest. I have been given access to push to contrib. If there'= ;s no
> objection I'll put them there.
>
> I'll rename my version ob-java-alt so it doesn't conflict with= the official
> one. The contrib directory doesn't have a "testing" dire= ctory so I'll add
> one. I'll document them in worg.

My understanding is that there's been a move away from adding new
libraries to contrib/, instead preferring an ELPA for cases where core
isn't deemed appropriate.

Fixes and enhancements to ob-java are obviously appropriate for core.
And while it'd be fine to host ob-haxe separately, my impression is tha= t
it too would be suitable for core.

I'm sorry your patches haven't gotten any reviews or other feedback= .
I've sat down a couple of times to review the ob-haxe patch but haven&#= 39;t
ended up blocking off enough time to get anywhere.=C2=A0 I'll revisit i= t this
weekend.=C2=A0 Of course, any feedback from those that actually use haxe would be appreciated.

--00000000000067e00e05ae68bd3c--