From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id IB7iL8rHlF/YDgAA0tVLHw (envelope-from ) for ; Sun, 25 Oct 2020 00:33:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id gBzOK8rHlF8qSQAA1q6Kng (envelope-from ) for ; Sun, 25 Oct 2020 00:33:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7234A940111 for ; Sun, 25 Oct 2020 00:33:12 +0000 (UTC) Received: from localhost ([::1]:48484 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWTyA-0000OG-Lt for larch@yhetil.org; Sat, 24 Oct 2020 20:33:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36494) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWTwH-0000Ma-2P for emacs-orgmode@gnu.org; Sat, 24 Oct 2020 20:31:14 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:38122) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kWTwD-0003i8-Rd; Sat, 24 Oct 2020 20:31:12 -0400 Received: by mail-ed1-f67.google.com with SMTP id bc23so5626580edb.5; Sat, 24 Oct 2020 17:31:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XvLs4nWwTmmmSnjZgJhvBg+kxnNVlBHD6IIsg7sa21c=; b=epZw8zH9J4GP1glMRUdI1psLTMYwheQkpcvrumv5Jbr64VE4FR7UcMv1TJLjqmj09/ nJc+LdgHPeOkSeNPpCKjWJZlZ3ITnkmQtESSc0Q16MmFo6O/jlYuCQV1U8+S7M/ohSzV rrRNreEbko8bFCHzezsssoBWB0/wS+Jvg4zcqs4a5a7G/s9hEc+q2PFkDj6RSEL1VpUF WSbBoAUC0wJSLMniTRt/Aq6qsVJ1Dh8z3D8/b0tojQ8o7jJa4Fh2RF30igGNsk9idUgU yiIWOpIlx+x9nv5l3sx1MguNMLTWppAjaqMAIetinuFecuHiiEnY9I9UbB0Yak3lRny1 RRmA== X-Gm-Message-State: AOAM530YogURD0rW+tn8Krqan+O6lOa+hff1RyvDOL+8Z5X04Xi93gLh eajy9ggE71BJ5lBOOUGor6lhsc6umrwykK2Ozgka5dVqi70FuQ== X-Google-Smtp-Source: ABdhPJzr+zWQUn4dfMnULkbiE69A4HQzVNVyif+XpsKefJufY5KsIBLaXKPm2hBIje1G+cTKvlYS37Dx39vkEY9436c= X-Received: by 2002:a50:8adb:: with SMTP id k27mr9186723edk.254.1603585866095; Sat, 24 Oct 2020 17:31:06 -0700 (PDT) MIME-Version: 1.0 References: <87tuujltsh.fsf@gnu.org> In-Reply-To: <87tuujltsh.fsf@gnu.org> From: ian martins Date: Sat, 24 Oct 2020 20:30:54 -0400 Message-ID: Subject: Re: [PATCH] ob-java To: Bastien Content-Type: multipart/alternative; boundary="000000000000ea620f05b273ed89" Received-SPF: pass client-ip=209.85.208.67; envelope-from=ianxm1@gmail.com; helo=mail-ed1-f67.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/24 20:31:06 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Org-Mode mailing list Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=jhu.edu (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.91 X-TUID: pv5OH9umQVZQ --000000000000ea620f05b273ed89 Content-Type: text/plain; charset="UTF-8" This happened because the new ob-java wasn't based on the old ob-java. I wrote ob-haxe based on ob-C and ob-python and then derived ob-java from ob-haxe. I went back and forth about who should be the author of ob-haxe. I considered listing the authors of ob-C and ob-python, but I thought it wouldn't make sense since they may not have heard of haxe, and they may not like my code or want their names on it. I didn't really think about the author of the new ob-java, since it came directly from ob-haxe. But I want to follow your conventions. I will put the authors of ob-C and ob-python (Eric Schulte and Dan Davison) as the authors of ob-java and ob-haxe. The implementations are nearly the same. it wouldn't make sense for them to have different authors. On Sat, Oct 24, 2020 at 7:58 AM Bastien wrote: > Hi Ian, > > feel free to install the patch when you think it's ready. > > One minor nitpick: > > -;; Author: Eric Schulte > -;; Maintainer: Ian Martins > +;; Author: Ian Martins > > I suggest you leave Eric Schulte as the author while adding yourself > as the maintainer, even if the "change" is a big rewrite. > > Thanks, > > -- > Bastien > --000000000000ea620f05b273ed89 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
This happened because the new ob-java wasn't base= d on the old ob-java. I wrote ob-haxe based on ob-C and ob-python and then = derived ob-java from ob-haxe.=C2=A0 I went back and forth about who should = be the author of ob-haxe. I considered listing the authors of ob-C and ob-p= ython, but I thought it wouldn't make sense since they may not have hea= rd of haxe, and they may not like my code or want their names on it. I didn= 't really think about the author of the new ob-java, since it came dire= ctly from ob-haxe.

But I want to follow your conve= ntions. I will put the authors of ob-C and ob-python (Eric Schulte and Dan = Davison) as the authors of ob-java and ob-haxe. The implementations are nea= rly the same. it wouldn't make sense for them to have different authors= .

On Sat, Oct 24, 2020 at 7:58 AM Bastien <bzg@gnu.org> wrote:
Hi Ian,

feel free to install the patch when you think it's ready.

One minor nitpick:

-;; Author: Eric Schulte
-;; Maintainer: Ian Martins <ianxm@jhu.edu>
+;; Author: Ian Martins <ianxm@jhu.edu>

I suggest you leave Eric Schulte as the author while adding yourself
as the maintainer, even if the "change" is a big rewrite.

Thanks,

--
=C2=A0Bastien
--000000000000ea620f05b273ed89--