with ob-java I assumed I shouldn't change ob-core, so I advised/overrode ob-core instead of changing it. But it would be much better to change ob-core. I'll submit those changes as a separate patch that modifies ob-core.

On Sun, Sep 13, 2020 at 4:04 PM Kyle Meyer <kyle@kyleam.com> wrote:

ian martins writes:

> ob-haxe and ob-java both involve a few changes to ob-core to allow temp
> directories instead of just temp files. Should I submit that as a separate
> patch?

It looks like that change is included with your ob-java patch [0], which
will be considered after 9.4 is released [1], so I think it's fine as
is. (In my opinion, splitting up that patch would have been nice, but I
don't think it's worth a reroll, at least until some initial comments
come in.)

[0] https://orgmode.org/list/CAC=rjb7AhmnRQ9Nc4Ao07qK3QZF4LVaTmU_R1fWqr+97NpnRJQ@mail.gmail.com
[1] https://orgmode.org/list/87sgbwgvx6.fsf@gnu.org