From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2HzYHSuQ/V9cdwAA0tVLHw (envelope-from ) for ; Tue, 12 Jan 2021 12:03:55 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id SJmHGSuQ/V+WegAAbx9fmQ (envelope-from ) for ; Tue, 12 Jan 2021 12:03:55 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D15529401C0 for ; Tue, 12 Jan 2021 12:03:54 +0000 (UTC) Received: from localhost ([::1]:32782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzIOu-0008E5-5G for larch@yhetil.org; Tue, 12 Jan 2021 07:03:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzILg-0006nq-Hh for emacs-orgmode@gnu.org; Tue, 12 Jan 2021 07:00:35 -0500 Received: from mail-ed1-f43.google.com ([209.85.208.43]:35338) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kzILe-0003me-Nc for emacs-orgmode@gnu.org; Tue, 12 Jan 2021 07:00:32 -0500 Received: by mail-ed1-f43.google.com with SMTP id u19so2023550edx.2 for ; Tue, 12 Jan 2021 04:00:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HUrUKXNYl7oLBx289quHJoGZtUQnqpezTCCH9iq9jQE=; b=JQS1Na3Fghg8PdcVco99l/8thxHOfADA+toKMdYojp6ezXPAvjQvMxgCsTdQl29HFw llzrmlkSFKaLgRq8BHtgkr+eonjJZDU4SfTXPFGs3wmLQ7+z7zusI0Qa1gT8FYiEEOO4 oeNl14++rYjzs7dLC8wGJal9zIiMujIGT3E6fcL1q8CSimaN/IKIfL/59/iRb8U2JRVQ nGUo6c9gqjlh6DL1u7uC6F/VTn4deu+Y++1sA8E+OOEwJXrJoUq47W2EgxM/qYqd/mFZ jYK3KvSpwlfJ8njdcFN1TVWsRAAXhlCBVsVB9A7V6SHfLdPnezQPed5//rZm1ewMY6Te yRVA== X-Gm-Message-State: AOAM531e1cgAkdZ+6ktFvOfrRwZ2h7uDruKImNxJ2WlhFRjRbYkkIUTs FJJVBSS/uQFgr53xLJpg0YtmX4LtFKnSspu8KE4= X-Google-Smtp-Source: ABdhPJxLkeITEDYeiYkF6BQPnQWZTzPmtWbvPuCksh424gI0OCf45TpHMwOLqG5IWcLPxHmhlVGsKOK839GnFMhWLZo= X-Received: by 2002:a50:e719:: with SMTP id a25mr3112714edn.12.1610452828539; Tue, 12 Jan 2021 04:00:28 -0800 (PST) MIME-Version: 1.0 References: <87o8hzv1e8.fsf@gmail.com> <87lfd0v7e6.fsf@gmail.com> In-Reply-To: <87lfd0v7e6.fsf@gmail.com> From: ian martins Date: Tue, 12 Jan 2021 07:00:17 -0500 Message-ID: Subject: Re: [PATCH] ob-java, a proposal on import improvement To: John Herrlin Content-Type: multipart/alternative; boundary="000000000000c5ce5a05b8b2c4b1" Received-SPF: pass client-ip=209.85.208.43; envelope-from=ianxm1@gmail.com; helo=mail-ed1-f43.google.com X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: org-mode-email Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.26 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=jhu.edu (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: D15529401C0 X-Spam-Score: -2.26 X-Migadu-Scanner: scn0.migadu.com X-TUID: PIGrSb3x5dLx --000000000000c5ce5a05b8b2c4b1 Content-Type: text/plain; charset="UTF-8" On Sun, Jan 10, 2021 at 3:55 PM John Herrlin wrote: > ian martins writes: > > I think the problem was that I was missing static > > imports, which you fixed in the first chunk of your patch. I don't > > think the rest of the change is necessary. Could you revert the other > > chunks and re-test? > > Thats looks correct! Thanks! > > Here is a patch with the regexp fix. That's great. One small change, though. This only allows for a single space between "import" and "static" so if someone were to put in two it wouldn't work. I actually did the same thing in an earlier version and it caused a problem. Since then I went to =(1+ space)= everywhere. Could you also move the part that you're adding down to the next line. It's not that the line is too long, but it keeps it to one thing per line. The commit message is fine, but the first line shouldn't end in a period. ref: https://orgmode.org/worg/org-contribute.html#commit-messages --000000000000c5ce5a05b8b2c4b1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sun, Jan 10, 2021 at 3:55 PM John Herrlin <jherrlin@g= mail.com> wrote:
> ian martins <ianxm@jhu.edu> writes:
> > I think the problem was that I was missing static
> > imports, which you fixed in the first chunk of your patch. I don&= #39;t
> > think the rest of the change is necessary. Could you revert the o= ther
> > chunks and re-test?
>
> Thats looks correct! Thanks!
>
> Here is a patch with the regexp fix.

That's= great. One small change, though. This only allows for a single space betwe= en "import" and "static" so if someone were to put in t= wo it wouldn't work. I actually did the same thing in an earlier versio= n and it caused a problem. Since then I went to =3D(1+ space)=3D everywhere= . Could you also move the part that you're adding down to the next line= . It's not that the line is too long, but it keeps it to one thing per = line.

The commit message is fine, but the first line shouldn't end in a perio= d.

--000000000000c5ce5a05b8b2c4b1--