From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nathan Neff Subject: Re: Helm + Org-mode 9.2.5: Problem with org-set-tags Date: Sat, 10 Aug 2019 18:32:30 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000004eb5fd058fcbb5ef" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:42609) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hwaqv-0006j5-IK for emacs-orgmode@gnu.org; Sat, 10 Aug 2019 19:32:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hwaqu-0007Cf-0d for emacs-orgmode@gnu.org; Sat, 10 Aug 2019 19:32:49 -0400 Received: from mail-ot1-x343.google.com ([2607:f8b0:4864:20::343]:42768) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hwaqt-0007C3-RY for emacs-orgmode@gnu.org; Sat, 10 Aug 2019 19:32:47 -0400 Received: by mail-ot1-x343.google.com with SMTP id j7so1748040ota.9 for ; Sat, 10 Aug 2019 16:32:47 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode --0000000000004eb5fd058fcbb5ef Content-Type: text/plain; charset="UTF-8" I think I found the problem and have a fix! Long story short, I modified my helm-completing-read-handlers-alist and added an entry: (add-to-list 'helm-completing-read-handlers-alist `(org-set-tags-command . helm-org-completing-read-tags) ) I have all the gory details here: https://github.com/emacs-helm/helm/issues/2183 Thanks all for your help, hope this helps someone else too :) --Nate On Sat, Aug 10, 2019 at 4:01 PM Nathan Neff wrote: > > > On Sat, Aug 10, 2019 at 3:44 PM Nathan Neff wrote: > >> Hello all, >> >> I created a VM, installed Emacs 26.2 fresh, and installed various versions >> of org-mode using the tar.gz files from https://orgmode.org/ >> >> I replaced org-mode in /usr/share/emacs/26.2/lisp/org with various older >> versions until I found the version of org-mode that breaks the helm tags >> completion. >> >> I found that the latest version of org where the feature works is >> Org-mode version 9.1.9. >> > > Oops - my aplogies - I assumed that the org-versions stopped at 9.1.9. I > tested Org 9.1.14 which (to > my knowledge) is the last of the 9.1.X versions, and Org 9.1.14 works > correctly. > > I tested Org version 9.2 and Org version 9.2 is the version that breaks > the tags functionality > from Helm. > > > >> I will spelunk around in the code to see what might have changed the >> behavior - if anyone has >> suggestions or doesn't have this problem with an older version of org, >> please let me know - it could >> easily be something that I have set incorrectly. >> >> Thanks, >> --Nate >> >> >> >> >> >> >> >> On Fri, Aug 9, 2019 at 4:28 PM Nathan Neff wrote: >> >>> Hello all, >>> >>> I'm hitting this problem with Org-mode 9.2.5: >>> https://groups.google.com/forum/#!topic/emacs-helm/tA6cn6TUdRY >>> >>> Problem synopsis: When I use org-set-tags on a heading >>> with no tags, Helm gives me the correct prompt w/a list of all my tags. >>> After I have entered a single tag, then no more Helm suggestions are >>> offered. This is the bug, and it was fixed at some point. >>> >>> Helm + org-mode *work correctly* when I run emacs using >>> the elpa/helm-20190726/emacs-helm.sh script which comes with Helm >>> for debugging purposes. I notice that the org-version in the *working* >>> example >>> is 9.1.9 (which is, I presume) the stock org-mode that comes with Emacs. >>> >>> I have reproduced this problem on both Linux and OSX. >>> >>> Can anyone suggest a next step to take? >>> >>> Thanks, >>> --Nate >>> >>> --0000000000004eb5fd058fcbb5ef Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I think I found the problem and have a fix!
=

Long story short, I modified my helm-completing-read-ha= ndlers-alist
and added an entry:
(add-to-list '= helm-completing-read-handlers-alist
=C2=A0 =C2=A0 `(org-set-tags-comman= d . helm-org-completing-read-tags)
)

I have all= the gory details here:
<= div>
Thanks all for your help, hope this helps someone else t= oo :)
--Nate



On= Sat, Aug 10, 2019 at 4:01 PM Nathan Neff <nathan.neff@gmail.com> wrote:


On S= at, Aug 10, 2019 at 3:44 PM Nathan Neff <nathan.neff@gmail.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">
Hell= o all,

I created a VM, installed Emacs 26.2 fresh,= and installed various versions
of org-mode using the tar.gz file= s from https://orgmode.o= rg/

I replaced org-mode in /usr/share/emacs/26= .2/lisp/org with various older
versions until I found the version= of org-mode that breaks the helm tags completion.

I found that the latest version of org where the feature works is Org-mode= version 9.1.9.

Oops - my aplog= ies - I assumed that the org-versions stopped at 9.1.9.=C2=A0 I tested Org = 9.1.14 which (to
my knowledge) is the last of the 9.1.X versions,= and Org 9.1.14 works correctly.

I tested Org = version 9.2 and Org version 9.2 is the version that breaks the tags functio= nality
from Helm.



= I will spelunk around in the code to see what might have changed the behavi= or - if anyone has
suggestions or doesn't have this problem w= ith an older version of org, please let me know - it could
easily= be something that I have set incorrectly.

Thanks,=
--Nate







On Fri, Aug 9, 2019 at 4:28 PM Nathan Neff &= lt;nathan.neff@g= mail.com> wrote:
Hello all,

I'm h= itting this problem with Org-mode 9.2.5:
https://groups.google.com/forum/#!topic/emacs-helm/tA6cn6TUdRY

Problem synopsis:=C2=A0 When I use org-set-tags on a = heading
with no tags, Helm gives me the correct prompt w/a list o= f all my tags.
After I have entered a single tag, then= no more Helm suggestions are
offered.=C2=A0 This is the bug, and= it was fixed at some point.

Helm + org-mode *= work correctly* when I run emacs using
the elpa/helm-20190726/ema= cs-helm.sh script which comes with Helm
for debugging purpos= es.=C2=A0 I notice that the org-version in the *working* example
= is 9.1.9 (which is, I presume) the stock org-mode that comes with Emacs.

I have reproduced this problem on both Linux and OSX= .

Can anyone suggest a next step to take?

Thanks,
--Nate

--0000000000004eb5fd058fcbb5ef--