From: Yuri Lensky <ydlensky@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: org mode <emacs-orgmode@gnu.org>, Oleh Krehel <ohwoeowho@gmail.com>
Subject: Re: Commit "org-agenda: Support for dimming..." breaks agenda display
Date: Mon, 7 Aug 2017 02:31:07 -0400 [thread overview]
Message-ID: <CAC38U-e5Qs3QfxTfsk9gDbyJMoSoa8mTpyxUoV4J3dSSyXsryA@mail.gmail.com> (raw)
In-Reply-To: <8760e1f7u9.fsf@nicolasgoaziou.fr>
[-- Attachment #1.1: Type: text/plain, Size: 959 bytes --]
Hi,
I have a attached a patch to fix this bug. As can be seen from the patch,
the problem was improperly balanced parenthesis in
`org-agenda--mark-blocked-entry' which caused the function to return 'nil
unless the entry passed to it had the todo-state text property, whereas the
proper behavior is to always return the entry in some form.
Apologies for carelessness and introducing the bug,
YL
On Sun, Aug 6, 2017 at 3:55 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:
> Hello,
>
> Oleh Krehel <ohwoeowho@gmail.com> writes:
>
> > I updated Org recently and noticed that the agenda display looks very
> > broken, especially in `org-agenda-log-mode'.
> >
> > I did a bisect; reverting commit
> > 912a385518bcf2e320cc161d573ad329111de6c7 fixes it.
> > Anyone else have this problem?
>
> Confirmed. See also
> <http://lists.gnu.org/archive/html/emacs-orgmode/2017-08/msg00134.html>.
>
> I'm Cc'ing Yuri about it.
>
> Regards,
>
> --
> Nicolas Goaziou
>
[-- Attachment #1.2: Type: text/html, Size: 1655 bytes --]
[-- Attachment #2: 0001-lisp-org-agenda.el-Properly-return-all-entries-from-.patch --]
[-- Type: application/octet-stream, Size: 995 bytes --]
From b942de6e68836953b7c168fa1b783a87b8c6bf42 Mon Sep 17 00:00:00 2001
From: "Yuri D. Lensky" <ydlensky@gmail.com>
Date: Mon, 7 Aug 2017 02:12:26 -0400
Subject: [PATCH] lisp/org-agenda.el: Properly return all entries from blocked
marking
* lisp/org-agenda.el (org-agenda--mark-blocked-entry): Always return
the entry passed to `org-agenda--mark-blocked-entry' (previously
returned nil if entry did not have todo-state text property).
---
lisp/org-agenda.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 1355023..c8097de 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -3930,8 +3930,8 @@ to t."
(put-text-property
0 (length entry) 'org-todo-blocked
(if really-invisible 'invisible t)
- entry))))))
- entry))
+ entry)))))))
+ entry)
(defvar org-agenda-skip-function nil
"Function to be called at each match during agenda construction.
--
2.9.2.windows.1
next prev parent reply other threads:[~2017-08-07 6:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 19:34 Commit "org-agenda: Support for dimming..." breaks agenda display Oleh Krehel
2017-08-06 7:55 ` Nicolas Goaziou
2017-08-07 6:31 ` Yuri Lensky [this message]
2017-08-07 8:55 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAC38U-e5Qs3QfxTfsk9gDbyJMoSoa8mTpyxUoV4J3dSSyXsryA@mail.gmail.com \
--to=ydlensky@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
--cc=ohwoeowho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).