From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id OEXwKGsfNWTXcgAASxT56A (envelope-from ) for ; Tue, 11 Apr 2023 10:50:51 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 8OvxJ2sfNWSIqgAAG6o9tA (envelope-from ) for ; Tue, 11 Apr 2023 10:50:51 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2FD02FDBC for ; Tue, 11 Apr 2023 10:50:51 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pm9hF-0000ns-PW; Tue, 11 Apr 2023 04:49:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pm9hC-0000nJ-4N for emacs-orgmode@gnu.org; Tue, 11 Apr 2023 04:49:47 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pm9h7-0002k1-UH for emacs-orgmode@gnu.org; Tue, 11 Apr 2023 04:49:45 -0400 Received: by mail-wm1-x32f.google.com with SMTP id n19-20020a05600c501300b003f064936c3eso8888963wmr.0 for ; Tue, 11 Apr 2023 01:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681202977; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=xfbTjXCxz3dRhdFxxkvZXLXgbMsqfI10Y6UnMrlvKTg=; b=EvrY6MFVwb6Mtw5T0BcaMSmKhSSsCFuLjwmEEQu57d16OSybG+X7Carmnjcn2hiLRk HY1NuNOQ9J0jjUwG3/I7kW6hVAe8G2fs/rWR8yBSAgD+7LglafDlaZwRJG13YX4Y0M1U IeH//Q6n58s7JGRnGpOAJXc9/fPwzBRL7Q2yDwNO/0bF8TjD9gIKEXC6ByHOeNB+GlDS pi+/nnCSWrtRD/x6S9LjzdljeJ7BurDNCT+hAJtX2/rVYRn5Wuxu99yWKuZYfTvtCMN+ cIt3K4VeArlb9ojFZxoxjyXOThpi8bqL35Xrlpfb0wmJDUdXS82iJ5xIcC8L0/uL4ELm qBHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681202977; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xfbTjXCxz3dRhdFxxkvZXLXgbMsqfI10Y6UnMrlvKTg=; b=NpgW5zOU6JchllFsRE7q9UV/4MQxaPtexoaXAmjvQueFKZC/fzTbIOnqedQhZtxW8/ C6vCUXBGBBlhFiO/c/j8NHJ+wAqQpgT49EGeEG7l5VRS7X7Vvww/YjoZpGztZ0A7Z8ux wd70pilEKdlCHUPCnGEV941S9EAWLj+2pG7TERfWaRkaRAPqwlSC87a9NmzLYoYqvXB9 fcRrHmcWIFJ7PfV2Wg+DULTtAecfmtAUhohMRivXu+rMmwVAo6v+ZT3Kp56KPtMS26p/ yYD8n2Du7gR2L0rkEyc5+eJ+8yfvrgFLuFqVWiQ6tvnstNtiYI9JTymSvGqW2TIqx0/C ckWg== X-Gm-Message-State: AAQBX9dEqUHHLEWdAJI7trlVgwTyjpeKYnHmgcJ1lFhy5axRVVp7Z9Wq aEsTMebaD+5WCSQf5YG7WaqQ4XtOnTactNKtXqO3dgsvs+E= X-Google-Smtp-Source: AKy350bICaU7bjGmcqy1oNF2hQOtkimVvoOOpTtICdQIShu081XcAcEO5vz+UxXmJGOPnp7QAFzZ1KxJ29UeKi7eSlA= X-Received: by 2002:a05:600c:3b25:b0:3ef:6989:19d4 with SMTP id m37-20020a05600c3b2500b003ef698919d4mr4358476wms.0.1681202977033; Tue, 11 Apr 2023 01:49:37 -0700 (PDT) MIME-Version: 1.0 References: <87lej51frx.fsf@gmail.com> <87355ckl7d.fsf@localhost> <877culo1pb.fsf@localhost> In-Reply-To: <877culo1pb.fsf@localhost> From: =?UTF-8?Q?S=C5=82awomir_Grochowski?= Date: Tue, 11 Apr 2023 10:49:24 +0200 Message-ID: Subject: Re: [RFC] [feat] org-colview/org-columns: 'column view' moving rows up/down To: emacs-orgmode@gnu.org Content-Type: multipart/alternative; boundary="0000000000003dd77005f90b9219" Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=slawomir.grochowski@gmail.com; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1681203051; a=rsa-sha256; cv=none; b=ex3/PnIbNyNiRr06BGd1dpQ8pdfD6nl+cvrjocCEpu45zYOvApLwfQT19I/jzlbHoGgZ2+ niL8gkMHU4fA/36hxfb2/Us0cjQWntFVSmMPSZKUbGXGvTXwren+J9IoNk6LZV4B7CQkvs kBmtoAqMdT7UZHRT8JDdDFTqOMMUD7o/OPrglDuhkZpeYLfSpG0l8wLiDxjsYpQU/ayEIz fxMeW0brdlgvmi8wQ+a6po4fz98bqJlGzze3kA42tppDk9a5yyJbHysqqf6l9E+4no997O 2L0KpsZneytM53YGu59mKi/05b+GMwF6eXrB1ydOS8IO/JGuTeoa/z4l89SkaQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=EvrY6MFV; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1681203051; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=xfbTjXCxz3dRhdFxxkvZXLXgbMsqfI10Y6UnMrlvKTg=; b=JK6XfIB+520be+qbwrfGza4X/NG0LJteM2Yj53MfmmrABqQlcuCOyBP4V331LCaXvlYrEp mrAKRAr22X8/+ipt4stdx8Ss/XxnvHed0dM3G4s1NQNjrs3apT8Sw/YLwXgA+6jzVBVjH8 YyDaAFSRVuW1dd4AEOFaD9j0czfZ3vGijuSIUmZxN7dbguMX6VpD1j1/uXrOQRF6c/AIFA pKSyYvZO8n4nAvikSXCBDA5mJdzcfPcB8Izcm706rQdrb/+40ZknWxEwuoWdPlc0rPHcZW jgCLpxHVMqIhrVnMRrtyu3rzOzWVFjMba/U70C7/0pO7LZmbGzqzwmVIElBRfA== Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=EvrY6MFV; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -7.55 X-Spam-Score: -7.55 X-Migadu-Queue-Id: 2FD02FDBC X-TUID: y9NT8EZvJgbJ --0000000000003dd77005f90b9219 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thank you Ihor for finding such an important bug. I've tried to pinpoint it. I think it happens only when: first heading (row) is the first line of the buffer. To reproduce it: * a * b * c C-u C-c C-x C-c =3D> runs `org-columns' with global argument. Using a keyboard. Press M-, M-, M-. Heading 'a' will disappear. I've tried to create a test based on that behaviour, but can't reproduce this bug in test env. Also I can't reproduce this when I'm invoking the commands directly from M-x. As I understand it something with overlay. Which try to jump before the first line of the buffer. And that makes some kind of overflow? I will try to simplify the example and create a simple overlay without org-columns. If anyone has some ideas how to debug it I will be grateful for the hints. On Sun, Apr 9, 2023 at 11:13=E2=80=AFAM Ihor Radchenko wrote: > S=C5=82awomir Grochowski writes: > > > Thank you Ihor for the code review. > > Now please help me find everything that can be improved in this patch. > > I just tried to use the patch using the following test case: > > 1. Create a new Org file containing > > * A > * B > * C > ** C1 > * D > > 2. C-u C-c C-x C-c > 3. M-< > 4. M- M- M- M- M- M- M- M- C-c C-= c > 5. Observe text disappearing and columns being unhighlighted. At the > end, the buffer is left with > > * B > > >> Finally, I see no records about you copyright assignment status. > >> Please take a look at > >> https://orgmode.org/worg/org-contribute.html#copyright > >> > > > > Yes, it's my first time. I sent an email to assign@gnu.org, yesterday. > > Note that they should reply within 5 working days. > > -- > Ihor Radchenko // yantar92, > Org mode contributor, > Learn more about Org mode at . > Support Org development at , > or support my work at > --0000000000003dd77005f90b9219 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thank you Ihor for finding such an important bug.

I've tried to pinpoint it.
I think it happens only = when: first heading (row) is the first line of the buffer.
To reproduce = it:
* a
* b
* c

C-u C-c C-x C-c =3D> runs `org-columns= ' with global argument.
Using a keyboard. Press M-<down>, M-&l= t;down>, M-<up>.
Heading 'a' will disappear. =C2=A0
=
I've tried to create a test based on that behaviour, but can't = reproduce this bug in test env.
Also I can't reproduce this when I&#= 39;m invoking the commands directly from M-x.
As I understand it somethi= ng with overlay. Which try to jump before the first line of the buffer.
= And that makes some kind of overflow?
I will try to simplify the example= and create a simple overlay without org-columns.
If anyone has some ide= as how to debug it I will be grateful for the hints.

<= br>
On Sun,= Apr 9, 2023 at 11:13=E2=80=AFAM Ihor Radchenko <yantar92@posteo.net> wrote:
S=C5=82awomir Grochowski <slawomir.grochowski= @gmail.com> writes:

> Thank you Ihor for the code review.
> Now please help me find everything that can be improved in this patch.=

I just tried to use the patch using the following test case:

1. Create a new Org file containing

* A
* B
* C
** C1
* D

2. C-u C-c C-x C-c
3. M-<
4. M-<down> M-<up> M-<down> M-<up> M-<down> M= -<up> M-<down> M-<up> C-c C-c
5. Observe text disappearing and columns being unhighlighted. At the
=C2=A0 =C2=A0end, the buffer is left with

* B

>> Finally, I see no records about you copyright assignment status. >> Please take a look at
>> https://orgmode.org/worg/org-contribu= te.html#copyright
>>
>
>=C2=A0 Yes, it's my first time. I sent an email to assign@gnu.org, yesterday.

Note that they should reply within 5 working days.

--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,=
or support my work at <https://liberapay.com/yantar92>
--0000000000003dd77005f90b9219--