From mboxrd@z Thu Jan  1 00:00:00 1970
From: Skip Collins <skip.collins@gmail.com>
Subject: Re: [Bug] commit 39070b7fc7 breaks babel test
Date: Tue, 3 Dec 2013 14:09:59 -0500
Message-ID: <CABUh-76LSR=oh77jBBUSe_3w2JFQv74TK_sY8XBAO3T-cG3A8A@mail.gmail.com>
References: <87eh622s3g.fsf@Rainer.invalid>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55781)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <skip.collins@gmail.com>) id 1VnvM9-0005o9-Md
	for emacs-orgmode@gnu.org; Tue, 03 Dec 2013 14:10:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <skip.collins@gmail.com>) id 1VnvM8-0004C5-EN
	for emacs-orgmode@gnu.org; Tue, 03 Dec 2013 14:10:01 -0500
Received: from mail-ob0-x22d.google.com ([2607:f8b0:4003:c01::22d]:53398)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <skip.collins@gmail.com>) id 1VnvM8-0004C1-7w
	for emacs-orgmode@gnu.org; Tue, 03 Dec 2013 14:10:00 -0500
Received: by mail-ob0-f173.google.com with SMTP id gq1so15050606obb.32
	for <emacs-orgmode@gnu.org>; Tue, 03 Dec 2013 11:09:59 -0800 (PST)
In-Reply-To: <87eh622s3g.fsf@Rainer.invalid>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-org list <emacs-orgmode@gnu.org>

It's been a week and this test still fails.

Would it make sense to automatically enforce passing all tests before
git accepts a change?

On Wed, Nov 27, 2013 at 2:58 AM, Achim Gratz <Stromeko@nexgo.de> wrote:
>
> Hi Eric,
>
> this change seems to introduce additional line breaks in the following
> test:
>
> --8<---------------cut here---------------start------------->8---
> Test test-ob/catches-all-references condition:
>     (ert-test-failed
>      ((should
>        (string=
>         (org-babel-execute-src-block)
>         "A literal example\non two lines for me."))
>       :form
>       (string= "A literal example\non two lines\n for me." "A literal example\non two lines for me.")
>       :value nil))
>    FAILED  1/1  test-ob/catches-all-references
> --8<---------------cut here---------------end--------------->8---
>
> This seems to happen because the final \n from the babel result is not
> stripped anymore, pointing to the change in ob-core.  IIRC we
> flip-flopped a few times already with including or not including this
> final newline, so I don't know whether the code or the test should
> change.