From mboxrd@z Thu Jan 1 00:00:00 1970 From: Skip Collins Subject: Re: [Bug] commit 39070b7fc7 breaks babel test Date: Fri, 6 Dec 2013 15:51:42 -0500 Message-ID: References: <87eh622s3g.fsf@Rainer.invalid> <87ob4t6b3q.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vp2NH-0001Xf-Jf for emacs-orgmode@gnu.org; Fri, 06 Dec 2013 15:51:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vp2NG-0000Ot-3h for emacs-orgmode@gnu.org; Fri, 06 Dec 2013 15:51:47 -0500 Received: from mail-oa0-x232.google.com ([2607:f8b0:4003:c02::232]:58264) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vp2NF-0000OF-VB for emacs-orgmode@gnu.org; Fri, 06 Dec 2013 15:51:46 -0500 Received: by mail-oa0-f50.google.com with SMTP id n16so1396207oag.37 for ; Fri, 06 Dec 2013 12:51:42 -0800 (PST) In-Reply-To: <87ob4t6b3q.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Eric Schulte Cc: Achim Gratz , emacs-org list On Fri, Dec 6, 2013 at 2:05 PM, Eric Schulte wrote: > Skip Collins writes: >> Would it make sense to automatically enforce passing all tests before >> git accepts a change? > > I for one would strongly oppose this change. This would only make it > take longer and thus make it less likely that new code is committed. > This is the master branch where development should be fast and > experimentation should take place, not the maintenance branch. Designating something as an expected failure seems to be a good way to track minor issues that need eventually to be resolved. As a user, I frequently update with make up2 just to avoid getting bitten by stupid errors that might sneak into master. Is it really that much extra work for a developer to run the same command before committing and either fix the error or mark it as a known failure?