Re: [BUG] ob-R tests fail on Emacs 27 since ESS commit 536b5b914a7 [9.7-pre (release_9.6.4-318-gcfe5e0.dirty @ /home/yantar92/.emacs.d/straight/build/org/)]

[Lionel Henry <lionel.hry@gmail.com>]

> Do note that the root cause remains on the ESS side - `run-ess-r' in
> Emacs 27, when called non-interactively, may set line splitting to
> something strange.

I think you're right. Probably we shouldn't be executing screen
options when called non-interactively and instead leave the R default
width (80).

I've opened an issue to track this:
https://github.com/emacs-ess/ESS/issues/1248

Best,
Lionel


On 4/18/23, Ihor Radchenko <yantar92@posteo.net> wrote:
> Lionel Henry <lionel.hry@gmail.com> writes:
>
>> Can you try with the latest commit please?
>> https://github.com/emacs-ess/ESS/commit/ed6c12ee3dfb1046fb030200f45e75a65b31e49e
>
> Works now. Thank you!
>
>> By the way, it looks like you're setting the width in the exported
>> initialization routine rather than just in tests. For user-facing
>> features at least you probably want to set the width to something that
>> will produce readable output.
>
> You are right. For some reason, I thought that the problem also affects
> :results value, when we want to convert ESS interactive output into
> Elisp data. But it was not the case - only :results output has been
> affected.
>
> Since we have no reason to disregard ESS output settings in :results
> output, I pushed an alternative fix that only affects tests, as you
> suggested.
>
> Do note that the root cause remains on the ESS side - `run-ess-r' in
> Emacs 27, when called non-interactively, may set line splitting to
> something strange. I am unsure if it is something that should be fixed
> on ESS side. I am also unsure if the problem does not happen in other
> Emacs versions.
>
> Fixed, on main.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=83e446ea8
>
> I also added a test for :results value when the output is long. Just in
> case.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3c449cc43
>
> --
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at <https://orgmode.org/>.
> Support Org development at <https://liberapay.com/org-mode>,
> or support my work at <https://liberapay.com/yantar92>
>