From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id MJAmLTGRPmRVCAEASxT56A (envelope-from ) for ; Tue, 18 Apr 2023 14:46:41 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id +DMvLDGRPmRz2QAAG6o9tA (envelope-from ) for ; Tue, 18 Apr 2023 14:46:41 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 449243FA44 for ; Tue, 18 Apr 2023 14:46:41 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pokiX-0003Ls-L0; Tue, 18 Apr 2023 08:45:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pokUA-0005z1-Sv for emacs-orgmode@gnu.org; Tue, 18 Apr 2023 08:31:04 -0400 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pokU8-0004U3-Jt for emacs-orgmode@gnu.org; Tue, 18 Apr 2023 08:31:02 -0400 Received: by mail-ej1-x635.google.com with SMTP id dx24so28703249ejb.11 for ; Tue, 18 Apr 2023 05:31:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681821059; x=1684413059; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=NZWxyiYzqi5ltuu/QD5aEOpmNrj1QZnA5F7m5J+uC90=; b=fh2MsZlZ60ZlaGTGDN+ZfIkLg2ZeaXbmz9HdBsBcjdwI9vbL2rKNCpBIW68wGEeeMz 4fB3crKLADvdInOdOxy6ysY8nlNpfcBuDQ1G2FrTqlEfPOoZM5jOkSiSXia6iE1PCA0D WSMICxvTMvikKUtlZJNIMo2IvVLuIjqnXYch48drEqfS8M88+BBI/Rl6uM4Zx6b7WQ69 u1qw96wmJfbLEfNBm0FhYVQfGQtzYm9RPo/0/keTYhLHDBoRpGjMRRg1TJBey+7NA9+L 50W8woxzpBNJt6q9TuyMFmFAB4fdFmMpmMFGuOCKzBs3JDNSG8qX49gBqFaoStZccL8+ vZNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681821059; x=1684413059; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NZWxyiYzqi5ltuu/QD5aEOpmNrj1QZnA5F7m5J+uC90=; b=CmGBPPi4ph2Gwo8ZucI8a3FpezP7ZpJA6eUJs3PeEYvPZL8ibSiV6oFAEU3h4QVzd0 6NhlRFZLnI6aHfBjxxIkvEIurjQB7sw/+KqmCh/sLmZMsCVMo/XkuVTNGztR7y/AzcHX ZHlb0oELsDx9+kMFF2nQRL1j3DslDn7gQWf3yJGciyKD9Me6CJ5tq6m9O9RJa95OQKu0 wFDeY2epOzk4VHt6TAjay+RMA3vIf4uQHrsWMJWcSShUu0kzkzD9YmsWvh2OeOAugrJp PU7drNMOSEZc+qnn0nbeZEA1D48GJEXKbqQ5edupJzA1PgRNQdMKn/6tZJxiR+WppHIC iyEw== X-Gm-Message-State: AAQBX9fSogXSZw/t276rFh57N+eWBiQv7L9i/kmNY4ENSd39QIWuKgs1 mS8jgz4VSenxPtMhDqhCxwkYKHzblzvxQw+XFEJtqCUT X-Google-Smtp-Source: AKy350ZiQMInkySDtvFDH+JkhWRY4JMuya8l3cZSKFQvIGHffXqC01pZQ98fWan5Y3Z2YSBEFLKbO2qmerUS6YgWsXU= X-Received: by 2002:a17:907:1c26:b0:94a:921b:c805 with SMTP id nc38-20020a1709071c2600b0094a921bc805mr13234767ejc.45.1681821058547; Tue, 18 Apr 2023 05:30:58 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a17:907:d307:b0:94f:2d6f:2c5f with HTTP; Tue, 18 Apr 2023 05:30:57 -0700 (PDT) In-Reply-To: <87mt35h3ip.fsf@localhost> References: <87ilduqrem.fsf@localhost> <87mt35h3ip.fsf@localhost> From: Lionel Henry Date: Tue, 18 Apr 2023 14:30:57 +0200 Message-ID: Subject: Re: [BUG] ob-R tests fail on Emacs 27 since ESS commit 536b5b914a7 [9.7-pre (release_9.6.4-318-gcfe5e0.dirty @ /home/yantar92/.emacs.d/straight/build/org/)] To: Ihor Radchenko Cc: emacs-orgmode@gnu.org, ESS-core@r-project.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::635; envelope-from=lionel.hry@gmail.com; helo=mail-ej1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 18 Apr 2023 08:45:52 -0400 X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1681822001; a=rsa-sha256; cv=none; b=FBDNf2ksQa95rbjOZsMvsKWlrQfDZD34jL9dDtmzhEAeD7neSEn/LvE250x3kFY0XIuxnf +9I0WXRE6x2F8pDd7k0aYl673oMnHNDyQMF28NWUoyuOivnhWLdq7PUcpM4J3U/FDsHp5E 65Q4+8FesKdpFPGO/prkZzPeV2ix9RnIWFgU2emSQ3BW3Y4R6ypKWV0LTLz9eWQStN4hi6 jRf1p3D7FhY+TeeEljeYYbdbDGBaZTBO2pHlwkrEr3d2T3HJjaxOMUVSVAE6acyoisOY81 bdFvnN0Ua+WgJ77i1WryOwo7BieLbJDC5SjJFsvUeYIuPjIYMfhV14punZdhVA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=fh2MsZlZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1681822001; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=NZWxyiYzqi5ltuu/QD5aEOpmNrj1QZnA5F7m5J+uC90=; b=ETavJbrS70muXhhwpezDNcVt8M/CuaDu+joeU7P8V7PPWysZ1tA1OifVjunhf4T37Lphbx MYhatWlgEvwe2sQ1QtCV6tVyRu9vA2+Evo6kwcdbVqD3fVw5AKU0epPFuq1smjXYpQaDfr /sUgULkMXFFS2CbFMNxyZpUn2IYrPftxDn7SIcgq9K3Tw01M30FQEshPjtSKBxXSxBxO7u v9ximnd2nOObD6oQbW7SM60xP8AXRb9WPI8830LPTNzB50h2fyCB9aDr9itb8zEbwi4vtz MIfS0UYOSeMLaH++WwgRFSFUVG+DFa8xgcFFVhxEuzq08HqnHKSwDlXSZvmYow== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -4.95 X-Spam-Score: -4.95 X-Migadu-Queue-Id: 449243FA44 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=fh2MsZlZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-TUID: kSl+7kFRmYp4 Can you try with the latest commit please? https://github.com/emacs-ess/ESS/commit/ed6c12ee3dfb1046fb030200f45e75a65b31e49e By the way, it looks like you're setting the width in the exported initialization routine rather than just in tests. For user-facing features at least you probably want to set the width to something that will produce readable output. Best, Lionel On 4/18/23, Ihor Radchenko wrote: > Lionel Henry writes: > >> Thanks for looking into this. I think you're right it's probably >> caused by ESS now setting the width on startup. In that case you could >> fix your tests by setting `options(width = )` to some hardcoded value. >> You could do it via `ess-r-post-run-hook`. > > I tried using `ess-r-post-run-hook', but it fails for some reason. > See the attached patch. > > With the patch, the tests fail with > > Test ob-session-async-R-value-drawer condition: > (user-error "ESS process not ready. Finish your command before trying > again") > > In contrast, directly editing `ess-r-initialize' like > ;; (ess-execute-screen-options t) > (ess-command (ess-calculate-width 9999)) > > does not fail and make all the tests pass. > > Is there anything I am missing about `ess-r-post-run-hook'? > >