From: Lionel Henry <lionel.hry@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org, ESS-core@r-project.org
Subject: Re: [BUG] ob-R tests fail on Emacs 27 since ESS commit 536b5b914a7 [9.7-pre (release_9.6.4-318-gcfe5e0.dirty @ /home/yantar92/.emacs.d/straight/build/org/)]
Date: Tue, 18 Apr 2023 14:30:57 +0200 [thread overview]
Message-ID: <CAAkLcbt6AxUaMsTLGW+0o_DB=F9UDAjdJC-XTGctJs_K3KRomw@mail.gmail.com> (raw)
In-Reply-To: <87mt35h3ip.fsf@localhost>
Can you try with the latest commit please?
https://github.com/emacs-ess/ESS/commit/ed6c12ee3dfb1046fb030200f45e75a65b31e49e
By the way, it looks like you're setting the width in the exported
initialization routine rather than just in tests. For user-facing
features at least you probably want to set the width to something that
will produce readable output.
Best,
Lionel
On 4/18/23, Ihor Radchenko <yantar92@posteo.net> wrote:
> Lionel Henry <lionel.hry@gmail.com> writes:
>
>> Thanks for looking into this. I think you're right it's probably
>> caused by ESS now setting the width on startup. In that case you could
>> fix your tests by setting `options(width = )` to some hardcoded value.
>> You could do it via `ess-r-post-run-hook`.
>
> I tried using `ess-r-post-run-hook', but it fails for some reason.
> See the attached patch.
>
> With the patch, the tests fail with
>
> Test ob-session-async-R-value-drawer condition:
> (user-error "ESS process not ready. Finish your command before trying
> again")
>
> In contrast, directly editing `ess-r-initialize' like
> ;; (ess-execute-screen-options t)
> (ess-command (ess-calculate-width 9999))
>
> does not fail and make all the tests pass.
>
> Is there anything I am missing about `ess-r-post-run-hook'?
>
>
next prev parent reply other threads:[~2023-04-18 12:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 18:45 [BUG] ob-R tests fail on Emacs 27 since ESS commit 536b5b914a7 [9.7-pre (release_9.6.4-318-gcfe5e0.dirty @ /home/yantar92/.emacs.d/straight/build/org/)] Ihor Radchenko
2023-04-17 20:26 ` Lionel Henry
2023-04-18 10:46 ` Ihor Radchenko
2023-04-18 12:30 ` Lionel Henry [this message]
2023-04-18 13:11 ` Ihor Radchenko
2023-04-18 13:14 ` Lionel Henry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAkLcbt6AxUaMsTLGW+0o_DB=F9UDAjdJC-XTGctJs_K3KRomw@mail.gmail.com' \
--to=lionel.hry@gmail.com \
--cc=ESS-core@r-project.org \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).