From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Rettke Subject: Re: Patch adding from-logo commentary ox-koma-letter.el Date: Wed, 20 Jun 2018 17:38:57 -0500 Message-ID: References: <8736xji4a8.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVlkk-0006rV-MN for emacs-orgmode@gnu.org; Wed, 20 Jun 2018 18:39:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVlkj-00041I-Tf for emacs-orgmode@gnu.org; Wed, 20 Jun 2018 18:39:02 -0400 In-Reply-To: <8736xji4a8.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: Bastien , Org-mode On Tue, Jun 19, 2018 at 3:11 AM, Nicolas Goaziou wrote: > Hello, > > Grant Rettke writes: > >> Although the function document ion mentions the markup to use, it >> doesn't explain that the user needs to provide a logo file in the same >> directory as the letter. > > Is it really necessary? If you are comfortable with LaTeX, then it probably isn't necessary because you already know how \includegraphics{logo} works, or you would look it up. When I wrote this, I felt like because ox-koma-letter makes it so easy for non LaTeX Org users, that a reminder would help because this variable is I think the only one that requires any LaTeX knowledge. That was the context for my statement. I'm making a big assumption that non latex org users would benefit here. > Couldn't you use, e.g., \includegraphics{subdir/logo} Yes. If you like the additional documentation, then I will update it with this and send a new patch. WDYT?