emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] Fix table formula debugger error display
@ 2013-09-07  8:57 Michael Brand
  2013-09-07 14:22 ` Carsten Dominik
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Brand @ 2013-09-07  8:57 UTC (permalink / raw)
  To: Org Mode

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

Hi all

Attached is a patch to fix the offset of the arrow pointing to the
error in a Calc formula, see this example:

| #ERROR |
#+TBLFM: $1 = . want a Calc error

Michael

[-- Attachment #2: 0001-Fix-table-formula-debugger-error-display.patch --]
[-- Type: application/octet-stream, Size: 922 bytes --]

From bd6bf6d7f3745bf56a2494dca41b1eed7dfb86d0 Mon Sep 17 00:00:00 2001
From: Michael Brand <michael.ch.brand@gmail.com>
Date: Sat, 7 Sep 2013 10:55:14 +0200
Subject: [PATCH] Fix table formula debugger error display

* lisp/org-table.el (org-table-eval-formula): Align the arrow pointing
to the error in a Calc formula to the other fomula debugger logs.
---
 lisp/org-table.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-table.el b/lisp/org-table.el
index c00fbc5..246cf8d 100644
--- a/lisp/org-table.el
+++ b/lisp/org-table.el
@@ -2736,7 +2736,7 @@ $xyz->  %s
 @r$c->  %s
 $1->    %s\n" orig formula form0 form))
 	    (if (listp ev)
-		(princ (format "       %s^\nError:  %s"
+		(princ (format "        %s^\nError:  %s"
 			       (make-string (car ev) ?\-) (nth 1 ev)))
 	      (princ (format "Result: %s\nFormat: %s\nFinal:  %s"
 			     ev (or fmt "NONE")
-- 
1.7.12.4 (Apple Git-37)


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix table formula debugger error display
  2013-09-07  8:57 [PATCH] Fix table formula debugger error display Michael Brand
@ 2013-09-07 14:22 ` Carsten Dominik
  0 siblings, 0 replies; 2+ messages in thread
From: Carsten Dominik @ 2013-09-07 14:22 UTC (permalink / raw)
  To: Michael Brand; +Cc: Org Mode

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

Hi Michael,

thank you for the patch, I have applied it.

- Carsten


On 7.9.2013, at 10:57, Michael Brand <michael.ch.brand@gmail.com> wrote:

> Hi all
> 
> Attached is a patch to fix the offset of the arrow pointing to the
> error in a Calc formula, see this example:
> 
> | #ERROR |
> #+TBLFM: $1 = . want a Calc error
> 
> Michael
> <0001-Fix-table-formula-debugger-error-display.patch>


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 163 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-09-07 14:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-07  8:57 [PATCH] Fix table formula debugger error display Michael Brand
2013-09-07 14:22 ` Carsten Dominik

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).