From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YHocNnq0oGHQAgEAgWs5BA (envelope-from ) for ; Fri, 26 Nov 2021 11:18:34 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id wM+7MXq0oGH7KgAAbx9fmQ (envelope-from ) for ; Fri, 26 Nov 2021 10:18:34 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9685C16B1B for ; Fri, 26 Nov 2021 11:18:34 +0100 (CET) Received: from localhost ([::1]:51636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqYJN-0000sO-KM for larch@yhetil.org; Fri, 26 Nov 2021 05:18:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58764) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqQ33-0003Ru-Se for emacs-orgmode@gnu.org; Thu, 25 Nov 2021 20:29:09 -0500 Received: from [2a00:1450:4864:20::52f] (port=36617 helo=mail-ed1-x52f.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mqQ32-0000Ez-1i for emacs-orgmode@gnu.org; Thu, 25 Nov 2021 20:29:09 -0500 Received: by mail-ed1-x52f.google.com with SMTP id z5so32274276edd.3 for ; Thu, 25 Nov 2021 17:29:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=pfV3bS3Ttea39SPbvHP+57thGhUIkAI4EFdQf2O623Q=; b=lN3trozYt02rOmi2FbjA8gcWLfVUkBPj2pGpYEA7Jl7XjwFQdO6p/8jLMImjCqxglq B4DKa5cb9ACVhK3C8Ja41fI8WKi3G19vRWqgUF5RAFkOph5DF+DX2rhP250webFc1Dwe NJMf5c+JeySO0WZOK2Ndp/g5ZNSJ7djPxUk1qdsIs1Jc7bGgxYLSIQinyk2VzwS9dX3z WLIvr7hBEwULWZZkbT3B3QUztKYr6TrHU/ZrReYqhB2ZE/rMF7QC27cNGYjKsVMoxINm K9Q189wXRUUC+OxkfP0xP0aHDMmiWUiTs4npfuEgNe4A+A5gpor2T9AeqeVY/xFaSLbh MxLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=pfV3bS3Ttea39SPbvHP+57thGhUIkAI4EFdQf2O623Q=; b=I8x9D6aAqtdHz2MpwNE4L4a1TJt3LPZFN5BmRiZmPbqzs92PPZaEelnrxLQ3kga8tN KpuWkN1PNYoEEsnSflsQODYgCP8jn39Y8Vf4eO5nNVD7quWXNSsoBflaV+vXY7HUyGc0 LcXaJVgTRqBRJy9iKHL3ZrGQrdW7R0862lOyG2UmWgSm+voiiyLv+aEp+SDQupjaQZJf Cblt7Avd/owtGVFxxeHw8VshJERFPN3sy5DzEx/joKup0jixsE0/IJHxjNc6GX4YDyUn mV5Anwdgu5AE7z7ap+dq57viGZIUxbvQA/7xdXIA++F386i8f7ZWsJAOMKsguUIyiux+ CIRw== X-Gm-Message-State: AOAM533RdaUWpyNhmhXf+1sa+Jg6/G/75+AnP0XbY0YIolzvIptWLqej ftvpAti7/+KRYraHgrTcg0VoCXsYn91mcoeBh1sYvXmGcOc= X-Google-Smtp-Source: ABdhPJwmfS4UvHpmqEO1TMpoEGW7F4Z0JfnT6WNXQ/C+057p0MDcVGjrzHzG7tizvBjzdqMnh93580/pPhQQ+DiGoZQ= X-Received: by 2002:a05:6402:254f:: with SMTP id l15mr44838119edb.12.1637890146108; Thu, 25 Nov 2021 17:29:06 -0800 (PST) MIME-Version: 1.0 From: Matt Micheletti Date: Thu, 25 Nov 2021 20:28:55 -0500 Message-ID: Subject: [BUG] org-add-planning-info does not respect org-scheduled-string or org-deadline-string To: emacs-orgmode@gnu.org Content-Type: multipart/alternative; boundary="00000000000057094205d1a704f4" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::52f (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::52f; envelope-from=mattdmicheletti@gmail.com; helo=mail-ed1-x52f.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 26 Nov 2021 05:18:02 -0500 X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637921914; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=pfV3bS3Ttea39SPbvHP+57thGhUIkAI4EFdQf2O623Q=; b=Bn4ilgYE7uigs0W4MSVuLzhxZTvDmjxMT7ofgpw89zw/6sp9LPEBtJWp11HdLyjhqtMGWN 9nugZUZ7R7E8BbQRKCiqLGWuMhTqgVU99RPibs8azdga1a6CbNbLHGK+kfRhvpRUdH7EWH hn53z3pmwAVEzKTMN2WqnOuBN7GM52yj0vPJ9pNC/kCzGWD32tHXhLbNPocVw7bjmuVvhX G74sJ/y/1O70URlATZZfbSUHYlqqziMkeV0mLUGEE0KaRDeKkKK4KyOasuwLn9r9TSkt03 iOM8kFEABoAykMcV3lTecKsHcdM2FoKF3tXurVodS7dAbaSAt4KAveJYqg2dqg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637921914; a=rsa-sha256; cv=none; b=p+RrwH9iJfw1eaC+eSNB3uisxPwDROEI2pmDzsw4A7j/VlUksZXRDm3IOwdVTFc20qqxhD McRWxqKhje6z28PMrQqfpPkP/6j/yBljrDxWH0qLcbqFwBOyvxOyWxzYGGN3gzTYI/4iUz jFbL7TNAUUZb3K8RTyZ8LivmxPS5BxgGf3BH+RVSqqnD0e+QW01Thud0oxWbyu1E3qQqkC wHKS/L6Ahry/XUQoNvbAQOCemKf3ZFi/9FxNhOvdEzTpUWeDGQZGni0esHRIZGYW46PEVc duxTD/Bwj9ZDIjoyxJl+gKSSfxWFe5K9hxdeC+DjG3Md0+36UFeyjj6qk4uWUw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=lN3trozY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.10 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=lN3trozY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9685C16B1B X-Spam-Score: -4.10 X-Migadu-Scanner: scn0.migadu.com X-TUID: ni1Bg9ENyb7t --00000000000057094205d1a704f4 Content-Type: text/plain; charset="UTF-8" Hello, The following lines in `org-add-planning-info` (Lines 10844 & 10845 as of commit cc3df3a ) do not respect the usage of the org-scheduled-string or org-deadline-string values when prompting the user to enter a schedule or deadline timestamp leading to confusion amongst the inconsistent UI/UX when those strings are changed (as Org Mode permits). Source/Attribution Credits: Lines 10844 ~ 10845 ``` (defun org-add-planning-info (what &optional time &rest remove) ;; Omitted for brevity... ;; If necessary, get the time from the user (or time (org-read-date nil 'to-time nil (cl-case what (deadline "DEADLINE") (scheduled "SCHEDULED") (otherwise nil)) default-time default-input))))) ``` Recommend changing to ``` (defun org-add-planning-info (what &optional time &rest remove) ;; Omitted for brevity... ;; If necessary, get the time from the user (or time (org-read-date nil 'to-time nil (cl-case what (deadline org-deadline-string) (scheduled org-scheduled-string) (otherwise nil)) default-time default-input))))) ``` Thanks, Matt M. --00000000000057094205d1a704f4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

The following lines in `org-add-= planning-info` (Lines 10844 & 10845 as of commit cc3df= 3a) do not respect the usage of the org-scheduled-string or org-deadlin= e-string values when prompting the user to enter a schedule or deadline tim= estamp leading to confusion amongst the inconsistent UI/UX when those strin= gs are changed (as Org Mode permits).

Source/Attribution Credits: Line= s 10844 ~ 10845
```
(defun org-add-planning-info (what &optio= nal time &rest remove)
;; Omitted for brevity...
;; If necessary,= get the time from the user
(or time (org-read-date nil 'to-time nil=
(cl-case what
(deadline "DEADLINE")
(scheduled "SC= HEDULED")
(otherwise nil))
default-time default-input)))))
``= `

Recommend changing to

=C2=A0```
(defun org-add-planning= -info (what &optional time &rest remove)
;; Omitted for brevity.= ..
;; If necessary, get the time from the user
(or time (org-read-dat= e nil 'to-time nil
(cl-case what
(deadline org-deadline-string)(scheduled org-scheduled-string)
(otherwise nil))
default-time defa= ult-input)))))
```

Thanks,
Matt M.
--00000000000057094205d1a704f4--