emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Oleh <ohwoeowho@gmail.com>
To: Chao Lu <loochao.list@gmail.com>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: org-download.el
Date: Mon, 19 Jan 2015 09:28:22 +0100	[thread overview]
Message-ID: <CAA01p3rBtMLkPTnMrGeQhOYdyf7cnGVn393+1WKZdMbRLfP-sw@mail.gmail.com> (raw)
In-Reply-To: <CAD54YEbZ7PHNYesKZTwWMn5U8fVoPPT+HpbGHrk7SMMZLYDM1g@mail.gmail.com>

> 2. As I'm testing now, I can get a "Wrong type argument:
>    number-or-marker-p, nil" error if the org-mode file in question is
>    empty or the cursor is before the first heading. Is this the case for
> you?
>    I'll fix this case soon anyway.
> -- Not really, I made a test.org then insert some heading, then tried
> (org-download-yank) with the web address on top of kill-ring, which did not
> trig the download events as well.

It is important that the point should be not before the first
heading. Is this the case?  Also, are you using the Github version? I
haven't yet propagated the changes to the org-contrib version.

> 3. If this doesn't work, try the following simplified function:
>
>     (defun org-download-yank-1 ()
>       (interactive)
>       (let ((filename "./foo.png"))
>         (org-download--image
>          "https://www.google.nl/images/srpr/logo11w.png"
>          filename)
>         (insert (format "[[%s]]" filename))
>         (org-display-inline-images)))
>
> -- This one works! The google logo gets into my test.org buffer, which is a
> good signal~

OK, this means that at least `org-download-yank` can be fixed very soon.
And, as I recall, the dnd works for some OSX users.
Let's not bother the nice org-people and continue the discussion here:
https://github.com/abo-abo/org-download/issues/11

regards,
Oleh

      reply	other threads:[~2015-01-19  8:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-13  7:49 org-download.el Chao Lu
2015-01-13  8:47 ` org-download.el briangpowell .
2015-01-13  8:58   ` org-download.el Rainer M Krug
2015-01-13 16:47     ` org-download.el Chao Lu
2015-01-15 12:11 ` org-download.el Oleh
2015-01-18 10:04   ` org-download.el Chao Lu
2015-01-18 11:10     ` org-download.el Oleh
2015-01-18 19:31       ` org-download.el Oleh
2015-01-19  3:29       ` org-download.el Chao Lu
2015-01-19  8:28         ` Oleh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA01p3rBtMLkPTnMrGeQhOYdyf7cnGVn393+1WKZdMbRLfP-sw@mail.gmail.com \
    --to=ohwoeowho@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=loochao.list@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).