From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleh Subject: Re: Drag images from Firefox to org-mode Date: Wed, 23 Oct 2013 20:26:22 +0200 Message-ID: References: <87eh7irjvi.fsf@yahoo.fr> <52610C29.3000505@yahoo.fr> <526114B4.6060303@yahoo.fr> <2d5635af9ad6d51badb40e1e19c85572@mail.rickster.com> <87y55qpp44.fsf@yahoo.fr> <857b1a922e24dda4404df4d19fabd7e2@mail.rickster.com> <20131018204553.GA87254@BigDog.local> <87k3h7ptcc.fsf@yahoo.fr> <23f3f3530f88fa5571d80b8c38adf4c6@mail.rickster.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZ38W-0004HF-Vf for emacs-orgmode@gnu.org; Wed, 23 Oct 2013 14:26:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VZ38R-00041A-Ru for emacs-orgmode@gnu.org; Wed, 23 Oct 2013 14:26:28 -0400 Received: from mail-we0-x22c.google.com ([2a00:1450:400c:c03::22c]:43585) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZ38R-00040y-Kv for emacs-orgmode@gnu.org; Wed, 23 Oct 2013 14:26:23 -0400 Received: by mail-we0-f172.google.com with SMTP id q58so1255953wes.3 for ; Wed, 23 Oct 2013 11:26:22 -0700 (PDT) In-Reply-To: <23f3f3530f88fa5571d80b8c38adf4c6@mail.rickster.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Rick Frankel Cc: Nicolas Richard , org mode On Wed, Oct 23, 2013 at 7:13 PM, Rick Frankel wrote: > On 2013-10-20 16:42, Nicolas Richard wrote: >> >> Oleh writes: >> This can be fixed with a platform-aware function that checks both the >> clipboard and the cut-buffer. >> >> I suggest to ask for a string with (read-string "URL: " nil nil default), >> offering the content of the clipboard/kill ring/selections as the DEFAULT. >> I think it's better to be explicit when downloading content, and there >> isn't much overhead in asking for a confirmation. > > > Agreed. Downloading stuff to your local machine should require a > confirmation step. This is already in place. > >> This can be fixed by adding `org-download-max-filename-length`. When >> it >> overflows, just resort to `default-directory' and provide a >> message/option to fix. >> >> I suggest that the right place for those files is as attachment, and >> that's where customization should happen. The function choosing the >> right place (i.e. org-download--dir) could be turned into a defvar or >> defcustom which could then be set either to #'org-download--dir or >> #'org-attach-dir. > > > Agreed. Also, the current "fix" (two variable and three functions!) is > overly complex. Two variables can change independently in a meaningful way, giving 4 combinations with the possibility to alter just part of the setup on a file local basis. Three functions specify the intent more clearly. > I propose that their be three options in the > defcustom: > - 'org-attach-directory (the default) > - user entered string I don't get this one. > - a function (which could be set to `org-download-dir') This can be an option for `org-download-method' > > >> By the way, which system doesn't allow for spaces in directory names? >> >> ISTR that MSDOS (except the latest versions) didn't allow spaces in >> filenames :) Anyway, I tend to avoid spaces as much as I can in >> filenames (including dirs) > > > Also, sending files to external command/shell script for processing > often breaks if you have spaces in paths due to quoting issue. > > >> If you want the ability to create arbitrary output directories >> based >> on document context, the customization can be made to accept a >> function (lambda) as a value, which could then return a directory >> prefix. >> This isn't an option for users with no elisp skills. >> >> It is an option if there are enough examples/built-ins that can be used. >> e.g. message-send-mail-function can be customized in this way, its >> docstring gives a list of meaningful values. > > > Agreed. There's still two functionality bits that I want to add: local files and forwarding to default dnd handlers in the case it's not an image. But that can be added in later. Please make the changes that you think are necessary and commit to org. regards, Oleh