emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Bug: insert after hyperlink displaces mark during org-compat:org-move-to-column (since 8.1) [8.2.1 (release_8.2.1-45-g92f89e @ /home/rgarrett/src/org/orgmode/org-mode/lisp/)]
@ 2013-11-07 20:53 Reuben Garrett
  2013-11-09 16:48 ` Bastien
  0 siblings, 1 reply; 6+ messages in thread
From: Reuben Garrett @ 2013-11-07 20:53 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 3230 bytes --]

I noticed when completing a capture template that the point suddenly jumped
back to the left of a hyperlink on the same line. It seems to only happen
when there's a hyperlink on the line, and only within a header. I debugged
org-self-insert-command and traced through to org-move-to-column, where I
saw the point arrive at its final resting place for
org-self-insert-command:

+=== backtrace:
Debugger entered--returning value: 25
  move-to-column(25 t)
* org-move-to-column(25 t)
* org-align-tags-here(-77)
* #[nil "\301 f\302\232\205^P^@\303 \205^P^@\304^H!\207" [org-tags-column
point-at-bol 42 org-at-heading-p org-align-tags-here] 2]()
* funcall(#[nil "\301 f\302\232\205^P^@\303 \205^P^@\304^H!\207"
[org-tags-column point-at-bol 42 org-at-heading-p org-align-tags-here] 2])
* org-fix-tags-on-the-fly()
  org-self-insert-command(1)
  call-interactively(org-self-insert-command nil nil)
===+

I have org-mode installed from source rather than ELPA or my OS package
manager (portage), so I was able to trace through releases and home-in on
this behavior's emergence in 8.1 <
http://orgmode.org/w/?p=org-mode.git;a=log;h=release_8.1>

I also tried `emacs -Q -l /path/to/minimal-org.el` with the latest version
(8.2.1-45-g92f89e), but experienced the same results.

Thank you for all your work on a vital member of my software family, and
let me know if I can improve my report in any way.

Best regards,
Reuben Garrett

+=== (org-submit-bug-report):
Emacs  : GNU Emacs 24.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.4.4)
 of 2013-07-26 on rgarrett
Package: Org-mode version 8.2.1 (release_8.2.1-45-g92f89e @
/home/rgarrett/src/org/orgmode/org-mode/lisp/)

current state:
==============
(setq
 org-tab-first-hook '(org-hide-block-toggle-maybe
              org-src-native-tab-command-maybe
              org-babel-hide-result-toggle-maybe
              org-babel-header-arg-expand)
 org-speed-command-hook '(org-speed-command-default-hook
              org-babel-speed-command-hook)
 org-occur-hook '(org-first-headline-recenter)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-confirm-shell-link-function 'yes-or-no-p
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-src-mode-hook '(org-src-babel-configure-edit-buffer
             org-src-mode-configure-edit-buffer)
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-babel-pre-tangle-hook '(save-buffer)
 org-mode-hook '(#[nil "\300\301\302\303\304$\207"
           [org-add-hook change-major-mode-hook org-show-block-all
            append local]
           5]
         #[nil "\300\301\302\303\304$\207"
           [org-add-hook change-major-mode-hook
            org-babel-show-result-all append local]
           5]
         org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-ctrl-c-ctrl-c-hook '(org-babel-hash-at-point
              org-babel-execute-safely-maybe)
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
          org-cycle-hide-inline-tasks org-cycle-show-empty-lines
          org-optimize-window-after-visibility-change)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 )
===+

[-- Attachment #2: Type: text/html, Size: 3830 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Bug: insert after hyperlink displaces mark during org-compat:org-move-to-column (since 8.1) [8.2.1 (release_8.2.1-45-g92f89e @ /home/rgarrett/src/org/orgmode/org-mode/lisp/)]
@ 2013-11-07 21:32 Reuben Garrett
  2013-11-07 21:49 ` Bastien
  0 siblings, 1 reply; 6+ messages in thread
From: Reuben Garrett @ 2013-11-07 21:32 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 3539 bytes --]

I noticed when completing a capture template that the point suddenly jumped
back to the left of a hyperlink on the same line in the middle of typing.
It seems to only happen when there's a hyperlink on the line, and only
within a header. I debugged org-self-insert-command and traced through to
org-move-to-column, where I saw the point arrive at its final resting place
for org-self-insert-command:

+=== backtrace:
Debugger entered--returning value: 25
  move-to-column(25 t)
* org-move-to-column(25 t)
* org-align-tags-here(-77)
* #[nil "\301 f\302\232\205^P^@\303 \205^P^@\304^H!\207" [org-tags-column
point-at-bol 42 org-at-heading-p org-align-tags-here] 2]()
* funcall(#[nil "\301 f\302\232\205^P^@\303 \205^P^@\304^H!\207"
[org-tags-column point-at-bol 42 org-at-heading-p org-align-tags-here] 2])
* org-fix-tags-on-the-fly()
  org-self-insert-command(1)
  call-interactively(org-self-insert-command nil nil)
===+

I have org-mode installed from source rather than ELPA or my OS package
manager (portage), so I was able to trace through releases and home-in on
this behavior's emergence in 8.1 <
http://orgmode.org/w/?p=org-mode.git;a=log;h=release_8.1>

I also tried `emacs -Q -l /path/to/minimal-org.el` with the latest version
(8.2.1-45-g92f89e), but experienced the same results.

Thank you for all your impressive work on a vital member of my toolchain,
and please let me know if I can improve my report in any way.

Best regards,
Reuben Garrett

p.s. — I apologize if I've ended up posting this twice. I don't know
whether my first attempt failed because it hasn't been moderated yet, or
because I hadn't registered before sending it.

+=== (org-submit-bug-report):
Emacs  : GNU Emacs 24.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.4.4)
 of 2013-07-26 on rgarrett
Package: Org-mode version 8.2.1 (release_8.2.1-45-g92f89e @
/home/rgarrett/src/org/orgmode/org-mode/lisp/)

current state:
==============
(setq
 org-tab-first-hook '(org-hide-block-toggle-maybe
              org-src-native-tab-command-maybe
              org-babel-hide-result-toggle-maybe
              org-babel-header-arg-expand)
 org-speed-command-hook '(org-speed-command-default-hook
              org-babel-speed-command-hook)
 org-occur-hook '(org-first-headline-recenter)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-confirm-shell-link-function 'yes-or-no-p
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-src-mode-hook '(org-src-babel-configure-edit-buffer
             org-src-mode-configure-edit-buffer)
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-babel-pre-tangle-hook '(save-buffer)
 org-mode-hook '(#[nil "\300\301\302\303\304$\207"
           [org-add-hook change-major-mode-hook org-show-block-all
            append local]
           5]
         #[nil "\300\301\302\303\304$\207"
           [org-add-hook change-major-mode-hook
            org-babel-show-result-all append local]
           5]
         org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-ctrl-c-ctrl-c-hook '(org-babel-hash-at-point
              org-babel-execute-safely-maybe)
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
          org-cycle-hide-inline-tasks org-cycle-show-empty-lines
          org-optimize-window-after-visibility-change)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 )
===+

[-- Attachment #2: Type: text/html, Size: 4215 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Bug: insert after hyperlink displaces mark during org-compat:org-move-to-column (since 8.1) [8.2.1 (release_8.2.1-45-g92f89e @ /home/rgarrett/src/org/orgmode/org-mode/lisp/)]
  2013-11-07 21:32 Bug: insert after hyperlink displaces mark during org-compat:org-move-to-column (since 8.1) [8.2.1 (release_8.2.1-45-g92f89e @ /home/rgarrett/src/org/orgmode/org-mode/lisp/)] Reuben Garrett
@ 2013-11-07 21:49 ` Bastien
  2013-11-07 22:29   ` Reuben Garrett
  0 siblings, 1 reply; 6+ messages in thread
From: Bastien @ 2013-11-07 21:49 UTC (permalink / raw)
  To: Reuben Garrett; +Cc: emacs-orgmode

Hi Reuben,

Reuben Garrett <reubengarrett@gmail.com> writes:

> I also tried `emacs -Q -l /path/to/minimal-org.el` with the latest
> version (8.2.1-45-g92f89e), but experienced the same results.

Can you share /path/to/minimal-org.el and the capture template?

Does it happen even when there are no tags in the headline?

Thanks for your help in debugging this,

-- 
 Bastien

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Bug: insert after hyperlink displaces mark during org-compat:org-move-to-column (since 8.1) [8.2.1 (release_8.2.1-45-g92f89e @ /home/rgarrett/src/org/orgmode/org-mode/lisp/)]
  2013-11-07 21:49 ` Bastien
@ 2013-11-07 22:29   ` Reuben Garrett
  2013-11-08  7:46     ` Bastien
  0 siblings, 1 reply; 6+ messages in thread
From: Reuben Garrett @ 2013-11-07 22:29 UTC (permalink / raw)
  To: Bastien; +Cc: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]

On Thu, Nov 7, 2013 at 3:49 PM, Bastien <bzg@gnu.org> wrote:

> Can you share /path/to/minimal-org.el and the capture template?
Sure, here they are (inlined below). I should add that this also happens
outside capture mode — I just happened to notice it then.

> Does it happen even when there are no tags in the headline?
No — just tried removing the tags and was unable to reproduce.

> Thanks for your help in debugging this,
The pleasure is mine! I only wish I'd started learning Lisp sooner so I
could offer patches as well. One of these days …

+=== /path/to/minimal-org.el:
;;; Minimal setup to load latest `org-mode'
     ;; activate debugging
     (setq debug-on-error t
           debug-on-signal nil
           debug-on-quit nil)

     ;; add latest org-mode to load path
     (add-to-list 'load-path (expand-file-name
"/home/rgarrett/src/org/orgmode/org-mode/lisp"))
     (add-to-list 'load-path (expand-file-name
"/home/rgarrett/src/org/orgmode/org-mode/contrib/lisp" t))
===+

+=== capture template:
(customize-set-variable
 'org-capture-templates
 (quote
  (
  ("t" "Ticket" entry (file+olp "~/var/org/jnl.org" "tix") "* TODO Ticket #
[[http://example.com/ticket=%^{Ticket #}][%\\1]] - %? %^G \n  DEADLINE: %^T
" :prepend t :unnarrowed t)
  )
  )
 )

-- 

Reuben Garrett

[-- Attachment #2: Type: text/html, Size: 1846 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Bug: insert after hyperlink displaces mark during org-compat:org-move-to-column (since 8.1) [8.2.1 (release_8.2.1-45-g92f89e @ /home/rgarrett/src/org/orgmode/org-mode/lisp/)]
  2013-11-07 22:29   ` Reuben Garrett
@ 2013-11-08  7:46     ` Bastien
  0 siblings, 0 replies; 6+ messages in thread
From: Bastien @ 2013-11-08  7:46 UTC (permalink / raw)
  To: Reuben Garrett; +Cc: emacs-orgmode

Reuben Garrett <reubengarrett@gmail.com> writes:

> Sure, here they are (inlined below). I should add that this also
> happens outside capture mode

Let's focus on this case then -- can you provide a minimal step by
step recipe to reproduce this?  E.g.: I insert this, my point is here,
I insert this, then the point jumps back there...

Thanks!

-- 
 Bastien

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Bug: insert after hyperlink displaces mark during org-compat:org-move-to-column (since 8.1) [8.2.1 (release_8.2.1-45-g92f89e @ /home/rgarrett/src/org/orgmode/org-mode/lisp/)]
  2013-11-07 20:53 Reuben Garrett
@ 2013-11-09 16:48 ` Bastien
  0 siblings, 0 replies; 6+ messages in thread
From: Bastien @ 2013-11-09 16:48 UTC (permalink / raw)
  To: Reuben Garrett; +Cc: emacs-orgmode

Hi Reuben,

Reuben Garrett <reubengarrett@gmail.com> writes:

> I noticed when completing a capture template that the point suddenly
> jumped back to the left of a hyperlink on the same line. It seems to
> only happen when there's a hyperlink on the line, and only within a
> header. I debugged org-self-insert-command and traced through to
> org-move-to-column, where I saw the point arrive at its final resting
> place for org-self-insert-command:

This is now fixed in maint and master, thanks.

-- 
 Bastien

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-11-09 16:49 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-07 21:32 Bug: insert after hyperlink displaces mark during org-compat:org-move-to-column (since 8.1) [8.2.1 (release_8.2.1-45-g92f89e @ /home/rgarrett/src/org/orgmode/org-mode/lisp/)] Reuben Garrett
2013-11-07 21:49 ` Bastien
2013-11-07 22:29   ` Reuben Garrett
2013-11-08  7:46     ` Bastien
  -- strict thread matches above, loose matches on Subject: below --
2013-11-07 20:53 Reuben Garrett
2013-11-09 16:48 ` Bastien

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).