From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: org-infojs-handle-options fails when :infojs-opt is not in exp-list Date: Thu, 8 Jan 2009 15:36:36 +0100 Message-ID: References: <20081223104736.GA25075@taupan.ath.cx> <20081223105631.GA25285@taupan.ath.cx> <20081223111440.GA25702@taupan.ath.cx> <20090108141220.GA5649@taupan.ath.cx> Mime-Version: 1.0 (Apple Message framework v929.2) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LKw01-0003UN-Bc for emacs-orgmode@gnu.org; Thu, 08 Jan 2009 09:36:41 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LKw00-0003UB-P7 for emacs-orgmode@gnu.org; Thu, 08 Jan 2009 09:36:41 -0500 Received: from [199.232.76.173] (port=55020 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LKw00-0003U8-NB for emacs-orgmode@gnu.org; Thu, 08 Jan 2009 09:36:40 -0500 Received: from ug-out-1314.google.com ([66.249.92.175]:42471) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LKw00-0006mr-9g for emacs-orgmode@gnu.org; Thu, 08 Jan 2009 09:36:40 -0500 Received: by ug-out-1314.google.com with SMTP id 36so2377662uga.17 for ; Thu, 08 Jan 2009 06:36:39 -0800 (PST) In-Reply-To: <20090108141220.GA5649@taupan.ath.cx> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: friedel@nomaden.org Cc: emacs-orgmode@gnu.org Apparently, I had indeed overlooked this patch. Fixed now, thanks for resending it. - Carsten On Jan 8, 2009, at 3:12 PM, Friedrich Delgado Friedrichs wrote: > Hi. > > A while ago I had this problem: > org-infojs-handle-options: Wrong type argument: stringp, nil > > I wonder if my patch ever reached the mailing list, or if it > was overlooked because it was too close to christmas: > > Friedrich Delgado Friedrichs schrieb: >>> From 0fef25f56c837ae9f434449c6f30268e0474f7ab Mon Sep 17 00:00:00 >>> 2001 >> From: Friedrich Delgado Friedrichs >> Date: Tue, 23 Dec 2008 12:10:42 +0100 >> Subject: [PATCH] fix string-match against nil when no in-file >> options are set for jsinfo >> >> --- >> lisp/org-jsinfo.el | 3 ++- >> 1 files changed, 2 insertions(+), 1 deletions(-) >> >> diff --git a/lisp/org-jsinfo.el b/lisp/org-jsinfo.el >> index 8f2d7e8..19faa9e 100644 >> --- a/lisp/org-jsinfo.el >> +++ b/lisp/org-jsinfo.el >> @@ -140,7 +140,8 @@ Option settings will replace the %MANAGER- >> OPTIONS cookie." >> default (cdr (assoc opt org-infojs-options))) >> (and (symbolp default) (not (memq default '(t nil))) >> (setq default (plist-get exp-plist default))) >> - (if (string-match (format " %s:\\(\\S-+\\)" opt) v) >> + (if (and v >> + (string-match (format " %s:\\(\\S-+\\)" opt) v)) >> (setq val (match-string 1 v)) >> (setq val default)) >> (cond >> -- >> 1.6.0.2.526.g5c283.dirty > ---Zitatende--- > > -- > Friedrich Delgado Friedrichs > Laziness led to the invention of the most useful tools. > > > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode