emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Li Zhuo <fantanstic@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Patch on org-agenda-cmp-user-defined not called
Date: Thu, 6 Jul 2017 09:06:57 +0800	[thread overview]
Message-ID: <CA+viYURioQ2aTG=Ht-FAtyF+0SUioJBntAagLkkNhbQZH3NBDA@mail.gmail.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 11 bytes --]

-- 
lizhuo

[-- Attachment #1.2: Type: text/html, Size: 124 bytes --]

[-- Attachment #2: 0001-fix-org-agenda-cmp-user-defined-not-called-when-user.patch --]
[-- Type: text/x-patch, Size: 1104 bytes --]

From ed3ca2c1ea88b452fe3d324216740664de83a218 Mon Sep 17 00:00:00 2001
From: Vacker <fantanstic@gmail.com>
Date: Wed, 5 Jul 2017 19:38:01 +0800
Subject: [PATCH] fix `org-agenda-cmp-user-defined` not called when user has
 defined it

---
 lisp/org-agenda.el | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 652fada..3a0248e 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -7007,10 +7007,9 @@ their type."
 	 (alpha-down      (if alpha-up (- alpha-up) nil))
 	 (need-user-cmp   (org-em 'user-defined-up 'user-defined-down ss))
 	 user-defined-up user-defined-down)
-    (if (and need-user-cmp org-agenda-cmp-user-defined
-	     (functionp org-agenda-cmp-user-defined))
+    (if (and need-user-cmp (functionp 'org-agenda-cmp-user-defined))
 	(setq user-defined-up
-	      (funcall org-agenda-cmp-user-defined a b)
+	      (funcall 'org-agenda-cmp-user-defined a b)
 	      user-defined-down (if user-defined-up (- user-defined-up) nil)))
     (cdr (assoc
 	  (eval (cons 'or org-agenda-sorting-strategy-selected))
-- 
2.7.4


             reply	other threads:[~2017-07-06  1:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-06  1:06 Li Zhuo [this message]
2017-07-06 16:53 ` Patch on org-agenda-cmp-user-defined not called Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+viYURioQ2aTG=Ht-FAtyF+0SUioJBntAagLkkNhbQZH3NBDA@mail.gmail.com' \
    --to=fantanstic@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).