From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id YFjiD/kxB19OFQAA0tVLHw (envelope-from ) for ; Thu, 09 Jul 2020 15:04:25 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id aBX+C/kxB1/qYgAAB5/wlQ (envelope-from ) for ; Thu, 09 Jul 2020 15:04:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7D2DD9409E6 for ; Thu, 9 Jul 2020 15:04:24 +0000 (UTC) Received: from localhost ([::1]:39648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jtY62-0002W8-CD for larch@yhetil.org; Thu, 09 Jul 2020 11:04:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtY5R-0002RT-Gc for emacs-orgmode@gnu.org; Thu, 09 Jul 2020 11:03:45 -0400 Received: from mail-ot1-x334.google.com ([2607:f8b0:4864:20::334]:46260) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jtY5J-0007Ck-Qq for emacs-orgmode@gnu.org; Thu, 09 Jul 2020 11:03:43 -0400 Received: by mail-ot1-x334.google.com with SMTP id n24so1877375otr.13 for ; Thu, 09 Jul 2020 08:03:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:reply-to:from:date:message-id:subject:to; bh=RipJFhkmysEKjvGd9e4ABBOdD6lk60F/zYd4qiCMFak=; b=qlcOpP1G/t4WkKm1qxTwzyX1AjaK59vHyAsMeOKDJFamDJBgIWL7xRJJo5BzX3SSSk ua4YQqFSifP4St8KlzXhNQ/z01jq2j0SRgKlXa9E5LRMAcnx8i5wG5qh6dZ2LWMYvjLb /1ZqKTLGsqwo7pZCqMtrO3PvYvHQY4ZQslxrggW+kvsWm6RnlHZc9LbUcdBJU4u8Jljn ET1TJ9EpmKgHfNqBxZDqfPaxqiQj6nmYnxV2Fjm9tWC0p4rL6luDJxyRfJNwTRqrYBUP jBB5EigXVDvtuS3UpHSFSacZZPAY2Y2Tj7WeTOKMsKEnYqOAT6XGyxbiMp63ef/UM8Rr uENA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:from:date:message-id :subject:to; bh=RipJFhkmysEKjvGd9e4ABBOdD6lk60F/zYd4qiCMFak=; b=Nt6uFBs8GtJxDjxP15HZGS1GytnEHvVwYejOyG5s5jnTFr5xWGKeebW5vD3ZghSiyu oWTIU949kQBSJ91EzjBQvgHuIB2w+7meZQ2PvsWT6yNJpec3xrEyqtJPsa8VZdW0JdeX x7Ifw/2C5Gyh1dmEziqozqWjJjDN1AkimSfteimItOHE6yfDpeui2KShpZnt5da7ouv7 Tz+ntFJmM7uekC8ivGGJw+Ejuh+U6bbv4yf7wau2N/wwCzZMr6cM+VeX93W4D+JJcH0l 5cn/NbMkzxn0h3XgXM1T3OuhKoRPOvsB1ECRF96Jp/CTMBJ2rMZiArTKAnPsu7vguBje 2VwQ== X-Gm-Message-State: AOAM531VLPWDTK4NPkKgjXFYSq/P/P02jOheY7lD5z7z9NgerWO0TB9+ CQUFka64CISUDGxO1VE7HOXR0knE6A3oYxsCRhYLvM0kwGE= X-Google-Smtp-Source: ABdhPJxleY8NnYw36+yvd1AqaIdiQp8qqF5XqQGUU7u/u/ZHbYNCoCiDCvKqy22ryeCt9W8frA3iUEKOQloNiLhONqk= X-Received: by 2002:a9d:5784:: with SMTP id q4mr52210309oth.356.1594307011481; Thu, 09 Jul 2020 08:03:31 -0700 (PDT) MIME-Version: 1.0 From: George Mauer Date: Thu, 9 Jul 2020 10:03:20 -0500 Message-ID: Subject: Updates to ob-racket mode, code review request To: emacs-orgmode Content-Type: multipart/alternative; boundary="0000000000001516b705aa038755" Received-SPF: pass client-ip=2607:f8b0:4864:20::334; envelope-from=gmauer@gmail.com; helo=mail-ot1-x334.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: gmauer@gmail.com Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=qlcOpP1G; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.71 X-TUID: zxpSlkcpTlPl --0000000000001516b705aa038755 Content-Type: text/plain; charset="UTF-8" I'm a big fan of using org mode to learn languages and have been using it for Racket (sorry Dr Racket, I just love emacs too much). It's been mostly fine and I've made a few patches to the [`ob-racket`]( https://github.com/xchrishawk/ob-racket) I've been using. Recently I've started to move into the build-your-own-language parts of Racket and found that ob-racket didn't support custom language directives. So [I modified it to support them](https://github.com/togakangaroo/ob-racket). I'm pretty new at elisp, so would anyone be willing to give me a code review to make sure I didn't do anything completely stupid? [It is a single not-too-large file]( https://github.com/togakangaroo/ob-racket/blob/master/ob-racket.el). Also looking for opinions on whether this is helpful enough/good enough to be worth pushing to melpa. --0000000000001516b705aa038755 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I'm= a big fan of using org mode to learn languages and have been using it for = Racket (sorry Dr Racket, I just love emacs too much). It's been mostly = fine and I've made a few patches to the [`ob-racket`](https://github.com/xchrishawk/ob-racket<= /a>)=C2=A0I've been using. Recently I've started to move into the b= uild-your-own-language parts of Racket and found that ob-racket didn't = support custom language directives. So [I modified it to support them](https://github.com/togaka= ngaroo/ob-racket).

I'm pretty = new at elisp, so would anyone be willing to give me a code review to make s= ure I didn't do anything completely stupid? [It is a single not-too-lar= ge file](https://github.com/togakangaroo/ob-racket/blob/master/ob-racke= t.el).

Also looking for opinions on whether th= is is helpful enough/good enough to be worth pushing to melpa.
<= /div>
--0000000000001516b705aa038755--