Updates to ob-racket mode, code review request

Updates to ob-racket mode, code review request

[George Mauer]

[-- Attachment #1: Type: text/plain, Size: 828 bytes --]

I'm a big fan of using org mode to learn languages and have been using it
for Racket (sorry Dr Racket, I just love emacs too much). It's been mostly
fine and I've made a few patches to the [`ob-racket`](
https://github.com/xchrishawk/ob-racket) I've been using. Recently I've
started to move into the build-your-own-language parts of Racket and found
that ob-racket didn't support custom language directives. So [I modified it
to support them](https://github.com/togakangaroo/ob-racket).

I'm pretty new at elisp, so would anyone be willing to give me a code
review to make sure I didn't do anything completely stupid? [It is a single
not-too-large file](
https://github.com/togakangaroo/ob-racket/blob/master/ob-racket.el).

Also looking for opinions on whether this is helpful enough/good enough to
be worth pushing to melpa.

[-- Attachment #2: Type: text/html, Size: 1193 bytes --]

Re: Updates to ob-racket mode, code review request

[Tom Gillespie]

Hi George,
  I took a glance at your additions, nothing jumps out as being problematic. I
have been using wallyqs ob-racket (https://github.com/wallyqs/ob-racket) for
about 4 years because it has support for specifying the #lang in the header,
and I seem to recall that there were some other features that were lacking in
all the (2? 3?) other ob-racket's that I tried. I do not think that any of the
existing ob-racket implementations should be put on melpa since they do not
interoperate with the recent work that Greg has done on racket-mode to
support comint and multiple repls (not to mention racket-xp-mode). Which is
to say, that I think that proper session support is a prerequisite for any
ob-racket implementation become "the" ob-racket on melpa or elsewhere. There
are also significant issues with how racket's "the top level is hopeless"
attitude interacts with things like org-babel's concept of a session (which
one might be able to make equivalent to a racket-mode repl). There are likely
ways around this, but I suspect they will involve something like
dynamic-rerequire and fiddling with namespaces to make it possible to
rerequire a module into an existing session. Alternately, compiled racket
modules load fast enough that running raco make on racket source blocks
behind the scenes might be able to fake a session-like experience. One place
to look for inspiration on this might be ob-clojure-literate which has to
deal with some similar issues. Another though related to sessions is around
the possibility of running racket blocks pointing to remote sessions. With
lisp blocks it is possible to switch to a session running on a remote server
and send the code to it that way. With the work that Greg has done for racket
mode it should be possible to spin up a remote racket session or connect to
one and then run the block in that session. Don't let this stop you though :)
Best!
Tom

Re: Updates to ob-racket mode, code review request

[Bastien]

Hi George,

George Mauer <gmauer@gmail.com> writes:

> I'm a big fan of using org mode to learn languages and have been
> using it for Racket (sorry Dr Racket, I just love emacs too much).
> It's been mostly fine and I've made a few patches to the [`ob-racket
> `](https://github.com/xchrishawk/ob-racket) I've been using. 

I don't see any mention of ob-racket.el in https://orgmode.org/worg/

This would be a nice addition - if you want, you can ask for a user
on worg and contribute to worg.git.

Thanks,

-- 
 Bastien