emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: George Mauer <gmauer@gmail.com>
To: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Updates to ob-racket mode, code review request
Date: Thu, 9 Jul 2020 10:03:20 -0500	[thread overview]
Message-ID: <CA+pajWLyuzVKA3GFSHgXzeqhOfwiVG-FDhe4BPf7Z6fQwVasRg@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 828 bytes --]

I'm a big fan of using org mode to learn languages and have been using it
for Racket (sorry Dr Racket, I just love emacs too much). It's been mostly
fine and I've made a few patches to the [`ob-racket`](
https://github.com/xchrishawk/ob-racket) I've been using. Recently I've
started to move into the build-your-own-language parts of Racket and found
that ob-racket didn't support custom language directives. So [I modified it
to support them](https://github.com/togakangaroo/ob-racket).

I'm pretty new at elisp, so would anyone be willing to give me a code
review to make sure I didn't do anything completely stupid? [It is a single
not-too-large file](
https://github.com/togakangaroo/ob-racket/blob/master/ob-racket.el).

Also looking for opinions on whether this is helpful enough/good enough to
be worth pushing to melpa.

[-- Attachment #2: Type: text/html, Size: 1193 bytes --]

             reply	other threads:[~2020-07-09 15:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-09 15:03 George Mauer [this message]
2020-07-14  5:54 ` Updates to ob-racket mode, code review request Tom Gillespie
2020-09-04 14:20 ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+pajWLyuzVKA3GFSHgXzeqhOfwiVG-FDhe4BPf7Z6fQwVasRg@mail.gmail.com \
    --to=gmauer@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).