Re: Bug: Symlink handling in org-babel-load-file

[ricky saurav <ricky.saurav1996@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 738 bytes --]

Hey Bastien,
After this patch, org-mode loads the most updated config. A minor issue
that I have is that this patch creates config.el in my dotfiles directory,
instead of ~/.emacs.d/config.el ,since ~/.emacs.d/config.org is a symlink
to ~/dotfiles/config.org. The behaviour in org-9.1.5(emacs 26.3), was
resolution of symlinks for just fetching the file
attributes(file-modification-time). The below patch summarizes the changes
that would keep the current version in line with current version in emacs
release  org-9.1.5(emacs 26.3).
Regards,
Saurav

On Wed, 12 Feb 2020 at 17:40, Bastien <bzg@gnu.org> wrote:

> Hi Ricky,
>
> thanks for reporting this.
>
> Can you try this patch and confirm it solves your issue?
>
>
> --
>  Bastien
>

[-- Attachment #1.2: Type: text/html, Size: 1156 bytes --]

[-- Attachment #2: org-babel-load-file.patch --]
[-- Type: text/x-patch, Size: 875 bytes --]

diff --git a/lisp/org.el b/lisp/org.el
index 1a995cc40..239e3528f 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -218,12 +218,11 @@ and then loads the resulting file using `load-file'.  With
 optional prefix argument COMPILE, the tangled Emacs Lisp file is
 byte-compiled before it is loaded."
   (interactive "fFile to load: \nP")
-  (let* ((file (file-truename file))
-	 (tangled-file (concat (file-name-sans-extension file) ".el")))
+  (let* ((tangled-file (concat (file-name-sans-extension file) ".el")))
     ;; Tangle only if the Org file is newer than the Elisp file.
     (unless (org-file-newer-than-p
 	     tangled-file
-	     (file-attribute-modification-time (file-attributes file)))
+	     (file-attribute-modification-time (file-attributes (file-truename file))))
       (org-babel-tangle-file file tangled-file "emacs-lisp\\|elisp"))
     (if compile
 	(progn